Tuesday, January 7, 2025
7 changes · saas-17.4
Resolved issues and error corrections
This fixes an issue in Point of Sale where validating a split bill containing a combo product could fail. Businesses using restaurant or retail bill splitting can now complete these orders more reliably without checkout interruptions.
Original PR description
Before this commit, validating a split bill that contains a combo product would result in a key error. opw-4416406 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Products marked available for Point of Sale but not for self-order will no longer appear in kiosk or mobile menus. This avoids showing unavailable items with confusing out-of-stock labels and keeps customer menus aligned with the intended self-order offering.
Original PR description
Before this commit, if you made a product available in PoS but set it to not be available in self order, it would still appear in the kiosk or mobile menu with an "out of stock" tag, which is confusing and not the expected behavior. opw-4200540 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where a point of sale session could mistakenly react to its own closing notification. It helps avoid unnecessary duplicate synchronization during session closing, making the closing process more reliable for cashiers and managers.
Original PR description
When entering the method `closingSessionNotification`, the method checks if `data.login_number === this.session.login_number` but `data.login_number` can be a string or a number so the comparison should be `data.login_number == odoo.login_number` to prevent self calling. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Panama tax identification label is updated to use RUC, the correct local term, instead of the generic Tax ID/NIF wording. This improves accuracy on invoices, sales documents, and country data for Panamanian businesses, with the base label applying to newly created databases and translations updated for existing usage.
Original PR description
In Panama, the Tax ID is the Registro Único de Contribuyentes (RUC) and not the Número de Identificación Fiscal (NIF). This is a double fix: 1. Update the `vat_label` to use "RUC" instead of "Tax ID", but this will only be available for new created DBs (because of noupdate) 2. Update the translation of Tax ID for Panama which only requires to update the translations to have the correct translation of Tax ID. opw-4388758
This fixes an issue where Discuss call volume preferences were not being found or applied correctly. Users should now have their saved volume settings respected during calls, improving consistency and avoiding unexpected audio levels.
Original PR description
Since https://github.com/odoo/odoo/pull/169691, the user volumes were not correctly searched from the settings, this commit fixes this issue.
This fixes an automated test for account report sections that could fail around the change of year. The update makes the test use the correct previous reporting period, improving release reliability without changing business features.
Original PR description
[FIX] account_reports: sections tour The sections' tour was breaking with the change of year. We use the generic tax report for doing the testing. The generic tax report has a periodicity of 1 month and opens at the previous period. Our tests where based on the current date year. It works fine except on the change of year. Indeed, we will be on January of year XXXX but the report will open on December of year YYYY. Now, we correctly remove 1 month to our dates to make sure we have the correct year. We also took the time to replace the usage of Date of plain javascript with DateTime of the luxon library.
Budget entries now handle the case where an end date is set one day before the start date without triggering a system error. This prevents users from encountering a crash when entering invalid budget dates and supports clearer validation of budget data.
Original PR description
This error occurs when the user enters an ``End Date`` that is one day earlier than the ``Start Date``(e.g. Start Date: '25/12/2024' and End Date: '24/12/2024'). Steps to reproduce: --- - Install the ``account_budget`` module - Create a new budget, fill in all required fields, and add a line - ``Start Date: '25/12/2024' and End Date: '24/12/2024'`` Traceback: --- ``ZeroDivisionError: float division by zero`` At [1], this error occurs because when the ``End Date`` is set to one day before the ``Start Date``, the ``line_timedelta`` becomes zero. As a result, the denominator evaluates to zero. [1]- https://github.com/odoo/enterprise/blob/3cfb6517220ae252d633bb9debc5010a0f14efbe/account_budget/models/budget_line.py#L77-L79 This commit resolves the error by ensuring zero should not be in the denominator. sentry-6174377667