Wednesday, January 8, 2025
29 changes · saas-17.4
Resolved issues and error corrections
The Jordanian e-invoicing module's automated tests were adjusted to remove reliance on an unrelated enterprise reporting component. This helps keep testing aligned with the module's actual requirements and reduces maintenance issues without changing user-facing behavior.
Original PR description
The unit tests were having a dependency from account_reports module which is not a dependency of the l10n_jo_edi module nor even a community module. This commit removes this dependency. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a configuration issue that prevented the Field Service task action from correctly showing the activity view. Users will have access to the expected activity view when working with field service tasks, reducing confusion and improving navigation consistency.
Original PR description
- In version 17.3, the activity view mode is defined for both the project_task_action_fsm action and the project_task_action_fsm_map action. However, it has been observed that a record named…
- In version 17.3, the activity view mode is defined for both the project_task_action_fsm action and the project_task_action_fsm_map action. However, it has been observed that a record named project_task_action_fsm_map_view_activity also exists. This redundancy causes the project_task_action_fsm action to not be properly configured with the activity view mode, as no corresponding view link or defined view exists. - Additionally, the record project_task_action_fsm_map_view_activity has the same name, but no corresponding record has been created. To resolve this issue, I have renamed the record to ensure consistency with its definition in the XML file. see upgrade : odoo/upgrade/pull/6838 [Reference](https://github.com/odoo/enterprise/commit/f16c338c2c20a0424ef749bdf35d1b7863347a8e#diff-170f2bf3c03ad1bf01ffe9fd0d8490e6ee7e193f96da6ad8d8babfe6e3867706R471) **Steps to Reproduce:** 1) Create a database in version saas-17.4 and install the industry_fsm module. 2) Check the project_task_action_fsm action and note that the activity view mode and view are not defined. upg-2202488 tbg-1597
The Intrastat settings screen now shows the proper transaction codes when choosing a default value, instead of displaying commodity codes. This prevents confusion during configuration and helps users select the correct reporting option.
Original PR description
Starting from saas-17.4, the default transaction code in settings shows the commidity code instead of transaction codes. This commit applies the domain for showing transaction codes instead. opw-4419718
Miscellaneous changes
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines.  **Expected:** Accountants should be allowed to manage the products database. **Steps to reproduce:** - Activate Invoicing app; - Configure a branch to the company; - Create a user with an accounting `Accountant` role and set the branch company as only entry in Allowed Companies and as Default C
Original PR description
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines. …
**Issue:** Accountants cannot create products through Customer Invoice or Vendor Bill product lines.  **Expected:** Accountants should be allowed to manage the products database. **Steps to reproduce:** - Activate Invoicing app; - Configure a branch to the company; - Create a user with an accounting `Accountant` role and set the branch company as only entry in Allowed Companies and as Default Company;  - Log in as that new user; - Try create a new product through a Customer Invoice or a Vendor Bill. **Cause:** The `Accountant` role itself has no right on products. **Fix:** Reset a previously removed (february 2023 (saas-16.2) odoo/odoo@512574861691f425ec6a17f20fe4b586bb88a299) access right on `product_template` for group `group_account_manager`.  **Note:** This PR replaces https://github.com/odoo/enterprise/pull/75453 after discussion with reviewer. opw-4293151 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#190360
Issue: - run the `test_account_manager_user_can_create_product` with `account`and its dependencies as the only modules installed - error is given as `product` is not a valid product type (it is added in the `stock` module) Solution: - replace `product` with a product type that is defined in one of the dependencies --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192462
Original PR description
Issue: - run the `test_account_manager_user_can_create_product` with `account`and its dependencies as the only modules installed - error is given as `product` is not a valid product type (it is added in the `stock` module) Solution: - replace `product` with a product type that is defined in one of the dependencies --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192462
In journal items, when grouping by 'Internal Group', a traceback appears due to referencing a non-existent table `account_account` as it has been joined with `account_move_line`. This commit ensures the referenced table is correctly updated in the case of joins. opw-4405281 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192489
Original PR description
In journal items, when grouping by 'Internal Group', a traceback appears due to referencing a non-existent table `account_account` as it has been joined with `account_move_line`. This commit ensures the referenced table is correctly updated in the case of joins. opw-4405281 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192489
When printing long product names with long variants, the lines were overlapping. Steps to reproduce: ------------------- * Create a product with some long variant names * Setup a kitchen printer * Add the order to a PoS order * Print the order on the kitchen printer > Observation: The product name and variant name are overlapping Before:  After:  After:  opw-4414311 Forward-Port-Of: odoo/odoo#192690 Forward-Port-Of: odoo/odoo#192544
Those constraints are blocking the flow for no good reason as we - don't find them in the official documentation - they don't really make sense in the context of a credit note Therefore we decide to remove them for credit notes. They don't seem to be required for the facturx validity. task-4454115 Forward-Port-Of: odoo/odoo#192495
Original PR description
Those constraints are blocking the flow for no good reason as we - don't find them in the official documentation - they don't really make sense in the context of a credit note Therefore we decide to remove them for credit notes. They don't seem to be required for the facturx validity. task-4454115 Forward-Port-Of: odoo/odoo#192495
opw-4409456
Original PR description
opw-4409456
If you create a pricelist rule with a discount that has a valid date range, that discount is only applied if the SO was created in that range. Even if it is confirmed within the valid date range. Fix: For website_sale orders we consider the date to be the current time when computing the price. opw-4375643 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192572 Forward-Port-Of: odoo/odoo#191538
Original PR description
If you create a pricelist rule with a discount that has a valid date range, that discount is only applied if the SO was created in that range. Even if it is confirmed within the valid date range. Fix: For website_sale orders we consider the date to be the current time when computing the price. opw-4375643 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192572 Forward-Port-Of: odoo/odoo#191538
Before this commit: pos_stripe doesn't specify a Stripe version when doing its requests. Because of this, Stripe defaults to the API version defined on the Stripe account. This varies from customer to customer, as it is automatically configured to use the latest API version available when the first API request is received. Stripe regularly makes breaking changes to their API: https://docs.stripe.com/changelog?breaking=true for example removing the `charges` attribute: https://docs.stripe.com
Original PR description
Before this commit: pos_stripe doesn't specify a Stripe version when doing its requests. Because of this, Stripe defaults to the API version defined on the Stripe account. This varies from customer to customer, as it is automatically configured to use the latest API version available when the first API request is received. Stripe regularly makes breaking changes to their API: https://docs.stripe.com/changelog?breaking=true for example removing the `charges` attribute: https://docs.stripe.com/changelog/2022-11-15/removes-charges-attribute-paymentintent which we use in pos_stripe. After this commit: We rely on payment_stripe._stripe_make_request which hardcode the API version number. Such change was already started in `pos_stripe.stripe_capture_payment` opw-4375876 Forward-Port-Of: odoo/odoo#192008
In Odoo, an issue araised where the "Expected Arrival" date field was overlapped when zooming in. This was due to the button "action_purchase_vendor_delay_report". To adress this, the related button was encapsulated within a <div> element. This change ensure that the layout remains consistent and the elements does not overlap regardless of the zoom level. opw-4316093 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187
Original PR description
In Odoo, an issue araised where the "Expected Arrival" date field was overlapped when zooming in. This was due to the button "action_purchase_vendor_delay_report". To adress this, the related button was encapsulated within a <div> element. This change ensure that the layout remains consistent and the elements does not overlap regardless of the zoom level. opw-4316093 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187179
**Current behaviour before PR:** In website, when trying to apply color or any style on a link from toolbar whole link gets selected. This happens because in `wysiwyg.js` `destroyLinkTools` method gets called when user clicks on toolbar to apply color. **Behaviour after PR:** Now, any style can be applied on a link without selecting whole link. task-4072867 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#1
Original PR description
**Current behaviour before PR:** In website, when trying to apply color or any style on a link from toolbar whole link gets selected. This happens because in `wysiwyg.js` `destroyLinkTools` method gets called when user clicks on toolbar to apply color. **Behaviour after PR:** Now, any style can be applied on a link without selecting whole link. task-4072867 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192297 Forward-Port-Of: odoo/odoo#180616
Current behavior before PR: When multiple types of lists were selected and the deleteBackward operation was performed, the list type remained unchanged. Desired behavior after PR is merged: When deleteBackward is pressed with multiple types of lists selected, and all selected content is removed, if the anchor node's list item is empty, that list item type will change to match the type of the list where the deleteBackward operation started. task:4187739 Forward-Port-Of: odoo/odoo#191
Original PR description
Current behavior before PR: When multiple types of lists were selected and the deleteBackward operation was performed, the list type remained unchanged. Desired behavior after PR is merged: When deleteBackward is pressed with multiple types of lists selected, and all selected content is removed, if the anchor node's list item is empty, that list item type will change to match the type of the list where the deleteBackward operation started. task:4187739 Forward-Port-Of: odoo/odoo#191915 Forward-Port-Of: odoo/odoo#180687
**Steps to reproduce:** - Install l10n_es_edi_tbai - Switch to a Spanish company (e.g. ES Company) - Create an invoice with "Simplified Invoice Partner (ES)" as customer - Confirm the invoice - Process the invoice with "TicketBAI (ES)" service **Issue:** The generated XML has 2 regime keys (02 and 52) for <ClaveRegimenIvaOpTrascendencia> that are not compatible with each other. From the documentation, regime key "52" (for simplified invoices) can only be associated with regime key "51"
Original PR description
**Steps to reproduce:** - Install l10n_es_edi_tbai - Switch to a Spanish company (e.g. ES Company) - Create an invoice with "Simplified Invoice Partner (ES)" as customer - Confirm the invoice - Process the invoice with "TicketBAI (ES)" service **Issue:** The generated XML has 2 regime keys (02 and 52) for <ClaveRegimenIvaOpTrascendencia> that are not compatible with each other. From the documentation, regime key "52" (for simplified invoices) can only be associated with regime key "51", which is not supported for the moment. **Solution:** If the "Simplified Invoice Partner" is used, only the regime key "52" is used. opw-4332052 opw-4355424 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192687 Forward-Port-Of: odoo/odoo#192448
**Problem**: When selecting all content (`Ctrl+A`) in an empty editable area, the selection includes only a `<br>` element. This causes issues when interacting with non-selectable content inside the selection, leading to unexpected behavior. **Solution**: If the selection contains only on `br` element, reset the selection on click to avoid inconsistent states. **Steps to Reproduce**: 1. Open the editor. 2. Press `Ctrl+A` to select all. 3. Click anywhere within the editable area to hid
Original PR description
**Problem**: When selecting all content (`Ctrl+A`) in an empty editable area, the selection includes only a `<br>` element. This causes issues when interacting with non-selectable content inside the selection, leading to unexpected behavior. **Solution**: If the selection contains only on `br` element, reset the selection on click to avoid inconsistent states. **Steps to Reproduce**: 1. Open the editor. 2. Press `Ctrl+A` to select all. 3. Click anywhere within the editable area to hide the toolbar. 4. Observe that the toolbar remains visible, and the selection state does not update. opw-4438513 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192084
- add check on `employee_id` to the contract domain to exclude templates from the contract count on the stat buttons as it gives misleading info about the real contracts count Task: 4402795 Forward-Port-Of: odoo/odoo#192145
Original PR description
- add check on `employee_id` to the contract domain to exclude templates from the contract count on the stat buttons as it gives misleading info about the real contracts count Task: 4402795 Forward-Port-Of: odoo/odoo#192145
When the user tries to reset the password, a traceback will appear. Steps to reproduce the error: - Install ``auth_signup`` - Configure "Outgoing mail server" - Now Log out - Click on Sign in > Reset Password > Enter your email > Click on ``Reset Password`` twice Traceback: ``` InFailedSqlTransaction: current transaction is aborted, commands ignored until end of transaction block File "odoo/http.py", line 2365, in __call__ response = request._serve_db() File "odoo/htt
Original PR description
When the user tries to reset the password, a traceback will appear. Steps to reproduce the error: - Install ``auth_signup`` - Configure "Outgoing mail server" - Now Log out - Click on Sign in > Reset…
When the user tries to reset the password, a traceback will appear.
Steps to reproduce the error:
- Install ``auth_signup``
- Configure "Outgoing mail server"
- Now Log out
- Click on Sign in > Reset Password > Enter your email >
Click on ``Reset Password`` twice
Traceback:
```
InFailedSqlTransaction: current transaction is aborted, commands ignored until end of transaction block
File "odoo/http.py", line 2365, in __call__
response = request._serve_db()
File "odoo/http.py", line 1892, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1955, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 137, in retrying
result = func()
File "odoo/http.py", line 1922, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2082, in dispatch
return self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 331, in _dispatch
result.flatten()
File "odoo/http.py", line 1389, in flatten
self.response.append(self.render())
File "odoo/http.py", line 1381, in render
return request.env["ir.ui.view"]._render_template(self.template, self.qcontext)
File "home/odoo/src/enterprise/18.0/web_studio/models/ir_ui_view.py", line 1315, in _render_template
return super(View, self)._render_template(template, values)
File "odoo/addons/base/models/ir_ui_view.py", line 2185, in _render_template
return self.env['ir.qweb']._render(template, values)
File "odoo/tools/profiler.py", line 306, in _tracked_method_render
return method_render(self, template, values, **options)
File "odoo/addons/base/models/ir_qweb.py", line 597, in _render
template_functions, def_name = irQweb._compile(template)
File "odoo/tools/profiler.py", line 314, in _tracked_compile
return method_compile(self, template)
File "odoo/addons/base/models/ir_qweb.py", line 666, in _compile
return self._load_values(base_key_cache, generate_functions)
File "odoo/addons/base/models/ir_qweb.py", line 2524, in _load_values
return get_value()
File "odoo/addons/base/models/ir_qweb.py", line 635, in generate_functions
code, options, def_name = self._generate_code(template)
File "odoo/addons/base/models/ir_qweb.py", line 691, in _generate_code
element, document, ref = self._get_template(template)
File "odoo/addons/base/models/ir_qweb.py", line 822, in _get_template
doc_or_elem, ref = self._load(ref_alias) or (None, None)
File "odoo/addons/base/models/ir_qweb.py", line 859, in _load
view = IrUIView._get(ref)
File "odoo/addons/base/models/ir_ui_view.py", line 2085, in _get
return self.browse(self._get_view_id(view_ref))
File "odoo/addons/base/models/ir_ui_view.py", line 2073, in _get_view_id
view = self.sudo().search([('key', '=', template)], limit=1)
File "odoo/models.py", line 1717, in search
return self.search_fetch(domain, [], offset=offset, limit=limit, order=order)
File "odoo/models.py", line 1749, in search_fetch
return self._fetch_query(query, fields_to_fetch)
File "odoo/models.py", line 4180, in _fetch_query
fetched = self.browse(query)
File "odoo/models.py", line 6154, in browse
if not ids:
File "odoo/tools/query.py", line 261, in __bool__
return bool(self.get_result_ids())
File "odoo/tools/query.py", line 225, in get_result_ids
self._ids = tuple(id_ for id_, in self._env.execute_query(self.select()))
File "odoo/api.py", line 962, in execute_query
self.cr.execute(query)
File "odoo/sql_db.py", line 354, in execute
res = self._obj.execute(query, params)
```
After this commit, user can not click on ``Reset Password`` button multiple times.
sentry-5661309399
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#190833
Forward-Port-Of: odoo/odoo#184862**Steps to reproduce:** - Install point_of_sale and l10n_mx_edi - Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE) - Create a product with an UNSPSC Category - In POS settings, enable "Use QR code on ticket" option - Open a POS session - Make an orders with the created product (without invoice) - Print the receipt - Close the POS session - Scan the QR code on the receipt with a mobile (Or just open the link retrieved from the QR code in a browser from the computer without being
Original PR description
**Steps to reproduce:** - Install point_of_sale and l10n_mx_edi - Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE) - Create a product with an UNSPSC Category - In POS settings, enable "Use QR…
**Steps to reproduce:** - Install point_of_sale and l10n_mx_edi - Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE) - Create a product with an UNSPSC Category - In POS settings, enable "Use QR code on ticket" option - Open a POS session - Make an orders with the created product (without invoice) - Print the receipt - Close the POS session - Scan the QR code on the receipt with a mobile (Or just open the link retrieved from the QR code in a browser from the computer without being logged) - Enter all the required data - Click several times on "Get my invoice" button quickly to generate the invoice **Issue:** Several concurrent processes are executed to create the invoice. In the Mexican localization, an electronic invoice is also generated and signed. However, an error is raised when trying to commit the electronic invoice document from the concurrent processes. These errors prevents the normal flow to continue after the creation of the invoice and the reversal of the POS closing entry is not generated as expected. **Solution:** Disable the "Get my invoice" button when the form is submitted to prevent concurrent calls to the action. opw-4399540 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192016
**Steps to reproduce:** - Install hr_expense - Create 2 alias domains - Go to "Settings / Technical / Email / Aliases" - Check the values for Expense model - Go to Expenses settings - Change the prefix and the domain of the alias - Save - Go to "Settings / Technical / Email / Aliases" - Check the values for Expense model again **Issue:** The prefix has correctly been modified but not the domain. The domain from Expenses settings and the domain of the Expense alias are different.
Original PR description
**Steps to reproduce:** - Install hr_expense - Create 2 alias domains - Go to "Settings / Technical / Email / Aliases" - Check the values for Expense model - Go to Expenses settings - Change the…
**Steps to reproduce:** - Install hr_expense - Create 2 alias domains - Go to "Settings / Technical / Email / Aliases" - Check the values for Expense model - Go to Expenses settings - Change the prefix and the domain of the alias - Save - Go to "Settings / Technical / Email / Aliases" - Check the values for Expense model again **Issue:** The prefix has correctly been modified but not the domain. The domain from Expenses settings and the domain of the Expense alias are different. **Cause:** The domain field in Expenses settings is in fact the Email Domain (alias_domain_id) of the company, which makes no sense to combine the prefix and the domain from 2 different sources. **Solution:** Add a non-stored computed field to map the domain displayed in Expenses settings with the domain of the Expense alias. Not great in stable, but there is no other way if we want to keep the option. opw-4293936 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192571 Forward-Port-Of: odoo/odoo#190252
Description of the issue this PR addresses: Current behavior before PR: Triple-clicking to select text, with a nextSibling set as contenteditable false, would reset the selection to its previous state. Desired behavior after PR is merged: Correct the triple click selection when applying font-size. task-4440354 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192387 Forward-Port-Of: odoo/odoo#192139
Original PR description
Description of the issue this PR addresses: Current behavior before PR: Triple-clicking to select text, with a nextSibling set as contenteditable false, would reset the selection to its previous state. Desired behavior after PR is merged: Correct the triple click selection when applying font-size. task-4440354 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#192387 Forward-Port-Of: odoo/odoo#192139
On small displays, starting a new website livechat with an operator that has an `user_livechat_username` crashes when rendering the username. Steps to reproduce ----- 1. Select User Menu Icon > My Profile / Preferences > enter an Online Chat Name 2. On a mobile device or small window, open the livechat on the website 3. Send any new message 4. The following traceback occurs ``` Caused by: TypeError: Cannot read properties of undefined (reading 'channel_type') at get authorName ``
Original PR description
On small displays, starting a new website livechat with an operator that has an `user_livechat_username` crashes when rendering the username.
Steps to reproduce
-----
1. Select User Menu Icon > My Profile / Preferences > enter an Online Chat Name
2. On a mobile device or small window, open the livechat on the website
3. Send any new message
4. The following traceback occurs
```
Caused by: TypeError: Cannot read properties of undefined (reading 'channel_type')
at get authorName
```
Cause
-----
On small displays, `thread` for the default operator message becomes undefined when it is reassigned to the new thread. This causes an error in `get authorName()` when the undefined `thread` is accessed directly to detemine the displayed username.
Solution
-----
Add an optional chain (?) when accessing `this.message.thread` to handle the possible nullish value.
opw-4446208
Backport of odoo/odoo#192605
Forward-Port-Of: odoo/odoo#192739When [adding this module], the translations were forgotten. We are adding them here. [adding this module]: https://github.com/odoo/enterprise/commit/055ed588dd7558c568373fbaa6d24208d0aeeb87 opw-4425163 Forward-Port-Of: odoo/enterprise#76612
Original PR description
When [adding this module], the translations were forgotten. We are adding them here. [adding this module]: https://github.com/odoo/enterprise/commit/055ed588dd7558c568373fbaa6d24208d0aeeb87 opw-4425163 Forward-Port-Of: odoo/enterprise#76612
Some 2024 years were encoded in test files. Backport of #76393 Forward-Port-Of: odoo/enterprise#76641
Original PR description
Some 2024 years were encoded in test files. Backport of #76393 Forward-Port-Of: odoo/enterprise#76641
If stock was not installed, we could not run skip test_prevent_advance_payment_delivered_quantity_product, as there is no qty_to_deliver field in sale.order.line model. By moving the test to sale_subscription_stock, we are solving this issue [link to broken tests](https://runbot.odoo.com/web#id=108148&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form) Forward-Port-Of: odoo/enterprise#75149
Original PR description
If stock was not installed, we could not run skip test_prevent_advance_payment_delivered_quantity_product, as there is no qty_to_deliver field in sale.order.line model. By moving the test to sale_subscription_stock, we are solving this issue [link to broken tests](https://runbot.odoo.com/web#id=108148&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form) Forward-Port-Of: odoo/enterprise#75149
Fixing a leftover traceback when there's no IBAN on the partner's bank. Fixed in 17.0. Task [link](https://www.odoo.com/odoo/project/967/tasks/4254966) task-4254966 Forward-Port-Of: odoo/enterprise#76091
Original PR description
Fixing a leftover traceback when there's no IBAN on the partner's bank. Fixed in 17.0. Task [link](https://www.odoo.com/odoo/project/967/tasks/4254966) task-4254966 Forward-Port-Of: odoo/enterprise#76091
Steps to reproduce: ------------- - Install Sales, Field Service, and Stock, - Go into Field service and open any task that has products. - Through stat button on the top access the product catalog. - Click on burger menu on any service type product. Issue: - View Availability option should not be shown for service type products Cause: - No condition to make it invisible. Solution: - Added a condition when product type is service to the option invisible. task-3801551
Original PR description
Steps to reproduce: ------------- - Install Sales, Field Service, and Stock, - Go into Field service and open any task that has products. - Through stat button on the top access the product catalog. - Click on burger menu on any service type product. Issue: - View Availability option should not be shown for service type products Cause: - No condition to make it invisible. Solution: - Added a condition when product type is service to the option invisible. task-3801551 Forward-Port-Of: odoo/enterprise#75757 Forward-Port-Of: odoo/enterprise#58817
* is l10n_{au,be,ch,hk,lu,ma,us}_hr_payroll - When miltiple companies it shows `X Localization` block only in payroll settings Where X is the cuntry of the current chosien company Task: 4409568 Forward-Port-Of: odoo/enterprise#75683
Original PR description
* is l10n_{au,be,ch,hk,lu,ma,us}_hr_payroll
- When miltiple companies it shows `X Localization` block only in payroll settings Where X is the cuntry of the current chosien company
Task: 4409568
Forward-Port-Of: odoo/enterprise#75683When adding a column that is not in the query result in the partner ledger, such as `amount_residual` for example, we get an ugly traceback when unfolding a partner. With this commit, we raise an UserError instead. opw-4416369 Forward-Port-Of: odoo/enterprise#76521 Forward-Port-Of: odoo/enterprise#76284
Original PR description
When adding a column that is not in the query result in the partner ledger, such as `amount_residual` for example, we get an ugly traceback when unfolding a partner. With this commit, we raise an UserError instead. opw-4416369 Forward-Port-Of: odoo/enterprise#76521 Forward-Port-Of: odoo/enterprise#76284