Wednesday, January 8, 2025
18 changes
1 change
Resolved issues and error corrections
Fixes an issue where grouping journal items by Internal Group could cause an error instead of showing results. This makes financial reporting views more reliable for users organizing accounting entries.
Original PR description
In journal items, when grouping by 'Internal Group', a traceback appears due to referencing a non-existent table `account_account` as it has been joined with `account_move_line`. This commit ensures the referenced table is correctly updated in the case of joins. opw-4405281 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
A payroll-related automated test was adjusted to match a recent change in how notification messages are displayed. This helps keep Belgian payroll accounting checks reliable without changing the employee or payroll user experience.
Original PR description
Purpose of this commit: Following the changes in https://github.com/odoo/odoo/pull/189853, the o-mail-Message-body class is no longer applied to messages with a message_type of 'notification'. This commit updates the corresponding failing tour. task-4291913
15 changes
Resolved issues and error corrections
The push-to-talk sound effects in Discuss calls are now much quieter. Users can still hear when push-to-talk is turned on or off, but the sounds should no longer be distracting during conversations.
Original PR description
Before this commit, when using push-to-talk during discuss call, the sound effect from press and release of ptt was too loud. This commit reduces the volume drastically, so this can still be heard but it's low enough to not be distracting. Before https://github.com/user-attachments/assets/af330e28-4351-44ab-a1df-46730b658379 After https://github.com/user-attachments/assets/77e34eec-6099-4172-b1b5-f407122bd1ca
Users can now close the “Turn on notifications” suggestion in the messaging menu when they do not want to act on it. This reduces repeated prompts while leaving browser notification permissions unchanged, so users can still manage them later in browser settings.
Original PR description
This commit adds a "X" next to "Turn on notifications" to quickly dismiss the suggestion to enable push notifications. Note that this keeps the push permission to "Ask", as it cannot be changed programmatically. So if the user wants to change the push permissions, it should be manually changed to "Allow" or "Denied" from browser settings or should clear the local storage content in order to display "Turn on notifications" in messaging menu again. Task-4446924 Before  After 
This fixes cases where accounting entry names could appear or disappear incorrectly after the dynamic placeholder feature was introduced. It ensures existing databases behave consistently even if their form views were not manually updated, reducing confusion for accounting users.
Original PR description
Description of the issue this commit addresses: Since the deployment of the new dynamic placeholder feature for move names, the code has been deployed on stable versions starting from 18.0 but the views are still only updated if the user manually does it meaning that moves the account move form view might have a unwanted behavior since the lack of change in the view while the code was updated will show the name when we don't want to and the other way around too in some cases. --- Desired behavior after this commit is merged: This commit modifies the get_view of the account.move model to make sure the invisible attribute of the name is correctly set. --- no task --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The first "Record created" message in the chatter now lines up correctly with its header and other note-style messages. This fixes a small visual inconsistency, making the activity history look cleaner and more polished.
Original PR description
Before this commit, the "Record created" message, shown as the very 1st message of chatter, had some horizontal start padding in text content. This was unaligned with header and looks off. This was…
Before this commit, the "Record created" message, shown as the very 1st message of chatter, had some horizontal start padding in text content. This was unaligned with header and looks off. This was happening because the message looks like a logged note, but it didn't have the `.o-note` modifier class to put the appropriate padding for the body of message with such a look. Due to the missing `.o-note` classname, this was assuming the style was the one with a bubble around, which needs extra padding, hence the problematic padding. This commit fixes the issue by adding `.o-note` in classname of such message notification that looks like a logged note, so that the padding matches the one with logged note. task-4291913 Before / After <img width="245" alt="Screenshot 2025-01-08 at 12 51 17" src="https://github.com/user-attachments/assets/8e388a88-705f-4c19-a6ec-d2168f1e6e56" /> <img width="243" alt="Screenshot 2025-01-08 at 12 50 48" src="https://github.com/user-attachments/assets/092b1508-d663-4336-900a-b55875437c05" />
Recruitment users can now see newly uploaded attachments in candidate and application records without manually refreshing the page. This makes reviewing applicant documents smoother and reduces confusion after uploads.
Original PR description
If we upload the attachments on the application or candidate, We need to refresh to see the preview of the attachments. In this PR, we've added the reload_on_attachment attribute to the chatter, which helps us preview the attachments. Task-4414529
This fix ensures that when a customer is selected in Point of Sale, they reliably appear at the top of the customer list across browsers. It removes an inconsistency where Firefox could show the selected customer elsewhere in the list, making cashier workflows more predictable.
Original PR description
Steps to reproduce: 1.Install ``point_of_sale`` in odoo 18.0 2.Open point of sale session and left side there is customer button select the customer. 3.selected partner will show at the top of all partner in chrome but in firefox browser selected partner is not showing at top For fixing it making sorting(compartor) more acurate. opw-4408218 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The HTML editor now handles cases where an external link cannot produce preview information, such as an invalid or placeholder URL. This prevents error messages in the logs and keeps email template editing smoother for users.
Original PR description
Currently, a traceback occurs when the user tries to preview an external link. Steps to produce: 1) Create an email template and add any text in content. 2) Convert text to a URL with a random URL…
Currently, a traceback occurs when the user tries to preview an external link.
Steps to produce:
1) Create an email template and add any text in content.
2) Convert text to a URL with a random URL like 'test'
3) error will occur in log
Error:-
```
TypeError: 'bool' object is not subscriptable
File "odoo/http.py", line 2366, in __call__
response = request._serve_db()
File "odoo/http.py", line 1894, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1957, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 137, in retrying
result = func()
File "odoo/http.py", line 1924, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2171, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 329, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 727, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/html_editor/controllers/main.py", line 564, in link_preview_metadata
if link_preview_data['og_description']:
```
This error occurs in the following lines when the link_preview_data value is False, leading to the traceback:
https://github.com/odoo/odoo/blob/36e4b6f93bf2123557947e910e1be651c5357319/addons/html_editor/controllers/main.py#L563-L564
The get_link_preview_from_url method may return False from multiple places.
https://github.com/odoo/odoo/blob/36e4b6f93bf2123557947e910e1be651c5357319/addons/mail/tools/link_preview.py#L30-L35
Therefore, an additional check is needed to verify the value of `link_preview_data` before accessing its value.
Adding this extra check will make the code more robust and prevent the
unnecessary tracebacks from occurring.
sentry-6199384889The icon picker search now finds matching icons even when users type names in uppercase. This removes a small source of friction when selecting icons and makes search behavior more consistent.
Original PR description
Description of the issue this PR addresses: Current behavior before PR: Searching for icon names in uppercase was not working. Desired behavior after PR is merged: Icon search now works correctly when names are entered in uppercase. task-4452824 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix keeps the Filipino language setting consistent between the browser and Odoo servers. It prevents crashes caused when browsers automatically rename the Tagalog locale to Filipino using a different code that the server does not expect.
Original PR description
Filipino is a standardized version of Tagalog that was created to be the national language of the Philippines. In Odoo, we use the "tl" locale to refer to Filipino, but this locale is considered "legacy" by standards bodies such as the Unicode Consortium. This is the reason why some APIs, such as the Intl API in the browser, treat "tl" as "fil" and even implicitly replace the former with the latter. This is a problem in Odoo, since the locale we use on the server side is still tl_PH, which leads to crashes when a converted Filipino locale (fil_PH) is sent to the server. While waiting for a better solution, this commit forces the tl locale on the client side. opw-4426799
Fixed an issue where the comments popover could fail to appear when it should open at the very top of the page. This helps users reliably view and interact with comments in Knowledge without losing access due to screen position.
Original PR description
Purpose: -------- The comments popover is not displayed when the computed popover top value is "0". This issue arises from incorrectly using this value as a boolean condition, whereas "0" is an acceptable top value (= top of the body). To fix this issue, we now check if the popover's top is undefined instead of using it as a boolean. Task-4461321
Saving a supplier bill with CIS taxes no longer causes an error when no partner has been selected. This prevents an interruption during bill entry and lets users continue working normally while completing bill details.
Original PR description
Steps to reproduce: 1. Install l10n_uk_reports_cis 2. Open a new bill 3. Set the 20% G tax on a new line. 4. Save without assigning a partner. 5. A traceback is raised. --- Description of the issue this commit addresses: In the l10n_uk_reports_cis module, a tax validation system is implemented that reaches into move.partner_id to check the chosen taxes validity. This causes an issue when the move doesn't have a partner yet, raising a traceback. --- Desired behavior after this commit is merged: No traceback is raised. --- Note on the fix: An additionnal check verifying the move has a partner is done before reaching into its values. The error happens inside the lambda line 20 and is **not** modified in the PR, the next line is modified to remove the `move.partner_id and ` that became redundant with the ` or not move.partner_id` condition added to the initial `if`. --- opw-4365356
Salary configurator benefit options now stay in the order set by the business instead of being automatically alphabetized. This helps users compare choices, such as cars sorted by cost, in the intended sequence.
Original PR description
Since the Select owl componenent is used to display the benefits values, the 'options' of the select are displayed alphabetically. It is caused by the default value to 'true' for the autoSort attribute of the component. As we give the data in a specific order to the select in salary cofigurator we don't want the JS to re-order it. e.g.: the cars are sorted by cost and we don't wan't it in the alphabetical order.
Fixed an issue that could stop Monster recruitment data from being prepared when checking flexible working hours. This helps ensure job posting integrations continue without interruption.
Original PR description
An error occurs while preparing monster data because in code mistakenly uses the attribute name 'is_flexible_hours' instead of the correct attribute name 'flexible_hours' to check the flexible hours of the resource calendar. `AttributeError: 'resource.calendar' object has no attribute 'is_flexible_hours'` To resolve this issue, Give a valid attribute name 'flexible_hours' instead of 'is_flexible_hours'. Sentry-6150854320
The Documents app now hides action menu options that cannot be used on locked documents. This prevents users from selecting actions that would fail or have no effect, reducing confusion and unnecessary errors.
Original PR description
This commit fix the visibility of the buttons in the action dropdown menu where actions were still visible for a locked document altough they threw an error or didn't do anything. Task-4255243
Odoo Studio now shows fields that are intentionally hidden in the list of existing fields, so users can drag them back into a view when needed. This fixes a limitation where hidden fields used for background data or view logic were unavailable for reuse, making view customization more practical.
Original PR description
Before this commit, fields that were always invisible (with an `invisible` attribute equals to True|1) were not listed in the Sidebar's "Existing Fields", and were not available for drag/drop. This was rather impractical as such field may be in the arch just to have their data loaded, not really displayed. Moreover, since odoo/odoo@6f06420e4a9443c52dc0cb427f8f55eb4aecabce, fields may be added in the view automatically based on whether their value will be used in some condition or context elsewhere in the view. After this commit, always invisible fields are always proposed for addition in the view. opw-4450351
1 change
Resolved issues and error corrections
This update resolves a problem where the system was incorrectly validating RUT numbers during invoice sending in the Uruguay localization module (l10n_uy_edi). This change prevents unnecessary validation, streamlining the invoice process and improving efficiency. It ensures invoices are processed correctly without this redundant check.