Thursday, January 9, 2025
2 changes · 17.0
Resolved issues and error corrections
This fixes a calendar issue that could prevent reminders or recurrence-related processing from working on databases upgraded from older versions. The update removes confusion in an internal database lookup so calendar events can be handled reliably.
Original PR description
__Current behavior before commit:__ In [`a27afdb`][1], the field `end_type` from the model `calendar.event` became computed and therefore not stored anymore. Databases that upgraded from an anterior version still have the column `end_type` in their table `calendar_event`. In [`f6df418`][2], a reference to `end_type` from the table `calendar_recurrence` has been added in the SQL query. If the field `end_type` is still in the table `calendar_event` it is ambiguous which one this query should use. Ultimately leading to this error: ``` psycopg2.errors.AmbiguousColumn: column reference "end_type" is ambiguous LINE 22: ... WHEN cal.recurrency AND end_type =... ``` __Description of the fix:__ Remove the ambiguity by explicitly specifying `rrule`, the alias of the `calendar_recurrence` table. opw-4406814 [1]: https://github.com/odoo/odoo/commit/a27afdb [2]: https://github.com/odoo/odoo/commit/f6df418
This fix prevents existing PDF form settings from being accidentally removed when filled forms are made read-only. It helps keep PDF behavior consistent while still protecting completed fields from changes.
Original PR description
Partly backporting 3731550474dc90819fa1667385f35f4a22ee4f11 Currently, to ensure the filled forms are set as readonly, we erase all the existing flags. Instead, we now only force the readonly flag.