Odoo Changelog — 2025-01-10

Friday, January 10, 2025

29 changes · saas-17.4

Bug Fixes(4)

Resolved issues and error corrections

[FIX] account: skip readonly check on synchronize from moves

PR #193289

Coresaas-17.4account

Accounting users can now update the partner on a bank statement's liquidity line from the accounting items list without being incorrectly blocked by a readonly-field error. This restores an expected editing flow for posted statement-related entries while keeping the underlying protection in place elsewhere.

Original PR description

This commit adds a missing skip_readonly_check context from the changes
to add readonly check in https://github.com/odoo/odoo/commit/b5d94f5563641adfd93bf431c139bc2b78d67beb

Steps to reproduce:
- create a statement line
- edit the partner of the liquidity line using the accounting items list
  view
- -> UserError: You cannot modify the following readonly fields on a posted move

opw-4453940

#accounting#bank statements#posted entries

[FIX] pos_mercado_pago: fix callback

PR #193029

Coresaas-17.4pos_mercado_pago

This fix prevents Mercado Pago payment callbacks from being processed when the related pending payment line no longer exists. It helps avoid payment flow errors in point of sale sessions and makes checkout handling more reliable.

Original PR description

Add a check on MP callback when paying. Verify if the pending payment line exist before processing the callback.

Same as:
- https://github.com/odoo/odoo/pull/186580
- https://github.com/odoo/odoo/pull/190735

opw-4349957

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point-of-sale#payments#mercado-pago

[REV] website_sale: pricelist previously removed override

PR #193176

Coresaas-17.4website_sale

This change removes a pricing override that had been accidentally reintroduced during a previous update. It helps keep website shop pricing calculations aligned with the intended behavior and avoids potential inconsistencies before discounts are applied.

Original PR description

Partial Revert of 2f7bc1e606809b9a65d357c08fea26b364d81941 The fix applied in 17.0 when forward porting it reintroduced a function that was previously removed.

[Mentioned diff](https://github.com/odoo/odoo/commit/b25e8e2cfefcf2af9af7a7cbe04110ac35f81f3d#diff-60accb44cf04ef4bd2a178a0dfefeb9facdf3724caf4ba080ffa63d8b08c807eR35:~:text=%2B-,def%20_get_pricelist_price_before_discount(self)%3A,-36)


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#pricing#ecommerce#pricelist

[FIX] project: show subtasks in project if converted into tasks

PR #191530

Coresaas-17.4project

Fixed an issue where a subtask converted into a regular task could remain hidden from the project dashboard. This ensures teams can reliably see and track work items after changing their task structure.

Original PR description

Steps to reproduce:
1. Create a task, and a subtask
3. Open the subtask
4. From the gear icon, click "Convert to Task/Sub-Task"
5. Remove the parent task and click "Convert Task"
6. Go to the project dashboard > the subtask is not shown.

Why?
The above reproducing steps lead to the subtask having the `display_in_project` stored as `False`, hence it's not visible on the dashboard page. This is because `_compute_project_id` interrupted the computation flow of `display_in_project` by a call to `remove_to_compute` [1].

Fix:
In the `write` method, explicitly set `display_in_project` to `True` if the parent_id has been removed.

[1]: https://github.com/odoo/odoo/blob/9dec8329523d4966243c6491e7e556e643af6cdf/addons/project/models/project_task.py#L337

opw-4384222

#tasks#subtasks#dashboard#visibility

Other(25)

Miscellaneous changes

[FW][FIX] crm: display the missing line in crm helper

PR #193204

Coresaas-17.4crm

**Specifications:** When the domain is specified, helper in crm helper should display an extra line, which explains that any email sent to alias@domain will create a lead. **Technical reason:** A code was added in `crm.lead` which checks for the company, but in data file company was already specified as `False`. Hence, the missing line. **After this PR:** If the custom email domain is set, crm helper will display an extra line. Task-4377574 Forward-Port-Of: odoo/odoo#190936

Original PR description

**Specifications:**
When the domain is specified, helper in crm helper should display an extra line, which explains that any email sent to alias@domain will create a lead.

**Technical reason:**
A code was added in `crm.lead` which checks for the company, but in data file company was already specified as `False`. Hence, the missing line.

**After this PR:**
If the custom email domain is set, crm helper will display an extra line.

Task-4377574

Forward-Port-Of: odoo/odoo#190936

This commit adds a missing skip_readonly_check context from the changes to add readonly check in https://github.com/odoo/odoo/commit/b5d94f5563641adfd93bf431c139bc2b78d67beb Steps to reproduce: - create a statement line - edit the partner of the liquidity line using the accounting items list view - -> UserError: You cannot modify the following readonly fields on a posted move opw-4453940

Add a check on MP callback when paying. Verify if the pending payment line exist before processing the callback. Same as: - https://github.com/odoo/odoo/pull/186580 - https://github.com/odoo/odoo/pull/190735 opw-4349957 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Partial Revert of 2f7bc1e606809b9a65d357c08fea26b364d81941 The fix applied in 17.0 when forward porting it reintroduced a function that was previously removed. [Mentioned diff](https://github.com/odoo/odoo/commit/b25e8e2cfefcf2af9af7a7cbe04110ac35f81f3d#diff-60accb44cf04ef4bd2a178a0dfefeb9facdf3724caf4ba080ffa63d8b08c807eR35:~:text=%2B-,def%20_get_pricelist_price_before_discount(self)%3A,-36) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce: 1. Create a task, and a subtask 3. Open the subtask 4. From the gear icon, click "Convert to Task/Sub-Task" 5. Remove the parent task and click "Convert Task" 6. Go to the project dashboard > the subtask is not shown. Why? The above reproducing steps lead to the subtask having the `display_in_project` stored as `False`, hence it's not visible on the dashboard page. This is because `_compute_project_id` interrupted the computation flow of `display_in_project` by a call to `remove_to_compute` [1]. Fix: In the `write` method, explicitly set `display_in_project` to `True` if the parent_id has been removed. [1]: https://github.com/odoo/odoo/blob/9dec8329523d4966243c6491e7e556e643af6cdf/addons/project/models/project_task.py#L337 opw-4384222

When exporting a SA E-invoice file, the system needs to collect invoice line without downpayment lines. However, when collecting tax values, because of an error correction mechanism, the tax amount will still include the amount of the downpayment tax line Steps to reproduce (with SA localization installed and SA company): - Create a SO of 1000$ with 15% tax - Make a downpayment of 100$ with 15% tax and confirm - Make the final invoice with downpayment deducted - Confirm and send e-invoice for validation Issue: The invoice is validated, but a warning is logged ``` Invoice was Accepted by ZATCA (with Warnings) The invoice was accepted by ZATCA, but returned warnings. Please, check the response below: BR-CO-17: VAT category tax amount (BT-117) = VAT category taxable amount (BT-116) x (VAT category rate (BT-119) / 100), rounded to two decimals. BR-S-09: The VAT category tax amount (BT-117) in a VAT breakdown (BG-23) where VAT category code (BT-118) is Standard rated shall equal the VAT category taxable amount (BT-116) multiplied by the VAT category rate (BT-119). ``` As the warning states the is an issue with the tax computation. When collecting amounts from the final invoice, we should filter out downpayment amounts, but due to the error correction mechanism introduced to account for manual modification of the journal items, the filter is ignored, so we will have the filtered base amount (1000) and the unfiltered tax amount (135 instead of 150) A possible solution is to avoid the error correction when we know we need to filter invoice lines opw-4380798 Forward-Port-Of: odoo/odoo#192596 Forward-Port-Of: odoo/odoo#191867

Even if 5.1 is not technically supported, debuntu might switch to it any moment and we don't know if / when upstream will fix it, so it's not worth the time bomb. While technically it was always typed such, since py-pdf/pypdf#2820 it looks like `_info` is a lot more likely to be `None` as e.g. `clone_reader_document_root` now starts with unsetting `_info_obj` and never re-sets it. Except `add_metadata` was not updated to handle this case, likely because mypy interprets `assert isinstance(self._info, DictionaryObject)` as a type narrowing and trusts the developer, thus does not report the type mismatch... and the assertion ends up blowing in the user's face at runtime with a simple >>> r = pypdf.PdfReader(some_pdf_document) >>> w = pypdf.PdfWriter() >>> w.clone_reader_document_root(r) >>> w.add_metadata({"/foo": "bar"}) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "lib/python3.12/site-packages/pypdf/_writer.py", line 1622, in add_metadata assert isinstance(self._info, DictionaryObject) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError This is rather inconsiderate, so monkeypatch `add_metadata` to handle the case where `_info` exists and is `None`. Most of the credit goes to juwu for uncovering the issue. opw-4372052 opw-4426881 Fixes #185673 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#193086

To reproduce the issue: 1) Create a vendor bill for 100€, with a tax of 15% 2) In the grouped generic tax reports, the base will be 100 and the tax 15 3) Create an expense of 200€, with the same tax, paid by the company. Fully validate it and post the entry. ====> The grouped generic tax reports now should display 300 of base, and 45 of tax. It does only show 200 of base, though. This happens because when post-processing the results of the query ran by the report, we do this https://github.com/odoo/enterprise/blame/16.0/account_reports/models/account_generic_tax_report.py#L406 , so we essentially don't add the base amounts of the tax lines whose identification key has already been treated. This is important for taxes with multiple tax repartition lines. In our case, a line is generated by the query for both the invoice and the expense entry. This is because the query groups on display_type: the expense line has display_type = 'product', while the invoice has 'tax'. This grouping was introduced here https://github.com/odoo/enterprise/commit/67f841ee36cb5a8ef95ae3dd3859239a4d10b99d to avoid counting the base amounts of the cash rounding lines as additional base amounts. We fix this by slightly tweaking the query, in order for rounding lines to be considered as having a base amount of 0. opw-3890736 Forward-Port-Of: odoo/enterprise#76801 Forward-Port-Of: odoo/enterprise#76536

Steps to reproduce the bug: - Create a storable product “P1”: - Tracked with SN - Create a BoM: - no need to component - Add an operation “OP1” with steps - Control by product - Create a manufacturing order for one unit of P1 - Confirm the MO - Go to the shop floor and process “OP1” - Validate the MO - Go to the SN of P1 Problem: The quality checks are filtered using “search_default_lot_id = active_id”, which means only quality checks linked to the “search_default_lot_id” are displayed. However, in this usecase, the "lot_id” is not set. Instead, the "finished_lot_id" is used, causing the quality checks to be hidden unless the filter is removed. Solution: the domain is properly prepared so no longer needs this filter: https://github.com/odoo-dev/enterprise/blob/33de674651017a79e4d010b054dfb2ccaf8b744c/quality_control/models/stock_lot.py#L23-L27 https://github.com/odoo-dev/enterprise/blob/33de674651017a79e4d010b054dfb2ccaf8b744c/quality_control/models/stock_lot.py#L20-L21 https://github.com/odoo-dev/enterprise/blob/33de674651017a79e4d010b054dfb2ccaf8b744c/quality_mrp_workorder/models/stock_lot.py#L10-L13 opw-4361358 Forward-Port-Of: odoo/enterprise#76376

Bug Fixes(4)

[FIX] account: skip readonly check on synchronize from moves

[FIX] pos_mercado_pago: fix callback

[REV] website_sale: pricelist previously removed override

[FIX] project: show subtasks in project if converted into tasks

Other(25)

[FW][FIX] crm: display the missing line in crm helper

Bug Fixes(4)

[FIX] account: skip readonly check on synchronize from moves

[FIX] pos_mercado_pago: fix callback

[REV] website_sale: pricelist previously removed override

[FIX] project: show subtasks in project if converted into tasks

Other(25)

[FW][FIX] crm: display the missing line in crm helper

[FW][FIX] base: append suffix to duplicated server action name

[FW][FIX] web_editor: line breaks at edges of block anchor nested within li

[FW][FIX] l10n_be_pos_sale: activate default invoice only with intracom taxes

[FW][IMP] web: update owl to 2.5.3

[FW][FIX] l10n_gcc_invoice: display payment terms on invoice

[FW][FIX] l10n_be_pos_sale: force invoice for intracom

[FW][FIX] purchase_requisition: remove existing currency rate in tests

[FW][FIX] calendar: remove end_type ambiguity in sql query

[FW][FIX] account,l10n_sa_edi: tax values filter overwrite

[FW][FIX] stock_account: branch accounts configuration ignored

[FW][FIX] hr_holidays, mail: im_status fa - plane not consistent

[FW][FIX] account: matching rules appliance on branches

[FW][FIX] mrp: prevent re-count global lead days if not 1-step manufacture

[FW][FIX] l10n_in_pos: tb on receipt with customer after payment done

[FW][FIX] core: inconsistent pypdf metadata in 5.1

[FW][FIX] hr_holidays: prevent error when creating time-off type

[FW][FIX] l10n_my_*: Enable invoicing foreign customers.

[FW][FIX] account_reports: Tax > Account and Account > Tax Tax Reports: properly group results from the tax details query

[FW][FIX] documents: keep inspector tags on one line

[FW][FIX] l10n_pe_edi: withholding amount sign is PEN in PDF

[FW][FIX] web_enterprise: expire cids when logging out

[FW][FIX] delivery_fedex_rest: fix breaking tests when USD is not default

[FW][FIX] quality_control: remove lot_id filter in quality check view

[FW][FIX] account_asset: prevent division by zero when recomputing board …