Thursday, January 16, 2025
19 changes
2 changes
Resolved issues and error corrections
This update fixes a failing automated test related to keyboard shortcuts in web navigation. It helps keep the web interface test suite reliable, reducing the risk of regressions reaching users.
Original PR description
Fixes test broken by: be23ed0 https://runbot.odoo.com/odoo/runbot.build.error/109595 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Child contacts with portal access can now see the tasks menu when access rules allow them to view related customer tasks. This prevents eligible users from missing project information due to an overly restrictive task count check.
Original PR description
## Issue: - Child contacts of followers were unable to access the tasks menu in the portal home, despite having access according to the access rules. ## Steps to reproduce: 1. Create a parent contact with a child contact. 2. Grant the child contact portal access. 3. Create a task with the parent contact as the customer. 4. Add the parent contact as a follower or send a message in the task chatter. 5. Log in as the child contact in the portal. 6. Notice the tasks menu is unavailable. ## Solution: - The issue originated in `_prepare_home_portal_values`, where the task count was computed with a restrictive domain and sudo instead of relying on the access rules. - Removed the unnecessary domain filter to let the access rules handle it. opw-4306834 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
The automated tests for spreadsheet-related document features were adjusted to match a recent spreadsheet engine update. This helps keep quality checks reliable and reduces the risk of false test failures during future releases.
Original PR description
Adapt the tests to the new o-spreadsheet update. See https://github.com/odoo/odoo/pull/193691
15 changes
Resolved issues and error corrections
The POS session chatter now shows the expected opening amount based on the previous session's closing balance, rather than a manually edited value. This keeps cash opening records and displayed differences accurate for store staff and managers.
Original PR description
- Resolved issue where the "expected opening" amount in the POS session chatter incorrectly displayed the manually modified amount instead of the previous closing balance. - Adjusted the sequence of setting `cash_register_balance_start` to maintain consistent chatter messages with accurate deltas. task-id: 4471816 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
This update resolves a technical issue preventing the Web Studio module from functioning correctly. The fix ensures that necessary components are properly included, restoring the module's core capabilities. This ensures Web Studio continues to operate reliably for users.
Fixes an issue where the Discuss call sidebar could fail when a participant session was missing expected membership information. This improves reliability for users viewing call participant cards and avoids disruptive error screens.
Original PR description
Since [1], the session getter for the sidebar cards assumes that channelMember is always defined on rtcSessions, this could cause tracebacks. [1]: https://github.com/odoo/odoo/pull/190050
Recruitment application creation now checks a candidate's company before linking records, preventing errors when similar candidates exist in another company. It also allows applications to link to candidates without a company, helping teams process incoming applications more reliably.
Original PR description
Before this commit, the creation of an applicant though `message_new`, It would check for existing candidates but not for the company; however, if the company is different, an error would be raised upon applicant creation and prevent it. This commit adds the company to the candidate check to avoid raising the constraint, and adjusts the said constraint so that it allows linking to candidates with no company set.
Fixes an issue where repeatedly clicking the SEO notification button could open several optimization dialogs at once. The notification now closes properly after the button is clicked, keeping the website publishing flow clearer and less confusing.
Original PR description
Since [1], clicking the button while the SEO toaster was visible could repeatedly open the SEO optimization dialog, resulting in multiple instances of the dialog box being opened. This commit addresses this issue by: - Adding logic to ensure toasters close properly when a button is clicked. (i.e the SEO toaster when you publish a page with missing important SEO informations). [1]: https://github.com/odoo/odoo/commit/45ea6e4a4a5c8e314b110a45198fbe3d57bb996e task-4384773
This fixes an accounting setup issue by ensuring the system only tries to retrieve fields that belong to the company record. It helps prevent errors during configuration or template processing when unrelated fields could otherwise be requested.
Original PR description
We can only attempt to get fields from `res.company` model. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change corrects an automated test setup for restaurant self-order online payments so it works reliably in no-demo test environments. It helps keep release validation stable without changing customer-facing behavior.
Original PR description
The `test_01_online_payment_with_multi_table` fails in runbot when running in "no-demo" mode. This is because it's not using the correct setup for testing restaurant configs. We ensure, in this commit, that the test uses the correct setup for testing by inheriting from the pos_restaurant's TestFrontendCommon. The total amount in the tour is adjusted because the test product from the default setup has no tax. Runbot Error: [111171](https://runbot.odoo.com/odoo/runbot.build.error/111171)
Department employee totals now respect the companies currently active for the user. This prevents misleading counts in multi-company setups and adds test coverage to help keep the behavior reliable.
Original PR description
- edit the `_read_group` domain to include the current active companies Task: 4353391 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Employee profile images are now displayed correctly when using the Employees app on a mobile-sized screen. This fixes a visual issue that made employee records harder to recognize on phones or narrow displays.
Original PR description
Steps to Reproduce: • Install the Employee app. • Switch to mobile view. • Open the Employee app; employee images are not visible. Cause: CSS was not defined for screen sizes smaller than medium. Fix: Added CSS rules for screens smaller than medium to ensure employee images are displayed correctly in mobile view. task-4380126 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users can now drag selected text from one field and drop it into another field in form views. This fixes a small but frustrating editing issue and makes data entry smoother.
Original PR description
Before this commit: It is not able to drag and drop text between fields in the form view. After this commit: It is possible to drag and drop text between fields in the form view. Task-4286285
This fix makes the full message composer start with the expected empty paragraph when default content is present. It prevents formatting actions like bullet lists from accidentally applying to the whole message, making message editing more predictable for users.
Original PR description
**Problem**: When a `default_body` is added, it contains only a `div` in the editable area. This causes issues with some editor features, such as bullet lists, which do not behave as expected. **Solution**: Ensure the content includes a `<p><br/></p>` by default, selected for proper functionality, aligning with the default behavior of the editor. **Steps to reproduce**: 1. Go to Sales > Send Message > Full Composer. 2. Write content spanning 2+ lines. 3. On a new line, apply a bullet list. 4. Observe that the bullet list is applied to the entire content instead of just the current line. opw-4419775 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error during checkout when a customer buys only services and changes their delivery address. The checkout now handles cases where no delivery option is needed, allowing customers to continue smoothly.
Original PR description
Versions -------- - 18.0+ Steps ----- 1. Go to eCommerce; 2. add only services to cart; 3. go to checkout; 4. on payment page, go back to Delivery page; 5. add a second address if needed; 6. change selected address. Issue ----- > Uncaught Promise > Cannot read properties of null Cause ----- The query selector in `_canEnabledMainButton` assumes a radio input is always present on this step, but this is only the case when deliverable products were added to the cart. Solution -------- Skip the remainder of the method if the delivery radio wasn't found. opw-4365246 opw-4422905
Opening the invoice report in the report editor could fail for Kenyan OSCU setups because the report used invalid page structure. The report layout has been corrected so users can open and edit it reliably.
Original PR description
- Install `web_studio` and `l10n_ke_edi_oscu`
- Open the report editor from anywhere
- Search for report_invoice
- Open it
- Traceback
This is caused by the div inside the table, this is incorrect in HTML
See https://html.spec.whatwg.org/multipage/tables.html#the-table-element
replace with a tr/td
opw-4369019Fixed an issue where sharing one error dialog could also trigger sharing actions for other stacked error dialogs. This prevents duplicate link copies and notifications, making error sharing clearer and less confusing for users.
Original PR description
This commit fixes an issue with the sharing functionality of the error dialogs where if multiple of these were stacked onto each other, the share button would trigger the URL copy and notification for all errors instead of only the relevant one.
This update prevents subscription sales orders from comparing empty date fields. It helps avoid unnecessary errors when start or next invoice dates have not yet been set.
Original PR description
The fields start_date and next_invoice_date of sale.order can be null. We only want to compare to dates. So its better to check that the dates are not null before comparing them.
This change updates automated tests for the Documents Spreadsheet pivot side panel to match a recent spreadsheet interaction fix. It helps keep quality checks reliable so future updates do not accidentally reintroduce issues around focusing spreadsheet elements.
Original PR description
The hoot dom helpers rely on a single 'pointerdown' to focus its node which is precisely the behaviour that we act upon in https://github.com/odoo/o-spreadsheet/commit/85aaab61dd3fc4ea2a8c10f9e70b8e7fa650f170