Friday, January 17, 2025
20 changes
1 change
Resolved issues and error corrections
This fixes a website test so it consistently checks the intended website when validating language links. It helps prevent false test failures and supports more reliable website behavior across multi-site setups.
Original PR description
The Issue: Prior to this commit, invoking _get_frontend resulted in the get_current_website function returning a different website than the one specified in the MockRequest. The Fix: To resolve this, we ensure the function selects the correct website by explicitly passing it in the context. runbot-64729
19 changes
Resolved issues and error corrections
Leaving a Discuss call now also exits full-screen mode if it was active. This prevents users from being stuck in full-screen view after ending a call, making the call experience smoother and less confusing.
Original PR description
Before this commit, leaving call while the call view is full screen would keep the fullscreen mode. This commit fixes the issue by exiting the full screen when leaving the call. Task-4476568
This fixes an internal website test so its media dialog checks are actually executed. It helps ensure website media features are tested as intended, reducing the chance of unnoticed issues reaching users.
Original PR description
This PR adds the missing run methods in the media dialog tour steps **merged** in [commit](https://github.com/odoo/odoo/commit/bee295f). The run methods are necessary to execute the tour steps Without these methods, the tour steps were not executed properly, and the functionality was not tested as intended. task-4246644
On small screens, a button menu with only one item now displays cleanly without leaving an empty space beside it. This improves the visual polish and usability of forms on mobile devices.
Original PR description
On smaller screen, the statbuttons are grouped in a dropdown (the "lightning" icon) and displayed in two columns. But when only one button is present, it leaves a weird empty cell next to it. This commit fixes it by adding an exception in CSS when only one button is present to remove the useless column and center it. Note: this change doesn't affect the empty cell when an odd number of buttons are displayed. task-4491705
The document layout setup now correctly shows the A4 paper format when Belgian payroll is installed. This prevents confusion during document configuration and helps businesses select the right format for payroll-related reports.
Original PR description
In the document layout configurator, the paper format A4 would not be there if the module l10n_be_hr_payroll is installed. This is because in Belgium, some reports need A4 but in the configurator, we only get paperformat not linked to any report. The solution is to remove the domain for this field in the configurator. Since there will be more paper formats, I renamed the newly created formats in the Belgian payroll to differentiate them.
The website mega menu now handles links that were saved without a URL instead of crashing. This prevents visitors and editors from seeing an error when navigating to pages that are not part of the menu.
Original PR description
Steps to reproduce: - Open the "Menu Editor" dialog. - Add a "Mega Menu Item". - Save the "Menu Editor" dialog. - Enter "Edit Mode". - Open the "Mega Menu". - Select "Images Subtitles" as the "Mega Menu" template option. - Click on the largest image on the right side of the "Mega Menu". - Click the "Create Link" button in the image options. - Leave the input URL empty for this new link. - Save the page. - A link without an "href" attribute is now present in the "Mega Menu". - Edit the browser URL to redirect to a page that is not present in the menu; for example, add "/test" to the current URL. It does not matter whether the page exists or not. - Bug: A traceback occurs. The bug occurred because the function "_updateActiveMenuLinks" (introduced by this commit [1]) called "new URL" on an empty string, as it attempted to process a link without an href attribute. [1]: https://github.com/odoo/odoo/commit/5be12800a59e912997fff39cec57ab70914f2485 opw-4480958
This fixes an issue in Discuss calls on mobile where moving participant cards could make them disappear off screen. Participant cards can now only be dragged when they are in the intended movable state, improving call usability on phones and tablets.
Original PR description
Before this commit, when dragging participant cards on mobile they will get dragged off screen. 1. Open discuss on mobile 2. Get into a call 3. Move the participant cards -> they will disappear This happens because the `drag` function gets called without checking if the participant card is in the inset state (the state in which it can be moved around). This commit fixes the issue by checking that the component is in that state before being able to drag it. task-4491597
Users can now use Escape or Enter when confirming whether to close a live chat. This makes the close confirmation behave as expected and helps operators handle chats more smoothly without relying only on mouse clicks.
Original PR description
Before this commit, the Escape and Enter hotkeys did not work to cancel and confirm the `CloseConfirmation` in livechat. This happened because: - The `keydown' event is not captured without the focused element. - `useAutofocus` doesn't detect the element properly because the active element in the ui service is set by the main tree DOM root, not the shadow root. This PR makes sure that the close confirmation element is focusable on mounting and also puts the focus on the chat window composer on cancel so it's more effective in case the user needs to type or use Esc to reopen close confirmation.
The public sharing page for live spreadsheets no longer shows a download button that led visitors to a 404 error. This avoids a confusing broken action for external viewers when spreadsheets are shared by link.
Original PR description
Steps to reproduce: - install Documents - create a new spreadsheet - hit the Share button - change the sharing settings to "Anyone with the link: Viewer / Musty have the link to access" - open the…
Steps to reproduce: - install Documents - create a new spreadsheet - hit the Share button - change the sharing settings to "Anyone with the link: Viewer / Musty have the link to access" - open the sharing link in an incognito window - hit the download button => 404 not found A public user cannot convert a spreadsheet to an excel file and downlaod it because a route needs to be called to create the excel file. This route is currently not allowed for public users. For frozen spreadsheet, we generate the excel file before-hand (when the internal user shares the spreadsheet). For a regular "live" share though, we cannot pre-generate the excel file since the spreadsheet continues to live and evolve. The `spreadsheet` module needs to be updated for this bug fix to take effect. (otherwise the download button won't do anything, which is not worse than facing a 404 response) See also Enterprise PR. Task: 4440241 opw: 4417519 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The upload button shortcut in Accounting has been changed from Alt+B to Alt+Shift+I. This prevents it from interfering with Odoo's standard back navigation shortcut, making keyboard use smoother and more predictable.
Original PR description
Before this PR: - The Upload Button was assigned the shortcut Alt+B. - This caused a conflict with Odoo's default shortcut for navigating backward. After this PR: - The shortcut for the Upload Button is now updated to Alt+Shift+I. - This resolves the conflict and ensures smooth navigation and functionality. Task ID:-4417310
Invoices sent for a contact linked to a company now use the company's configured EDI format instead of the individual contact's format. This ensures customers receive electronic invoices in the expected company-level format and avoids incorrect document generation.
Original PR description
The invoice edi format should be take from the parent of the partner instead of the partner himself. Steps: - Create an individual partner X and set an edi format - Create a company partner Y and set a different edi format - Make X child of Y - Create an invoice for X, confirm and click on 'Send and print' button -> The edi file is in the format set on X instead of the format set on Y opw-4480527
The portal user welcome email template has been renamed to avoid sharing the same name as another user invitation template. This makes the email template list clearer for administrators and reduces the chance of selecting the wrong template.
Original PR description
Currently, there are two mail templates named "Settings: New User Invite" in the records. To avoid duplication, we will rename the template used to welcome portal users who register as internal users to "Settings: New Portal Sign Up". Follow up of #188391 Task-4481862 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes several issues in Odoo’s frontend testing framework and related test helpers, making automated tests more reliable and less prone to false failures or timeouts. It improves how test timing, progress display, mock server defaults, and protected error reporting work, helping teams catch real issues faster during development.
Original PR description
This commit handles various fixes for the Hoot testing framework & other frontend unit test helpers. Enterprise: https://github.com/odoo/enterprise/pull/77245 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes invoice name generation for companies whose fiscal year ends on February 29. It prevents incorrect sequence selection in non-leap years, helping invoices keep consistent and compliant numbering.
Original PR description
When computing an invoice name placeholder dynamically the sequence used depends on the fiscal year end date but it does not account for february 29 on non-leap years, which is a [valid](https://github.com/odoo/odoo/blob/893b253644159a70d1916e3eaf25d1c8af4e92c3/addons/account/models/company.py#L294-L298) date. Here an adjustment for the day is added to safely compare a date with the fiscalyear end. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The document layout setup now correctly shows the A4 paper format when Belgian payroll is installed. This prevents confusion when configuring payroll-related documents and makes similarly named Belgian payroll formats easier to tell apart.
Original PR description
In the document layout configurator, the paper format A4 would not be there if the module l10n_be_hr_payroll is installed. This is because in Belgium, some reports need A4 but in the configurator, we only get paperformat not linked to any report. The solution is to remove the domain for this field in the configurator. Since there will be more paper formats, I renamed the newly created formats in the Belgian payroll to differentiate them.
The Shopee sales app was added to the translation setup after being missed in an earlier merge. This helps ensure its text can be translated properly for users in different languages, with no expected change to day-to-day workflows.
Original PR description
File was forgotten during the merge of 6845ca19567577f70910ed269f91232453c93b20
This fixes an issue in Documents where using Shift + Down Arrow after selecting a record did not extend the selection to the next record. Users can now select multiple documents with the keyboard as expected, improving day-to-day list navigation.
Original PR description
Reproduce: 1. Go to documents list view 2. Select any not-the-last record 3. Hold Shift and hit down arrow 4. The record below is not selected as it should Task-4432914
Payslip PDF reports now display the employee's actual pay schedule, such as bi-weekly, instead of always showing monthly for monthly wage contracts. This helps payroll documents better match contract settings and reduces confusion for employees and payroll teams.
Original PR description
Steps: - Install the hr_payroll module - Open the payslip form view - click on print --- Description of the issue/feature this PR addresses: When the schedule pay on a contract is set to anything other than `Monthly` (e.g., bi-weekly), the PDF report incorrectly displays `Monthly`. This happens because the report only considers the wage type (monthly or hourly) and does not take the schedule pay into account. --- Fix: This PR addresses the issue by including the schedule pay type in the PDF report when the wage type is set to `Monthly`. task-4332531
Public viewers of live shared spreadsheets no longer see a download button that leads to a 404 error. This avoids confusion for external recipients while keeping frozen spreadsheet downloads available when they can be prepared in advance.
Original PR description
Steps to reproduce: - install Documents - create a new spreadsheet - hit the Share button - change the sharing settings to "Anyone with the link: Viewer / Musty have the link to access" - open the sharing link in an incognito window - hit the download button => 404 not found A public user cannot convert a spreadsheet to an excel file and downlaod it because a route needs to be called to create the excel file. This route is currently not allowed for public users. For frozen spreadsheet, we generate the excel file before-hand (when the internal user shares the spreadsheet). For a regular "live" share though, we cannot pre-generate the excel file since the spreadsheet continues to live and evolve. The `spreadsheet` module needs to be updated for this bug fix to take effect. (otherwise the download button won't do anything, which is not worse than facing a 404 response) See also community PR. Task: 4440241 opw: 4417519
This update improves the internal automated test setup used for Odoo's frontend features. It helps test data behave more like real system records, reducing false failures and making future updates safer across affected apps.
Original PR description
This commit handles various fixes for the Hoot testing framework & other frontend unit test helpers. Community: https://github.com/odoo/odoo/pull/193937