Saturday, January 18, 2025
1 change · 17.0
Resolved issues and error corrections
Time Off requests no longer create unnecessary follow-up activities when no Time Off Officer is assigned. This avoids confusing reminders and keeps the approval workflow aligned with the actual configuration.
Original PR description
Steps: - Install the hr_holiday module - Configure Time Off Type with validation set to `Approved by Time Off Officer` or `Both` - Create a Time Off request without setting a Time Off Officer. --- Description of the issue/feature this PR addresses: When the validation type is set to `hr` or `both` and no Time Off Officer is configured, an activity is incorrectly generated upon creating a Time Off request. --- Fix: This PR requires adding responsible_ids in the test cases. The changes made in this task remove activities when responsible_ids is not set, causing the test cases to fail. Adding responsible_ids will ensure the tests pass successfully. task-4351688