Monday, January 20, 2025
16 changes · master
Miscellaneous changes
In the document layout configurator, the paper format A4 would not be there if the module l10n_be_hr_payroll is installed. This is because in Belgium, some reports need A4 but in the configurator, we only get paperformat not linked to any report. The solution is to remove the domain for this field in the configurator. Since there will be more paper formats, I renamed the newly created formats in the Belgian payroll to differentiate them. Forward-Port-Of: odoo/enterprise#71649
Original PR description
In the document layout configurator, the paper format A4 would not be there if the module l10n_be_hr_payroll is installed. This is because in Belgium, some reports need A4 but in the configurator, we only get paperformat not linked to any report. The solution is to remove the domain for this field in the configurator. Since there will be more paper formats, I renamed the newly created formats in the Belgian payroll to differentiate them. Forward-Port-Of: odoo/enterprise#71649
Steps: - Install the hr_payroll module - Open the payslip form view - click on print --- Description of the issue/feature this PR addresses: When the schedule pay on a contract is set to anything other than `Monthly` (e.g., bi-weekly), the PDF report incorrectly displays `Monthly`. This happens because the report only considers the wage type (monthly or hourly) and does not take the schedule pay into account. --- Fix: This PR addresses the issue by including the schedule pay type
Original PR description
Steps: - Install the hr_payroll module - Open the payslip form view - click on print --- Description of the issue/feature this PR addresses: When the schedule pay on a contract is set to anything other than `Monthly` (e.g., bi-weekly), the PDF report incorrectly displays `Monthly`. This happens because the report only considers the wage type (monthly or hourly) and does not take the schedule pay into account. --- Fix: This PR addresses the issue by including the schedule pay type in the PDF report when the wage type is set to `Monthly`. task-4332531 Forward-Port-Of: odoo/enterprise#75342
Steps to reproduce: - install Documents - create a new spreadsheet - hit the Share button - change the sharing settings to "Anyone with the link: Viewer / Musty have the link to access" - open the sharing link in an incognito window - hit the download button => 404 not found A public user cannot convert a spreadsheet to an excel file and downlaod it because a route needs to be called to create the excel file. This route is currently not allowed for public users. For frozen sprea
Original PR description
Steps to reproduce: - install Documents - create a new spreadsheet - hit the Share button - change the sharing settings to "Anyone with the link: Viewer / Musty have the link to access" - open the sharing link in an incognito window - hit the download button => 404 not found A public user cannot convert a spreadsheet to an excel file and downlaod it because a route needs to be called to create the excel file. This route is currently not allowed for public users. For frozen spreadsheet, we generate the excel file before-hand (when the internal user shares the spreadsheet). For a regular "live" share though, we cannot pre-generate the excel file since the spreadsheet continues to live and evolve. The `spreadsheet` module needs to be updated for this bug fix to take effect. (otherwise the download button won't do anything, which is not worse than facing a 404 response) See also community PR. Task: 4440241 opw: 4417519 Forward-Port-Of: odoo/enterprise#76460
… technical In Odoo 18 > Benchmark dashboard does not show the correct balance per account type when the language is not English. The problem is we have a =_t(value) function that translate the technical name (C30:C47) opw-4484934 Task: 4484934 Forward-Port-Of: odoo/enterprise#77163
Original PR description
… technical In Odoo 18 > Benchmark dashboard does not show the correct balance per account type when the language is not English. The problem is we have a =_t(value) function that translate the technical name (C30:C47) opw-4484934 Task: 4484934 Forward-Port-Of: odoo/enterprise#77163
When validating the payment CFDI in multicurrency scenario (invoice in USD, payment in MXN), we should provide the official convertion rate in the equivalenciaDR xml attribute. However, this is not always possible due to rounding: PACs with lower error tolerance (Quadrum) will not validate the payment Steps to reproduce: - With an MX company setup - Set the following rates for USD - Date 1: 0.049905678268 - Date 2: 0.049073733284 - Create an invoice in date1 of 6368.40 USD (5490.00 w
Original PR description
When validating the payment CFDI in multicurrency scenario (invoice in USD, payment in MXN), we should provide the official convertion rate in the equivalenciaDR xml attribute. However, this is not…
When validating the payment CFDI in multicurrency scenario (invoice in USD, payment in MXN), we should provide the official convertion rate in the equivalenciaDR xml attribute. However, this is not always possible due to rounding: PACs with lower error tolerance (Quadrum) will not validate the payment Steps to reproduce: - With an MX company setup - Set the following rates for USD - Date 1: 0.049905678268 - Date 2: 0.049073733284 - Create an invoice in date1 of 6368.40 USD (5490.00 with 16% tax) - Register a full payment in date 2 in company currency (129772.07 MXN) Issue: Payment CFDI will not validate when using Quadrum PAC with error ``` Code : CRP20268 Message : El campo BaseP que corresponde a Traslado, no es igual a la suma de los importes de las bases registrados en los documentos relacionados donde el impuesto del documento relacionado sea igual al campo ImpuestoP de este elemento y la TasaOCuotaDR del documento relacionado sea igual al campo TasaOCuotaP de este elemento. ``` This occurs because when computing cfdi values we take the invoice (rounded) amounts and recompute the amount in mxn using the official currency rate. While doing so, due to rounding, we accumulate imprecision, the final computation might be off by a cent or two and PACs with a lower error tolerance (Quadrum) will not be able to validate the cfdi. A solution is to internally use the computed rate, while we provide the official currency rate in the xml opw-4357985 Forward-Port-Of: odoo/enterprise#76987 Forward-Port-Of: odoo/enterprise#76333
Fix preparation wrong variable name. `table_name` -> `table.table_number` Forward-Port-Of: odoo/enterprise#77276
Original PR description
Fix preparation wrong variable name. `table_name` -> `table.table_number` Forward-Port-Of: odoo/enterprise#77276
Enterprise counter-part. https://github.com/odoo/odoo/pull/187799 Forward-Port-Of: odoo/enterprise#77037 Forward-Port-Of: odoo/enterprise#74167
Original PR description
Enterprise counter-part. https://github.com/odoo/odoo/pull/187799 Forward-Port-Of: odoo/enterprise#77037 Forward-Port-Of: odoo/enterprise#74167
- Install `web_studio` and `l10n_ke_edi_oscu` - Open the report editor from anywhere - Search for report_invoice - Open it - Traceback This is caused by the div inside the table, this is incorrect in HTML See https://html.spec.whatwg.org/multipage/tables.html#the-table-element replace with a tr/td opw-4369019 Forward-Port-Of: odoo/enterprise#77132
Original PR description
- Install `web_studio` and `l10n_ke_edi_oscu`
- Open the report editor from anywhere
- Search for report_invoice
- Open it
- Traceback
This is caused by the div inside the table, this is incorrect in HTML
See https://html.spec.whatwg.org/multipage/tables.html#the-table-element
replace with a tr/td
opw-4369019
Forward-Port-Of: odoo/enterprise#77132The transfer form view contains two list views that were poorly displayed. The two were shrunk to half the available space. This is due to the fact that a group is by default two divs in a row each expecting one element, usually the label and the field value. However, only the value is to be displayed in our case. Hence, why the list only take up half of the space made avalailable by the group. To solve this, we can simply force the number of columns taken by the list to 2. task-4481314
Original PR description
The transfer form view contains two list views that were poorly displayed. The two were shrunk to half the available space. This is due to the fact that a group is by default two divs in a row each expecting one element, usually the label and the field value. However, only the value is to be displayed in our case. Hence, why the list only take up half of the space made avalailable by the group. To solve this, we can simply force the number of columns taken by the list to 2. task-4481314 Forward-Port-Of: odoo/enterprise#77346
In this PR: - Refactored error handling for better clarity and organization. - Grouped errors by section and invoice for structured reporting. - Added clickable invoice links in error messages for easy navigation. - Scheduled detailed activities for invoices with errors. - Enhanced code readability and maintainability. This ensures clearer error reports, efficient activity creation, and easier future updates. Forward-Port-Of: odoo/enterprise#76880
Original PR description
In this PR: - Refactored error handling for better clarity and organization. - Grouped errors by section and invoice for structured reporting. - Added clickable invoice links in error messages for easy navigation. - Scheduled detailed activities for invoices with errors. - Enhanced code readability and maintainability. This ensures clearer error reports, efficient activity creation, and easier future updates. Forward-Port-Of: odoo/enterprise#76880
Forward-Port-Of: odoo/enterprise#77290 Forward-Port-Of: odoo/enterprise#77126
Original PR description
Forward-Port-Of: odoo/enterprise#77290 Forward-Port-Of: odoo/enterprise#77126
Forward-Port-Of: odoo/enterprise#75568
Original PR description
Forward-Port-Of: odoo/enterprise#75568
Currently, an error occurs when opening a preview of an invoice without an invoice date Step to produce: - Install the `l10n_ec_edi` module (with demo data). - Change a current company to 'EC Company', which has an 'Ecuador' country. - Create a new invoice, add a customer name, payment terms, and invoice line, save the record, - Click on the 'Preview' button (ensure that the invoice has no date). ```TypeError: unsupported operand type(s) for -: 'bool' and 'datetime.date'``` An err
Original PR description
Currently, an error occurs when opening a preview of an invoice without an invoice date Step to produce: - Install the `l10n_ec_edi` module (with demo data). - Change a current company to 'EC Company', which has an 'Ecuador' country. - Create a new invoice, add a customer name, payment terms, and invoice line, save the record, - Click on the 'Preview' button (ensure that the invoice has no date). ```TypeError: unsupported operand type(s) for -: 'bool' and 'datetime.date'``` An error occurs when the system attempts to calculate payment term days at [1], with using an invoice date, but it is not available. Link [1]: https://github.com/odoo/enterprise/blob/26aa95079af2a868c2991c7f19daee5328d5bb01/l10n_ec_edi/models/account_move.py#L440C22-L440C93 To resolve this issue, Provide a default day zero(0) for the payment term, if invoice date is not available. Sentry-6015854429 Forward-Port-Of: odoo/enterprise#76881 Forward-Port-Of: odoo/enterprise#72864
*: frontdesk, hr_contract_salary, hr_referral Issue: when the website has a domain `get_base_url` return the domain if the record calling it has a company set on it - call the function with an empty object to get the database url instead Task: 3903743 Forward-Port-Of: odoo/enterprise#77256 Forward-Port-Of: odoo/enterprise#76888
Original PR description
*: frontdesk, hr_contract_salary, hr_referral Issue: when the website has a domain `get_base_url` return the domain if the record calling it has a company set on it - call the function with an empty object to get the database url instead Task: 3903743 Forward-Port-Of: odoo/enterprise#77256 Forward-Port-Of: odoo/enterprise#76888
When the user clicks on the ``Process now`` button, a traceback will appear. Steps to reproduce the error: - Install ``l10n_ec_edi`` module > Switch to EC Company - Create a new invoice > Add Payment Method (SRI) > Confirm - Go to Configuration > Settings > SRI Connection > enable ``Use production servers`` > Save - Go back to the invoice > Request EDI Cancellation > Process now Traceback: ``` File "home/odoo/src/enterprise/18.0/l10n_ec_edi/models/account_edi_format.py", line 525, i
Original PR description
When the user clicks on the ``Process now`` button, a traceback will appear. Steps to reproduce the error: - Install ``l10n_ec_edi`` module > Switch to EC Company - Create a new invoice > Add Payment…
When the user clicks on the ``Process now`` button,
a traceback will appear.
Steps to reproduce the error:
- Install ``l10n_ec_edi`` module > Switch to EC Company
- Create a new invoice > Add Payment Method (SRI) > Confirm
- Go to Configuration > Settings > SRI Connection > enable ``Use production servers`` > Save
- Go back to the invoice > Request EDI Cancellation > Process now
Traceback:
```
File "home/odoo/src/enterprise/18.0/l10n_ec_edi/models/account_edi_format.py", line 525, in _l10n_ec_get_authorization_status_new
response_auth_list = response['autorizaciones'] and response['autorizaciones']['autorizacion'] or []
TypeError: 'NoneType' object is not subscriptable
```
https://github.com/odoo/enterprise/blob/2e1af04e36fcbdcd11e3a7e2994673b2c4a5cf85/l10n_ec_edi/models/account_edi_format.py#L525
When there is any kind of connection error, the ``response`` will be ``None``,
which will result in the above traceback.
sentry-6199991614
Forward-Port-Of: odoo/enterprise#76614With this commit message translation will be available in livechat channels for internal users. task-4457025 https://github.com/odoo/odoo/pull/193260 Forward-Port-Of: odoo/enterprise#76936
Original PR description
With this commit message translation will be available in livechat channels for internal users. task-4457025 https://github.com/odoo/odoo/pull/193260 Forward-Port-Of: odoo/enterprise#76936