Tuesday, January 21, 2025
10 changes · 17.0
Resolved issues and error corrections
This fixes an issue where uninstalling the SMS app after using Recruitment could cause errors. Recruitment-related SMS features are now separated into a small connector module, so businesses can opt out of SMS services without disrupting recruitment workflows.
Original PR description
… hr_recruitment on sms in a glue module Missing dependency caused errors when uninstalling sms after installing hr_recruitment. The glue module approach is implemented for the benefit of users who decide to opt out of IAP services. Resolves #191635 Description of the issue/feature this PR addresses: Current behavior before PR: [Issue 191635](https://github.com/odoo/odoo/issues/191635) Desired behavior after PR is merged: You will be able to uninstall sms module safely which will in turn uninstall the new module hr_recruitment_sms without causing issues with hr_recruitment. Runbot Templates is failing because new modules typically shouldn't be added in stable. An exception can be given after review and approval. A similar buggy sms action in hr.candidate was introduced later in #169955 I'll create a new PR targeting 18.0 once this one is forward ported. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue that could prevent users from scheduling HR-related activities when multiple records were handled at once. This avoids an unexpected error and helps keep activity planning reliable.
Original PR description
### Description of the issue/feature this PR addresses: - The [_get_plan_available_base_domain()](https://github.com/odoo/odoo/blob/18.0/addons/mail/wizard/mail_activity_schedule.py#L330) method is built and `self.ensure_one()` is placed in it but it is called in `_compute_plan_available_ids()` with `self` which can have multiple records ### Current behavior before PR: - The error `ValueError: Expected singleton: mail.activity.schedule(1, 2)` occurred ### Desired behavior after PR is merged: - The problem has been fixed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Duplicating a manufacturing order and changing its scheduled date now works correctly. This prevents an error during confirmation, helping teams continue production planning without interruption.
Original PR description
Steps to reproduce: ----- - Create a MO - Duplicate it - Change the scheduled date - Confirm Issue: --- This [changes](https://github.com/odoo/odoo/commit/7c808beaf36853b4d9171ef0981d1ec9c4b73a44), is trying to timedelta between str and datetime leading to an error. Fix: --- To fix this the date_start is set as a datetime and removing the conversion later in the code. opw-4489618 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Employee records created by HR administrators without broader administration rights no longer receive a default avatar that can display incorrectly. This avoids corrupted image placeholders in employee Kanban views and keeps the employee list visually clean for users.
Original PR description
Steps ----- - Have a user with 'Employees' Administator rights and no 'Administration' rights. - Create a new employee. - When viewing the Kanban views of employees, the image for the newly created employee appears corrupted (the text 'binary file' appears instead of the image). Cause ----- When we create a new employee, `_avatar_generate_svg` is called https://github.com/odoo/odoo/blob/717f3a1ab25613c02c2d0b28fa8dd73f4e6c75e0/addons/hr/models/hr_employee.py#L497-L498 that returns a svg/xml base-64 encoded. However, only users with write rights to `ir.ui.view` are able to create svg/xml attachments. https://github.com/odoo/odoo/blob/717f3a1ab25613c02c2d0b28fa8dd73f4e6c75e0/odoo/addons/base/models/ir_attachment.py#L368-L371 Else, the attachment has a text mimetype forced, leading to it being incorrectly displayed. Change ----- A default image is not generated at employee creation if the user doesn't have sufficient rights. opw-4311251
This fix prevents an error from appearing when users change the date on a manufacturing production order. It helps production teams update schedules without being interrupted by a technical failure.
Original PR description
### Before this PR Changing the date on production this error appears `unsupported operand type(s) for -: 'str' and 'datetime.timedelta'` ### After this PR No error Error caused by this commit https://github.com/odoo/odoo/commit/7c808beaf36853b4d9171ef0981d1ec9c4b73a44 by this pr https://github.com/odoo/odoo/pull/188389 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The spreadsheet accounting context menu now correctly shows the See Records icon when users open account move line records. This fixes a small visual issue and makes the action easier to recognize for users working with accounting data in spreadsheets.
Original PR description
# Description The 'See Records' icon was missing when attempting to open `AccountMoveLines` records from the context menu in the spreadsheet. Task: 0 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Malaysia e-invoicing partner view no longer fails for users who can access a partner but cannot access the related proxy user. The ID validation action was also adjusted to avoid the same access problem, making partner workflows more reliable.
Original PR description
Fixes an issue on the partner view where a compute would try to read the proxy user, while not all users who can read the partner would have read access to the proxy user. Also fix a similar case in the action used to validate the ID, which tries to read the proxy user. error-105104 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Duplicating a field service task now clears links to the original sales order and sales line, preventing the new task from being tied to the previous invoice. This avoids billing confusion and keeps copied tasks financially independent from the original work.
Original PR description
Steps to reproduce: ----- - Create a FSM task - Add products - Mark as done - Create invoice - Duplicate the task Issue: ----- The newly created task is linked to the invoice of the duplicated task. This comportment is not intended. Fix: ---- Creation of the copy method so the sale_order_id and the sale_line_id get set to false when duplicating a record. opw-4393596
This update changes how an Indian payroll salary rule is retired: it is archived instead of permanently deleted. This helps preserve payroll configuration history and reduces the risk of errors when related records still depend on that rule.
Odoo Studio now shows only company-related fields when users add fields to report headers or footers. This prevents users from selecting fields from the wrong business record and helps keep customized reports accurate.
Original PR description
…footer Before this commit, when in the report editor, trying to add a field in the footer, the main doc's fields were proposed. This was wrong because header and footer are generic views that can treat any record at once. They just set an internal variable for the company of the record, which should be the only available model to add fields from. After this commit, it is not possible to add fields from anything else than the "company" variable opw-4471868