Tuesday, January 21, 2025
3 changes · saas-18.1
Resolved issues and error corrections
This fix ensures Odoo saves a module’s installed status at the right point during setup. If a later module fails to install, already completed auto-installed modules will still be recognized correctly, preventing scheduled jobs or other records from breaking because their code is not loaded.
Original PR description
Given the following module hierarchy: <pre> ... \_ mid_level_module \_ auto_install_module \_ module_with_data_error </pre> Where: * The auto install module has (for sake of example) some a model…
Given the following module hierarchy:
<pre>
...
\_ mid_level_module
\_ auto_install_module
\_ module_with_data_error
</pre>
Where:
* The auto install module has (for sake of example) some a model override of `ResCurrency` that defines a new method for the class. This module also has some data that defines an `IrCron` record, which executes the method added by the `ResCurrency` override within its own model files.
* The data error module has a view extension which has some bad syntax that will trigger a failure in `load_data()`.
Upon running an odoo instance with `-i module_with_data_error`, the module load will proceed until failing at this module- however the CRON data loaded from `auto_install_module` will be in the `ir_cron` postgres table, while its overridden method is not in the registry.
***
The problem occurs because a package's data/schema changes are committed prior to actually marking the module record as installed- so the mark install step doesn't get committed until the subsequent package data/schema changes are committed.
When the data_error module fails to have its data loaded, we will reset `to_install` modules as `uninstalled`- but because the module state changes from the prior package (auto_install) were not yet committed, it will not attempt to reinstall this package upon re-initialization (receiving a new request which un-rests the server).
So we are left with the CRON record which was committed already, without the actual model override required for the CRON to run.
***
If we modify the module state before committing, the issue is no longer present.This fixes an issue where opening a CRM graph view could make spreadsheet geo charts fail when returning to the spreadsheet. The change keeps the chart mapping support available consistently, reducing crashes and interruptions for users working with spreadsheets and reports.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Time Off reporting page by type now opens line and pie chart views without crashing. This helps managers and HR teams reliably review absence trends and breakdowns in the reporting dashboard.
Original PR description
The line and pie chart were crashing in the time off reporting by type. Steps to reproduce: - Open time off > Reporting > By type - Click on the line or pie chart view This commit fixes the issue by processing the data points for the line and pie chart views. task-4477518