Friday, January 24, 2025
16 changes · 18.0
Resolved issues and error corrections
The messaging menu now correctly refreshes its notification count when a user dismisses the browser notification prompt. This prevents misleading unread counts and keeps the messaging indicator accurate for users.
Original PR description
**Current behavior before PR:** Since [1](https://github.com/odoo/odoo/pull/192336) when a user discarded the `Turn on notifications` option from the messaging menu, the systray notification counter was not updated. This issue occurred due to an incorrectly written condition. **Desired behavior after PR is merged:** The issue is resolved, and the systray notification counter is correctly updated when the user discards the native notification prompt. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The live chat window will now automatically open only once per visitor when configured to do so. This prevents repeated popups on every page visit, reducing annoyance and improving the website visitor experience.
Original PR description
Livechats can be configured to automatically open a chat window when a visitor opens a page. This should only occur once per visitor not to bother visitors. Before this PR, this occured each time the visitor accessed the page. The information on whether the popup was donce once is stored in the local storage but is incorrectly checked. This PR fixes the issue. opw-4503667
This fixes a visual issue on the online shop page where product grid borders could overlap nearby products or appear behind product images after changing product sizes. The correction keeps the grid layout clean and avoids confusing storefront presentation for shoppers.
Original PR description
Issue: in the /shop page, using the grid style if we change the size of a product on another column than the first one, the border of the grid will appear on the product or behind its image. This is due to the width 100vw which extends behind the product's current width and overflowing on other products of the same row. task-4513299 opw-4447224 | | |--------| --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Changing lot valuation from a product variant now uses the correct product-level update process. This prevents inconsistent valuation checks and helps keep inventory valuation behavior reliable.
Original PR description
The write logic for lot_valuated is handled on the ProductTemplate. When you change the value of 'lot_valuated', '_svl_empty_stock()' is called before the new value is set, and the code expects ProductTemplate.lot_valuated and ProductProduct.lot_valuated to not yet be updated. However, if you change 'lot_valuated' from the ProductProduct model, ProductProduct.lot_valuated will be updated before ProductTemplate.write() is called. Hence, in '_svl_empty_stock()', ProductTemplate.lot_valuated != ProductProduct.lot_valuated This issue only happens in the 'write' context, so it should not cause too much issue. To fix this issue, when lot_valuated is updated from ProductProduct, we call the ProductTemplate write instead. --- https://github.com/user-attachments/assets/9d2f64a4-a7ad-4078-ad0b-0cc50270492b --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an accounting currency query from being built incorrectly when no companies are configured with a domestic currency. It helps avoid errors in affected accounting workflows and improves reliability in less common company setups.
Original PR description
We are not gonna find a value for domestic_currency_companies everytime, sometime they simply don't exist. In that case, we should check that they exist before we call _get_table_builder_domestic_currency. otherwise syntax of this query: https://github.com/odoo/odoo/blob/18.0/addons/account/models/res_currency.py#L157 is gonna be wrong. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The live chat button now receives the information it needs when opened from the chatbot test page. This prevents a setup gap that could affect testing live chat behavior before publishing it.
Original PR description
The livechat button loader template adds `websocket_worker_version` to the Odoo session. However, when the loader is called through `chatbot_test_script_page`, it does not receive the `websocket_worker_version`. In the standard Odoo environment, this value is already available in the session This fix ensures the `websocket_worker_version` is properly handled in scenarios involving `chatbot_test_script_page`. Task-4462067 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A missing company partner identifier was added to the accounting onboarding form so partner autocomplete works correctly. This prevents errors when users apply partner autocomplete during company setup or onboarding.
Original PR description
`partner_gid` was missing from `res_company_form_view_onboarding` view which was creating a bug when applying the partner autocomplete. opw-4489441 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue in Point of Sale employee handling where opening or closing a session could fail for employees linked to more than one partner record. Businesses can now manage POS sessions more reliably without interruptions caused by this employee setup.
Original PR description
Before this commit, if an employee had multiple related partners, an expected singleton error occurred when attempting to set the opening or closing of the session. opw-4482497 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale sessions now record their opening time when the cashier clicks "Open register". This prevents new sessions from incorrectly inheriting the previous session's closing time, improving the accuracy of store session records.
Original PR description
- Fix bug where session opening time was set to previous session closing time. - Now we want the pos session opening time to be set when we click "Open register". task-id: 4500391 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Manufacturing planning view now identifies late work orders using the exact current date and time instead of only the calendar day. This makes the late filter more reliable for teams prioritizing urgent production work.
Original PR description
Steps to reproduce: ---- - Go to manufacturing - Planning by production - Add late filter Issue: ---- The late filter "does not work", the filter is based on the day. But the late order should be based on a much more precise datetime. Fix: --- Changed the filter from current_date to datetime.now to have more precision in the time, and so it filters more accurately. opw-4493678 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix updates a sales project test so it works consistently when that module is tested on its own. It helps prevent false test failures caused by missing project accounting setup, improving confidence in future releases.
Original PR description
It was failing in single module builds /locally and the reason was due to the fact that project not having a analytic account. task-4500108
The website editor now creates a proper primary button when users choose the button command from the powerbox, instead of accidentally inserting a regular link. This makes content editing more predictable and helps users create the intended call-to-action elements without extra manual adjustments.
Original PR description
Before this commit: Using the button command in the powerbox resulted in the creation of a regular link instead of a button. After this commit: Executing the button command now correctly creates a primary button as intended. task-4380129 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change adds coverage to ensure overtime is calculated correctly when an employee clocks in and out multiple times in one day, such as for breaks. It helps prevent incorrect extra-hours balances by making sure adjustments are applied to the latest attendance entry.
Original PR description
This PR adds a test to ensure that negative overtime works properly and is recomputed as multiple attendance records are made on a single day. For employees who clock out to take breaks, this is necessary. This ensures that the "extra hours" propagate to the most recent attendance record, while zeroing out those before it. The PR that brought the notion of negative overtime to flexible working schedules is here: https://github.com/odoo/odoo/pull/193523#pullrequestreview-2569240672
Direct debit mandates with a future start date are no longer closed when the mandate update task runs. This prevents valid upcoming customer payment authorizations from being incorrectly deactivated before they can be used.
Original PR description
### Steps to reproduce: - Go in Accounting > Customers > Direct Debit Mandates - Create a new mandate with a start date in the future - In Scheduled Actions search for "Mandate state updater" - Run manually this action - Return to Accounting > Customers > Direct Debit Mandates - The mandate was closed ### Cause: The code checks if `mandate.start_date <= today <= expiry_date`, if not the mandate is closed. ### Solution: Only check if `today <= expiry_date` opw-4460087
This fix ensures Belgian salary package users can select private car or bike options when a mobility budget is part of the contract. It prevents an incorrect restriction in the salary configuration flow, making mobility-related compensation choices available as intended.
This fix updates automated checks for Knowledge articles so they match recent editor changes and run reliably again. It removes a source of inconsistent test failures caused by embedded video loading, helping keep future Knowledge updates safer and more stable.
Original PR description
1st issue: Since the introduction of the [media command] in the editor, replacing the previous `/file`, some tour steps of a disabled test became obsolete. This commit fixes these steps according to…
1st issue: Since the introduction of the [media command] in the editor, replacing the previous `/file`, some tour steps of a disabled test became obsolete. This commit fixes these steps according to changes introduced along the `/media` command, in order to re-enable this test. 2nd issue: Other steps were incorrectly modified by [this commit] and had to be adapted too, related to the composer signature. 3rd issue: An embedded video was present in an article body in the readonly tour, and the patch supposed to neutralize it (to avoid external http requests) was applied in a manner that resulted in an indeterministic result: Sometimes the article body was loaded with the video, resulting in errors, sometimes the patch was applied resulting in the tour performing normally. This commit fixes the issue by ensuring there is no embedded video after the end of the editable tour, so that there is no need to care about it in the readonly tour. [media command]: https://github.com/odoo/odoo/commit/96c8c398c0fbef519b56edf4941691d11372eac0 [this commit]: https://github.com/odoo/enterprise/commit/1a73e227a5ce9fb1194e5664c8c4f5fcfe51b572 runbot-task-111948