Sunday, January 26, 2025
1 change · 18.0
Resolved issues and error corrections
This fix ensures that mention suggestions inside restricted channel threads only show people allowed by the parent channel's access rules. It prevents users from seeing or selecting inappropriate contacts in threaded discussions, keeping collaboration lists consistent with channel visibility settings.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/176758 Commit above adds elligible partners in `@` mention suggestions, when the channel is restricted. However, channel threads could mention anyone,…
Follow-up of https://github.com/odoo/odoo/pull/176758 Commit above adds elligible partners in `@` mention suggestions, when the channel is restricted. However, channel threads could mention anyone, which is unintended. Steps to reproduce: - open a restricted channel, e.g. `#general` - open or make a sub-thread on this channel - type `@` in composer => non-internal users are shows in suggestion list. This happens because when the channel is restricted, this limits the amount of partners in the mention list. Problem is that channel threads do not set their `group_public_id`, and instead the parent value should be checked. This was not taken into account, which lead to unrestricted list of suggestions in these channels. This commit fixes the issue by checking the parent channel `group_public_id` for listing the elligible people that can be mentioned. Before  After 