Monday, January 27, 2025
9 changes · 17.0
Resolved issues and error corrections
This fixes SMS sending so the system correctly retrieves the phone number from a linked contact record. It helps prevent messages from using the wrong source data and adds a corrected test to ensure the real issue is covered.
Original PR description
Followup of odoo/odoo#134682 but for code added notably during odoo/odoo@f685e70616e8fe357690cd8e6cfa4543c1d0df24 Also fix the test, as it was not testing the real issue (wrong model used in test). Task-3743525
Saving a server action no longer risks losing its linked record reference. This prevents configuration details from disappearing unexpectedly and helps keep automated actions reliable after edits.
Original PR description
Before this commit, the resource_ref field of a server action can disappear when the action is saved. This is due to the following: - the update_related_model_id is a computed stored READONLY field which leads to it not being included in the web_save rpc and is therefore not saved on the record The fix consists to ensure the update_related_model_id is saved by making it readonly=False, which is usually what we want when we have a computed stored field. Task: opw-4513803
X2many fields configured to include inactive records will now continue to show those records even when a custom order is applied in the view. This prevents expected records from disappearing in sorted lists and keeps the interface consistent with the field setup.
Original PR description
Issue:
If we have a X2many that allows to have inactive records (with `context={'active_test': False}` on the field definition) and we specify a specific order for this X2many in this view, web_read won't respect the context of the field and will filter out inactive records.
This is because to apply a specific order in the web_read, we use search(), which will filter out inactive records from the `corecords` recordset.
Fix:
We fix this by forcing active_test=False before calling search and reapplying the previous context immediately after.
Closes #194311Repair order reports now correctly display product descriptions for lines marked as Recycle. This prevents blank rows on customer-facing repair documents and makes the reports clearer and more complete.
Original PR description
Description of the issue/feature this PR addresses: The "Recycle" repair type wasn't integrated properly into the report template Current behavior before PR: Repair lines with "Recycle" type create empty lines on the repair order report   Desired behavior after PR is merged: Repair lines with "Recycle" type have their product description printed on the report --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where list records in related fields could be sorted before their context-based filters were applied. Businesses using filtered related lists will now see the expected records even when a default sort order is configured.
Original PR description
Otherwise, if we use a context, it is not applied when filtering
Description of the issue/feature this PR addresses: if you create a One2Many field with context={'active_test': 1} and you use the default_order on the tree view, the context is not applied.
Current behavior before PR: Contexts are not applied
Desired behavior after PR is merged: Context is applied.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update fixes intermittent failures in automated tests for web forms. It helps keep the validation process stable so future changes can be checked more reliably before release.
Original PR description
Those tests are sometimes failing since [1]. This commit is essentially a partial backport of [2], from the hoot suite to the qunit one. The other suites changed in [2] were already fixed in this version. [1] odoo/odoo#189147 [2] odoo/odoo#190157 runbot issue-109694 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Internal users with Sign access can now open sample signing documents without encountering an access error. This helps teams evaluate or demonstrate the Sign app more smoothly after installation.
Original PR description
Version: - 17.0 Steps to reproduce: - Install the Sign module. - Try to open a sample document. Issue: - An access error occurs when a "Sign User" tries to access a demo sign template. Solution: - Allow internal users to access sample data. task- 4390945
The Kenyan payroll calculation now prevents PAYE tax from becoming negative when gross pay is low. This helps ensure payslips show valid tax amounts and payroll results remain compliant and easier to review.
Original PR description
Problem ---------- With low values of Gross, the PAYE can be negative. The must be always positive or equals to 0 Objective ---------- Make the PAYE computation positive. Check the PAYE computation. Solution ---------- It will be now the maximum between the previous computation and 0. To be always >= 0. Order the Gross Taxable with the sequence number. PAYE computation is correct, check the task for more details. task-4255918
This fix ensures Dutch companies can still open the EC Sales List even if related technical identifiers were removed. It corrects the fallback lookup used for tax report references, preventing an access error in accounting reports.
Original PR description
**Steps to reproduce:** - Use the `NL Company`; - Go to `External Identifiers` (via `Settings / Technical / Sequence & Identifiers`): - Remove `l10n_nl.tax_report_rub_3bg_tag` and/or…
**Steps to reproduce:**
- Use the `NL Company`;
- Go to `External Identifiers` (via `Settings / Technical / Sequence & Identifiers`):
- Remove `l10n_nl.tax_report_rub_3bg_tag` and/or `l10n_nl.tax_report_rub_3bg_tag` identifiers;
- Try to access `EC Sales List` (via `Accounting / Reporting / Statement Reports`).
___
**Issue:**
Can't access `EC Sales List` of the Dutch company after deleting any or both of the `l10n_nl.tax_report_rub_3bg_tag` and/or `l10n_nl.tax_report_rub_3bg_tag` identifiers.
___
**Expected:**
Users should be able to access `EC Sales List` even when an identifier is deleted as there is a fallback.
___
**Cause:**
The fallback doesn't refer to the good tax options.
https://github.com/odoo/enterprise/blob/b2368558afdf922fdf04bdcfa8a98b4e690ddccd/l10n_nl_intrastat/models/account_sales_report.py#L82-L84
___
**Fix:**
Adapt the fallback references' module for retrieval as done for testing in: https://github.com/odoo/enterprise/blob/b2368558afdf922fdf04bdcfa8a98b4e690ddccd/l10n_nl_intrastat/tests/test_sales_report.py#L22-L24
___
opw-4425376