Wednesday, January 29, 2025
5 changes · saas-18.1
Resolved issues and error corrections
This update brings the spreadsheet component up to the latest version and fixes several issues affecting spreadsheet behavior. Users should see more reliable Excel export validation, formula results, selections, popovers, and grid display when working with spreadsheets in Odoo.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/a11ef279d [REL] 18.1.4 Task: 0 https://github.com/odoo/o-spreadsheet/commit/47d6c123e [FIX] session: useless snapshot…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/a11ef279d [REL] 18.1.4 Task: 0 https://github.com/odoo/o-spreadsheet/commit/47d6c123e [FIX] session: useless snapshot on leave Task: 4356913 https://github.com/odoo/o-spreadsheet/commit/936b264ca [FIX] xlsx: fix data validation range Task: 4505771 https://github.com/odoo/o-spreadsheet/commit/9dbe36b4e [REF] range: rename useFixedReference Task: 4506120 https://github.com/odoo/o-spreadsheet/commit/52dabf1e4 [FIX] xlsx: export data validation with unbounded range Task: 4505771 https://github.com/odoo/o-spreadsheet/commit/7ffac1e6e [REL] 18.1.3 Task: 0 https://github.com/odoo/o-spreadsheet/commit/7365956a3 [FIX] TextValueProvider: Avoid duplicate key in template Task: 4483494 https://github.com/odoo/o-spreadsheet/commit/14bd65a68 [FIX] formulas: binary search returning incorrect index for multiple exact matches Task: 4328300 https://github.com/odoo/o-spreadsheet/commit/967f484a9 [FIX] selection: drag and drop resized cols and rows Task: 4454025 https://github.com/odoo/o-spreadsheet/commit/c2b340c95 [FIX] popover: wrong position on updated popover Task: 3814260 https://github.com/odoo/o-spreadsheet/commit/a8ed632af [FIX] Selection: selection follows the moved header Task: 4461901 https://github.com/odoo/o-spreadsheet/commit/655904b57 [FIX] icons: Missing dimension on icon Task: 4461359 https://github.com/odoo/o-spreadsheet/commit/739edba84 [FIX] GridComposer: Fix CellReference pill display Task: 4501136 https://github.com/odoo/o-spreadsheet/commit/817bf51d4 [FIX] renderer: Fix grid rendering Task: 4448426 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Florian Damhaut (flda) <flda@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
The restaurant mobile menu now shows product images correctly for guests, keeps product descriptions clean when details are missing, and adds the selected quantity from product info popups to the cart. This improves the ordering experience for customers using the menu without logging in.
Original PR description
Steps to Reproduce: === - Open the restaurant's mobile menu in a browser where you are not logged in. - Interact with the product info (`i` button) and cart features. Issues: === 1. Product images were not displayed correctly, showing a default image instead. 2. Clicking the info (`i`) button displayed "false" or unformatted description if the product had no public description. 3. Adding more than one quantity of a product through the info popup only added a single item to the cart. Fixed: === 1. Resolved the image issue by ensuring images are accessible even when not logged in. 2. Corrected the display of public descriptions to show properly formatted text, else blank. 3. Fixed the cart issue to allow adding multiple quantities of a product correctly. Task: 4463971
Spanish TBAI electronic invoice XML files now calculate the total invoice amount correctly when a line has more than one tax. This prevents overstated totals in submitted tax reporting data and helps invoices match their real accounting amounts.
Original PR description
Steps to reproduce:
-------------------
- in a Spanish company, make sure l10n_es_edi_tbai is installed.
- create an invoice with one product and add 2 taxes for that line (for example, the 21% goods and the 5.2 ES tax).
- confirm and send the invoice with TBAI.
- in the TBAI xml you will find the total amount wrong as the base amount was calculated twice, one time for each tax.
Cause:
-----
Since (#180062), the tax details calculation process was reworked.
So now the total amount is calculated inside a loop with this formula
```
for values in values_per_grouping_key.values():
total_amount += values['base_amount'] + values['tax_amount']
```
in our case the one invoice line will generate 2 tax groups (one for each tax) so this code will add the base_amount twice in the total_amount calculation.
Fix
---
move the base amount aggregation outside the loop, in a separate loop over the base_lines.
opw-4501051This fixes an issue in Point of Sale where the customer display could fail when configured to run on another device. Businesses using customer-facing displays can now add products in POS without that display setup causing errors.
Original PR description
Steps to reproduce: - Set the customer display feature on "another device" in the settings - Open the POS and add products Reason: The refactor in 59700feb8fb6e4ca993ffdd1eef6951b9203ca06 badly kept referencing `pos` as a class field instead of a function parameter. opw-4508838
This fix stops Kenyan eTIMS submissions from crashing when a vendor bill line has a product without a name. Instead of an unexpected error, users will now receive a clear warning to correct the product line before sending.
Original PR description
This error occurs when clicking the ``Send to eTIMS`` button because the move lines lack a product name. Steps to reproduce: --- - Install ``l10n_ke_edi_oscu`` module > Switch to ``KE Company`` - Create a NEW Vendors Bill > Add a Product and remove the product name > Save - Click ``Send to eTIMS`` Traceback: --- ``ZeroDivisionError: float division by zero`` At [1], we encounter ``product = False`` because, at [2], the ``product_id`` is being retrieved from the move lines, but no product name is present in the move lines. After this commit, we will ensure that valid values are present in product lines; otherwise, an warning will be raised. [1] - https://github.com/odoo/enterprise/blob/4832c81b89f8831d5a06671ee9c06ac06973b7b5/l10n_ke_edi_oscu/models/account_move.py#L265 [2]- https://github.com/odoo/enterprise/blob/4832c81b89f8831d5a06671ee9c06ac06973b7b5/l10n_ke_edi_oscu/models/account_move.py#L240 sentry-6242406302