Thursday, January 30, 2025
11 changes
1 change
Resolved issues and error corrections
This fix prevents Odoo from totaling the same numeric field that users choose for grouping records. It avoids confusing or incorrect grouped results, making views such as Kanban more reliable for everyday analysis.
Original PR description
This commit fixes an issue where if the user applies a group by on an aggregatable field (an integer like color_index for example), this field is also registered as an aggregator in the webReadGroup call and this leads to nonsensical results by the orm. After this commit, the group by field is automatically excluded from aggregators so the issue cannot happen. task-4491839
10 changes
Resolved issues and error corrections
This update fixes a small issue in sales PDF quote building so available product documents are calculated correctly when multiple sales orders are processed together. It helps keep generated quotes consistent and avoids missing or incorrect document options in batch operations.
Original PR description
This fix addresses a minor issue with the `_compute_available_product_document_ids` method of `sale.order`, which doesn't fully support multi-compute. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue where downloading a PDF for an unconfirmed invoice could fail with an error. Business users can now export draft invoice PDFs reliably from the invoice list, avoiding disruption during invoice preparation.
Original PR description
Steps to reproduce the error: - Create a new invoice. Don't confirm it. - Go to list view of invoices. - Select that invoice > Download > PDF Traceback: "AttributeError: 'bool' object has no attribute 'replace'" `_get_move_display_name` can be used instead as it already handles draft invoices. sentry-6191644587
This fix ensures carousel control options behave correctly when editing a website page. Business users get a more reliable preview and setup experience when choosing whether carousel arrows and indicators are hidden or centered.
Original PR description
Since [1], a method was introduced to prevent the "controllers" options from being centered when arrows and indicators are displayed. However, it was implemented in the wrong overridden method (computeWidgetState), which cannot update the DOM. Additionally, it failed to account for the preview mode. This commit resolves these issues. Steps to reproduce: - Website - Edit mode - Drag and drop a "carousel intro" snippet onto the page. - Select the option "Controllers > Arrows > Hidden." - Then select the option "Controllers > Centered." - The controllers are now displayed as centered. - Hover over the "Controllers > Arrows" options and preview a value other than "Hidden." - The preview does not update correctly. [1]: https://github.com/odoo/odoo/commit/454d743ed631c068b7b0bc72e4fd81b225a5ac52 Related to: task-4094405
The hierarchy view icon now appears in the intended tree-like orientation as soon as it is shown. This avoids a confusing visual glitch where the icon initially appeared incorrectly until users opened the hierarchy view.
Original PR description
This PR aims to fix an issue about the icon related to the hierarchy view not being rotated anymore. | 18.0 and above | This PR | |--------|--------| | <img width="529" alt="image"…
This PR aims to fix an issue about the icon related to the hierarchy view not being rotated anymore. | 18.0 and above | This PR | |--------|--------| | <img width="529" alt="image" src="https://github.com/user-attachments/assets/11289aa4-948d-4725-b8d5-e91bf5d601fc" /> | <img width="531" alt="image" src="https://github.com/user-attachments/assets/bc74ef4e-6e74-47d1-ac06-6bde1d6ed933" /> | To render the icon of the hierarchy view, we use a little trick by rotating the `fa-share-alt` icon so that it looks like a tree diagram one. Unfortunately, this does not work anymore in `18.0` and above. It seems the CSS won't be loaded until you entered the module, which leads to the icon being rendered to `fa-share-alt` by default and then rotated correctly once you click on it. To fix this issue, we actually make use of available utility classes `fa-rotate-90`to handle the icon rotation and `align-text-top` to handle the vertical alignment when the icon is rendered within a node. task-4501317 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Saudi Arabia POS orders with a zero total, such as orders fully paid with an eWallet, no longer trigger an error during validation. This helps businesses complete legitimate sales smoothly without manual workarounds.
Original PR description
Before this commit, attempting to validate an order with a zero total (such as when fully paid using an eWallet) would result in an error. opw-4487591 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The survey editor now prevents users from adding embedded components that would not display correctly when respondents view the survey. This avoids broken or missing content in published surveys and helps creators use options that work reliably.
Original PR description
**Problem**: Embedded components do not render when the `html` field content is displayed outside the editor, as their mechanism relies on the editor plugin. **Solution**: Disable embedded components for the survey. **Steps to Reproduce**: 1. In a survey, add a section. 2. Add a "View" button. (Debug mode ON) 3. Use the `/` command box and add the "Video link" option. 4. Save and test the survey. 5. The video does not display. opw-4487027 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue where users could hit an error when registering a payment for an invoice without an invoice date, especially when early payment discounts are involved. The payment flow now skips discount date calculations when the required invoice date is absent, avoiding disruption for accounting users.
Original PR description
Currently, a traceback occurs when there is no invoice date and tries to register a payment from actions. To reproduce this issue: 1) Install accounting 2) Create a customer invoice with payment term…
Currently, a traceback occurs when there is no invoice date and tries to register a payment from actions. To reproduce this issue: 1) Install accounting 2) Create a customer invoice with payment term having an early discount 3) Make sure the invoice date to be empty 4) Add a line and from actions click pay Error:- ``` TypeError: unsupported operand type(s) for +: 'bool' and 'relativedelta' ``` In account move, `invoice_date` is not required. So when the user tries to register a payment with payment term having an early discount and no invoice date, It leads to the above traceback from below line. https://github.com/odoo/odoo/blob/ee48df7f33a3aeb1798bf5852be8c6d26a7db7fd/addons/account/models/account_payment_term.py#L256-L258 Indeed, a date is required to get an early discount date. so without date, we should not execute the `_get_last_discount_date` method. In some other locations, it was managed in a similar manner as indicated in the below line. https://github.com/odoo/odoo/blob/ee48df7f33a3aeb1798bf5852be8c6d26a7db7fd/addons/account/models/account_payment_term.py#L262-L264 We can resolve this issue by adding an additional check of invoice_date, Which makes the code more robust. sentry-6149404219
A test in the Brazilian electronic invoicing area was corrected to match the current default email behavior. This helps keep automated checks reliable and reduces false failures during maintenance.
Original PR description
task-4478365
Italian point-of-sale receipts sent to fiscal printers now calculate payment totals correctly when customers receive change. This prevents change amounts from being counted as an additional payment, helping ensure fiscal documents match the actual sale.
Original PR description
The issue was that payment lines with `is_change` were also being considered in the computation.
Exemple:
Product: 14.50
Payment: 20.00
Change: 5.50This fixes an unreliable automated test in Web Studio that could fail when all apps were installed. The change makes the test steps more precise, helping reduce false failures and keeping validation of updates more stable.
Original PR description
runbot-error-108304