Odoo Changelog — 2025-02-07

Friday, February 7, 2025

51 changes · saas-18.1

Improvements(2)

Enhancements to existing features

[IMP] html_editor: move existing text inside banner

Coresaas-18.1html_editor

When users create a banner next to existing text, the editor now moves that text into the new banner instead of placing the banner after it. This makes page editing more intuitive and reduces extra cleanup when formatting existing content.

Original PR description

**Current behavior before PR:**

- Creating a banner besides existing text will creates the banner after the current text block.

**Desired behavior after PR is merged:**

- Now, creating a banner besides existing text will move the current text block inside the newly created banner.

task: 4214029

#editor#banner#content editing

[IMP] sale_subscription: don't create the invoice in portal controller

PR #77432

Enterprisesaas-18.1sale_subscriptionsale_subscription_external_tax

Subscription payments made through the customer portal now rely on the standard payment follow-up process to create invoices instead of creating draft invoices earlier in the portal step. This reduces duplicated logic and lowers the risk of inconsistent invoice handling for subscription renewals.

Original PR description

Before this commit, the /my/subscriptions/<int:order_id>/transaction route would create a draft invoice when it was called to anticipate a payment. post processing of payment.transaction is able to create the invoice and to associate it with the correct sale.order.

In order to simplify the code by limiting the part of the code where subscription invoices can be created, we decided to let the _post_process do the work.

taskid: 4368037

#subscriptions#invoicing#portal#payments

Bug Fixes(2)

Resolved issues and error corrections

[FIX] {*}_edi_pos: add async in toggleIsToInvoice function

PR #78507

Enterprisesaas-18.1l10n_cl_edi_posl10n_mx_edi_pos

This update ensures the point-of-sale invoice toggle works reliably for Chilean and Mexican electronic invoicing. It helps prevent timing issues during payment that could affect whether an order is correctly marked for invoicing.

Original PR description

*: l10_cl, l10_mx

In this commit:
===
- The main toggleIsToInvoice function is async, so added async and await where necessary to ensure proper execution.

related-https://github.com/odoo/odoo/pull/195378
task-4517944

#point-of-sale#invoicing#localization

Other(47)

Miscellaneous changes

[FW][FIX] html_editor: convert xml self-closing elements to html

PR #196864

Coresaas-18.1html_editor

Original PR description

HTML content is often saved as XML (i.e. through templates) and saved as such in the database. This introduces issues when elements are written under their `self-closing` format (i.e. `<a/>` or…

HTML content is often saved as XML (i.e. through templates) and saved as such in the database. This introduces issues when elements are written under their `self-closing` format (i.e. `<a/>` or `<br/>`) as browsers will incorrectly parse these values as HTML by adding a closing tag at an arbitrary position which may modify the initial nodes configuration. This can be prevented by post-processing untrusted content before the html parsing.

This commit is an overhaul of:
https://github.com/odoo/odoo/commit/26b922ef5cad42da7e188195e919e54878d472fc https://github.com/odoo/odoo/commit/1a8a943d8373864165cb513b3767b866d626fad8 https://github.com/odoo/odoo/commit/4e547b24a323f8e59a11c5b78cbea38effc37938

in order to apply the conversion at critical entry points for editor assets:
- HtmlField is an entry point for data coming from the server, stored on the record. Every access of the record data should not be trusted and go through the post-processing.

- HtmlViewer is an entry point as it can be used as a standalone (see `website_knowledge`, or the HistoryDialog) for data coming from the server.

- Editor is an entry point as it was developed to be useable as a standalone.

task-4547973

Forward-Port-Of: odoo/odoo#196442

**Current behavior before PR:** - Creating a banner besides existing text will creates the banner after the current text block. **Desired behavior after PR is merged:** - Now, creating a banner besides existing text will move the current text block inside the newly created banner. task: 4214029

Before this commit, the /my/subscriptions/<int:order_id>/transaction route would create a draft invoice when it was called to anticipate a payment. post processing of payment.transaction is able to create the invoice and to associate it with the correct sale.order. In order to simplify the code by limiting the part of the code where subscription invoices can be created, we decided to let the _post_process do the work. taskid: 4368037

*: l10_cl, l10_mx In this commit: === - The main toggleIsToInvoice function is async, so added async and await where necessary to ensure proper execution. related-https://github.com/odoo/odoo/pull/195378 task-4517944

HTML content is often saved as XML (i.e. through templates) and saved as such in the database. This introduces issues when elements are written under their `self-closing` format (i.e. `<a/>` or `<br/>`) as browsers will incorrectly parse these values as HTML by adding a closing tag at an arbitrary position which may modify the initial nodes configuration. This can be prevented by post-processing untrusted content before the html parsing. This commit is an overhaul of: https://github.com/odoo/odoo/commit/26b922ef5cad42da7e188195e919e54878d472fc https://github.com/odoo/odoo/commit/1a8a943d8373864165cb513b3767b866d626fad8 https://github.com/odoo/odoo/commit/4e547b24a323f8e59a11c5b78cbea38effc37938 in order to apply the conversion at critical entry points for editor assets: - HtmlField is an entry point for data coming from the server, stored on the record. Every access of the record data should not be trusted and go through the post-processing. - HtmlViewer is an entry point as it can be used as a standalone (see `website_knowledge`, or the HistoryDialog) for data coming from the server. - Editor is an entry point as it was developed to be useable as a standalone. task-4547973 Forward-Port-Of: odoo/odoo#196442

Versions -------- - saas-17.4+ Steps ----- 1. Go eCommerce products page; 2. click on a product; 3. use browser's "Go back" button to go back. Issue ----- There's no going back. Cause ----- PR https://github.com/odoo/odoo/pull/157412 modified the `_setUrlHash` method used to manage product attributes. One of the changes it made is modified the current URL using `window.location.hash` instead of `window.location.replace`. While both methods can make identical changes to the URL, a key side-effect of `Location:replace()` is that the URL being replaced won't get saved in the session's `History`[^1]. As this method is called the moment the page loads, modifying the URL via `location.hash` will store the initial product page URL without attribute hashes in the session history. Then when trying to navigate back, the method will be called again immediately to apply attribute hashes, again modifying the session history, making it virtually impossible to leave the page without clicking a new URL. Solution -------- Use `history.replaceState`[^2] to update the current state, and not create any new entries. Also re-introduce early return when there are no product attributes to avoid polluting URLs, originally added in https://github.com/odoo/odoo/pull/159474 but removed via https://github.com/odoo/odoo/pull/157412. opw-4416701 [^1]: https://developer.mozilla.org/en-US/docs/Web/API/Location/replace [^2]: https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState Forward-Port-Of: odoo/odoo#196858 Forward-Port-Of: odoo/odoo#194712

### Issue: Curently, the reservation state of a production is computed from the status of the move raws that are not picked. This includes moves wihtout demands which should not infer with the reservation state at all. ### Steps to reproduce: - In the settings, Enable "Multi-Step Routes" - Go to Inventory > Configuration > Warehouse Management > Warehouses - Put your warehouse in 2 steps-manufacturing - Create a final product (FP) tracked by Serial number, and 2 storable components: COMP1 and COMP2 - Create a BOM for FP: - Component lines: - 1 x COMP1 - 0 x COMP2 !! - Operations: - OP1 with an instruction of type "register production" 1. Create an MO for 1 x FP > Confirm 2. Validate the pick transfer for 1 unit of COMP1 > Currently OP1 is marked as ready 3. Mark the component line of COMP1 as "picked" #### > OP1 is in waiting status Same result as 3: 3'. Go to the shopfloor > register production from the MO card #### > This will pick the COMP1 raw move and OP1 will disappear because of the "ready" filter ### Cause of the issue: Since you manufacture in 2 steps, the state of the raw move of COMP2 is waiting even though its demand is 0 (before and after you validated the pick move for COMP1). However, only non picked moves are considered to be relevant in the computation of the reservation state of the MO: https://github.com/odoo/odoo/blob/d8fc04f5875dbd3098e58f382d0cea3c7c7c38af/addons/mrp/models/mrp_production.py#L613-L621 Once you pick the COMP1 move which should be the only relevant one the reservation state of the MO becomes computed solely based on the state of the COMP2 raw move and becomes "waiting". In turns, this triggers a recomputation of the state of the workorders and flagging it as waiting: https://github.com/odoo/odoo/blob/d8fc04f5875dbd3098e58f382d0cea3c7c7c38af/addons/mrp/models/mrp_workorder.py#L148-L165 opw-4383004 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#196517 Forward-Port-Of: odoo/odoo#196388

### Steps to reproduce: - In the settings enable: Multi-Step Routes, Operations > Packages - Create a storable prodcut - Update the on hand quantity: - 10 units in package PK - Inventory > Configuration > Warehouse Management > Locations - Create 2 warehouse locations: WH/LOC1, WH/LOC2 - Go to the barcode app and proceed with the scans: 1. Scan the internal transfer picking type 2. Scan WH/STOCK as a source location 3. Scan the package name (PK) 4. Scan WH/LOC1 as destination location - Leave the barcode app without validation - Go to the barcode app and proceed with the scans: i -> iii, iv'. Scan WH/LOC2 as destination location - Try to validate the picking #### > Invalid operation: You cannot move the same package content more than once in the same transfer or split the same package into two location. ### Cause of the issue: As both pickings were treated via the barcode app, they generated picked move lines related to the package. Both of these move lines have updated the reserved quantity of the stock.quant present in stock: - WH/STOCK, quantity: 10, reserved_quantity: 20. When you try to validate the second picking, you will launch an `_action_done` of its move line that will create a new quant in WH/LOC2 and update the quant in stock: - WH/STOCK, quantity: 0, reserved_quantity: 10. - WH/LOC2, quantity: 10, reserved_quantity: 0. The error is raised just after since 2 quants with either a quantity or reserved quantity are found: https://github.com/odoo/odoo/blob/6349fb0362d881672616bb4b800bd32be82f9a5f/addons/stock/models/stock_move.py#L1910-L1917 ### Fix: Since the check is made in order to check the consistency of result packages moved by the current validation the "reserved_quantity" should not matter. opw-4456484 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#193214

**Current behavior:** With a FIFO + real-time product, `ProductA`: Creating a sale order with multiple order lines for ProductA, processing the resulting delivery in 2 separate pickings via backorder (1st delivery for the 1st line, 2nd delivery for the 2nd line), then invoicing the delivered product separately result in an invoice with invoice lines which do not reflect the value of the product at delivery time. **Expected behavior:** The SVLs generated from the deliveries should inform the generated AccountMoves. **Steps to reproduce:** 1. `FIFO-prod`: FIFO and real-time valuation & costing 2. Receive 12 units of `FIFO-prod` @ $100 per 3. Create a sale order with order lines: * `FIFO-prod` `10 units` `price_unit=$100` * `FIFO-prod` `2 units` `price_unit=$100` 4. Confirm the sale order, on the delivery, only receive the first move for the 10 qty, backorder the other 2 qty 5. Receive the backorder, create an invoice- edit the invoice lines so that 5/10 of line 1 and 2/2 of line 2 are invoiced, then post/confirm 6. Edit the `standard_price` of `FIFO-prod` (e.g., $100 -> $50) 7. Create another invoice for the remaining quantity and post 8. Observe that the COGs lines on the invoice have been calculated with a different price unit than the other invoice & unit_price for the out SVLs **Cause of the issue:** When getting the price unit of a given anglo saxon invoice line, there is no check that all the collected COGS lines are linked to the sale order line which corresponds to the product and product_qty that we are attempting to value. This creates an imbalance in the qty calculation later here: https://github.com/odoo/odoo/blob/f2728b2fe13a355ecb301a3714639b8a07f418b4/addons/stock_account/models/stock_valuation_layer.py#L202-L211 when the valuation is actually performed. **Fix:** Only consider posted COGS lines for the sale order line with the product qty that is getting valued when calculating `qty_invoiced`. opw-4321363 Forward-Port-Of: odoo/odoo#196067 Forward-Port-Of: odoo/odoo#195046

Description of the issue/feature this PR addresses: This PR is to fix an issue encountered when copying information from an editor for a product for example, and pasting it on the product label. On Odoo the label was appearing fine but when the invoice was confirmed and sent, the XML file content is created with hidden characters.This produced the web service to return an error when trying to validate the electronic invoice. Current behavior before PR: Special or hidden characters appear on the XML file of an electronic invoice. Steps to reproduce: 1. Install Uruguay - Electronic Invoice module 2. Create EDI invoice, add special character to the description of the product you are using. Example used for testing (copy-paste it): ‭219179120011‬ 3. Validate the invoice 4. Print and send it 5. Check "DscItem" field on the XML file created. Here is a one minute [video](https://drive.google.com/file/d/18JcnKCbaq7cH_NVyPol4CWXHdqZAxAdo/view) reproducing the error on runbot. Desired behavior after PR is merged: These characters are cleaned up at the xml level on cleanup_xml_node method to avoid them to appear and prevent errors when validating the XML on localizations web services. Related PR on v16 regarding the same issue in another context: https://github.com/odoo/odoo/pull/154509 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#193047

**Current behavior:** When a user wants to upload its VAT return to the French Government, they receive the following error message: ``` report_line_code = report_lines_code_per_id[report_line_id] ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ KeyError: None ``` **Expected behavior:** The user should be able to upload their VAT return without any error message. **Steps to reproduce:** 1. Create a French company, using French Accounting. (`l10n_fr_reports`, `l10n_fr_account`). 2. In the Settings, activate the Analytics option "Add totals below sections". 3. Go to Tax reports > Actions > EDI TVA > Send Report **Cause of the issue:** When the "Add totals below sections" parameter is enabled, the system will add new total lines on the report for each group of report lines. In the case of the Standard French VAT report, a single total line is added. The issue is that before sending the report, the values are formatted by `_get_formatted_edi_values`. Each line to format is mapped to its corresponding line ID in line [255](https://github.com/odoo/enterprise/blob/0c32410b50b0edc2bc68c3199f741756b49600a2/l10n_fr_reports/wizard/l10n_fr_send_vat_report.py#L255): `report_line_id = self.report_id._get_model_info_from_id(line['id'])[-1]` Alas, for the new total lines, the line ID and its corresponding model are both None, which leads to an error on the next line. In version 17.0, there was a check for the model of the line, which was removed in version 18.0. **Fix:** - Add a check on the model of the line before formatting its values, to prevent the total lines from being formatted and sent. opw-4496692 Forward-Port-Of: odoo/enterprise#77964

This PR aims to prevent showing outdated error messages on an uruguayan electronic invoice that has already been amended. When a user creates a CFE invoice with invalid information (for example, the unit price of the product detailed in the invoice is equal to 0.0), the webservice returns an error that is captured on Odoo and shown as a pop-up and added as a banner on the move header. If the user resets the move to draft, corrects the error and for some reason introduces another one (like leaving the "tax" column empty), then confirm and send the invoice again to DGI, a new pop up is raised showing a new error message accordingly but the banner of the header remains showing the same error as before (saying the product unit price is 0). This leads to confusion about what is the current error to be amended to properly send the invoice to DGI. Steps to reproduce the error: - Create an uruguayan electronic invoice on a testing enviroment. - Select a product and change its unit price to 0. - Try to send & print the invoice, creating the CFE. - An error like this will be shown: ![image](https://github.com/user-attachments/assets/224a3755-06a4-4c6a-a77f-66cc988719a4) - Go back to the move and check that a banner with the error has been added at the top. ![image](https://github.com/user-attachments/assets/e79877ca-073a-48ab-90cd-4b91f96be89a) - Reset to draft, add a valid unit price and delete the "Taxes" column value. - Confirm, Send&Print the invoice. - A new pop up like this should raise: ![image](https://github.com/user-attachments/assets/72551e4b-8392-4ea3-8e99-43d84b478a9b) - Go back to the invoice and check that the banner remains as before, showing an outdated error message. Forward-Port-Of: odoo/enterprise#77710

Improvements(2)

[IMP] html_editor: move existing text inside banner

[IMP] sale_subscription: don't create the invoice in portal controller

Bug Fixes(2)

[FIX] {*}_edi_pos: add async in toggleIsToInvoice function

Other(47)

[FW][FIX] html_editor: convert xml self-closing elements to html

Improvements(2)

[IMP] html_editor: move existing text inside banner

[IMP] sale_subscription: don't create the invoice in portal controller

Bug Fixes(2)

[FIX] {*}_edi_pos: add async in toggleIsToInvoice function

Other(47)

[FW][FIX] html_editor: convert xml self-closing elements to html

[FIX] account_reports: fix caret builder

[FW][FIX] website_sale: allow browser history navigation on product pages

[FW][ADD] sale_gelato: integrate with Gelato for Print-On-Demand

[FW][FIX] point_of_sale: loading ticket screen

[FW][FIX] mrp: fix test_workcenter_with_resource_calendar_from_another_compa

[FW][FIX] point_of_sale, pos_settle_due: prevent creation of empty orders

[I18N] *: re-export pot files

[FW][FIX] point_of_sale, pos_self_order: undefined channel name

[FW][FIX] pos_restaurant: fix error runbot 111972

[FW][CLA] Sign for letzdoo

[FW][FIX] mrp{,_workorder}: ignore move raws without demand in reservation state

[FW][IMP] payment: disable post-processing cron when no provider enabled

[FW][IMP] delivery: update `hs_code` field help text and pot files

[FW][FIX] l10n_latam_invoice_document: allow user to create a CN in a journal different than the move

[FW][FIX] l10n_fr_account: exclude custom bics from getting xmlid

[FW][FIX] accounting: Setting reconcile false for Bank and Cash type accounts explicitly.

[FW][FIX] account: validate entire structured reference

[FW][FIX] stock: allow picking validation of already reserved package

[FW][FIX] sale_stock: use only SOL linked COGS lines to get price unit

[FW][FIX] odoo/tools: error processing Factur-X XML

[FW][FIX] l10n_ar: fix Qweb overrides between AR and AE

[FW][FIX] point_of_sale: debounce product stock fetch

[FW][FIX] point_of_sale: prevent error when loading product suppliers

[FW][FIX] knowledge: convert xml self-closing elements to html

[FW][FIX] account_reports: Fix weird indentation

[FW][FIX] l10n_ke_hr_payroll_account: set journal on struct for demo

[FW][FIX] l10n_be_reports_post_wizard: noupdate of fps bank account

[FW][FIX] documents: fix list and kanban range selection

[FW][FIX] project_account_budget: fix the issue of budget domain

[FW][FIX] sale_subscription_stock: pass `previous_product_uom_qty` as kwarg

[FW][FIX] helpdesk_stock: Split by partner for suitable products

[FW][FIX] l10n_fr_reports: prevent traceback when sending VAT return with totals

[FW][FIX] point_of_sale, pos_settle_due: prevent creation of empty orders

[I18N] *: re-export pot files

[FW][FIX] account_intrastat: Load more traceback

[FW][FIX] knowledge: resolve custom menu view insert

[FW][FIX] whatsapp_*: Don't forcecreate whatsapp templates

[FW][FIX] sale_stock_renting: delivered quantity not updating for sales product

[FW][ADD] delivery_usps_rest: USPS integration using new REST API

[FW][FIX] l10n_uy_edi: clear error msg to prevent showing outdated information

[FW][FIX] account_online_synchronization: Avoid using recordset to call model function

[FW][FIX] test_l10n_be_hr_payroll_account: broken tour

[FW][FIX] hr_payroll_expense: Fix report in next payslip access

[FW][FIX] account_winbooks_import: fix account types mapping

[FW][FIX] l10n_ec_edi: enable subtotals in withholdings

[FW][FIX] l10n_uy_edi: prevent hidden or special chars to appear on pdf reports

[FW][FIX] planning: undo auto plan shifts should reset highlighted shifts