Friday, February 7, 2025
5 changes · saas-18.1
Resolved issues and error corrections
This fix ensures the Indian Point of Sale flow checks the latest company state information from the server. Businesses avoid unnecessary redirects to company settings when closing sessions after the state has already been added.
Original PR description
Before this commit: === - If the company had no state set, attempting to close the POS session would trigger a company state dialog, redirecting to the company settings page. - After adding the state and reopening the session, the same dialog would appear again, despite the state being present. After this commit: === - The system correctly fetches the company state from the backend, preventing unnecessary redirections. related-https://github.com/odoo/enterprise/pull/78507 task-4517944
Fixed an accounting issue that could block users from creating vendor bills when receivable or payable accounts had reconciliation enabled. This improves reliability for accounting teams working with draft bills and customized charts of accounts.
Original PR description
This error occurs when the user tries to create a new vendor bill with a `Chart of Account` having type as `receivable` or `payable` `when Allow Reconciliation` enabled. Steps to reproduce: - Install the `accountant` module. - Create a new vendor bill record from accounting/vendor - Create a new journal item with the type of `asset_receivable` or `liability_payable`. - Check that `Allow Reconciliation` must be enabled. --- Error: `SyntaxError: WHERE part.debit_move_id IN ()` This error occurs because code refactors with commit [1] allow compute to reconcile the bank account in a draft move but since the move/line is not saved it returns as virtual_id and it causes an error. This commit will fix the above issue by checking whether the reconciled contains ids or not, if it does not contain an ids it returns an empty dictionary. [1] - https://github.com/odoo/odoo/commit/52903687e136bd3327409aedbda568b60b3428c3 Sentry - 6250883109
Restaurant point-of-sale users can now merge floating orders without triggering an error when the order is not linked to a table. After choosing an existing floating order to merge into, the screen also switches to that order so staff can continue working smoothly.
Original PR description
Fix issue generating traceback where when merging floating orders together. As `mergeOrders` can be used with floating orders, it doesn't necessarily contain a table. A check has been added to handle this case properly. After selecting an order to merge with, we now also redirect to this order. Steps to reproduce: - Create new floating order - Add items to the cart - Click "Set Tab" - Select existing floating orders task-id: 4551788 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a Point of Sale issue where scanning a product barcode placed the code in the search field instead of adding the product to the order. Cashiers can scan items normally again, reducing checkout errors and delays.
Original PR description
Currently, when scanning a product barcode, the barcode is entered in the search bar instead of the product being added to the order. Steps to reproduce: ------------------- * Select a product and…
Currently, when scanning a product barcode, the barcode is entered in the search bar instead of the product being added to the order. Steps to reproduce: ------------------- * Select a product and enter a barcode * Open pos shop * Scan the barcode. **Warning** this needs to be done with a real scanner and not the debug window > Observation: barcode is entered in the search bar and the product is not added to the order. Why the fix: ------------ This behavior was introduced after the addition of the auto focus on the search input when typing: https://github.com/odoo/odoo/commit/39ee805ac4ea75b55de0efd76fb5cd5fdae11b50 A barcode is a succession of event (ex; (shift, 0, shift, 9, ...), (0, 9, ...), ...) that depends of the language used. They still have in common the number being pressed. The first time a number is pressed, the following condition is `true` making the overall condition true as well: https://github.com/odoo/odoo/blob/9a6c0bcbb3d028a678a3162af8208b474e01dc29/addons/point_of_sale/static/src/app/components/navbar/navbar.js#L64 And now the focus element is put on the search bar which explains why the barcode is added there. We now use the same setup as the barcode service https://github.com/odoo/odoo/blob/db47f0e04fd8df276e93e19f27fa6bc655e609c6/addons/barcodes/static/src/barcode_service.js#L100-L105 We add the timeout on event. Each key is added to a buffer. Once the timeout is over, if the buffer has at least 2 character we consider it is a barcode and don't focus on the search bar. We stay consistent with the barcode service https://github.com/odoo/odoo/blob/db47f0e04fd8df276e93e19f27fa6bc655e609c6/addons/barcodes/static/src/barcode_service.js#L55 We slightly modify the barcode service code so that, if we are already focused on the search bar we don't need to start the timeout. This allows people who type really fast to have all events registered directly. opw-4511255
This fix prevents an error that could stop users from connecting a bank account for online synchronization. The bank setup flow now sends the required account type information, allowing the connection process to continue as expected.
Original PR description
Currently, an exception is generated while connecting to the bank. Error:- ``` TypeError: AccountOnlineLink.create_new_bank_account_action() missing 1 required positional argument: 'journal_type' ``` This is because of the latest changes were added from the below commit. https://github.com/odoo/enterprise/pull/70591/files#diff-72ccf5e061185b2d649fb844db777d7e229c31c38e1dc68283984a0772b481bfR384 A new argument `journal_type` was added in the `create_new_bank_account_action` method. But forget pass that required argument in the ORM call in below lines. https://github.com/odoo/enterprise/blob/b588877a12f4952d02c747b230065c5b52f21e1a/account_online_synchronization/static/src/components/bank_configure/bank_configure.js#L68-L72 This leads to the above traceback. sentry-6248235685