Odoo Changelog — 2025-02-10

Monday, February 10, 2025

27 changes · saas-17.2

Bug Fixes(8)

Resolved issues and error corrections

[IMP] sale_subscription: force flush before and after SO confirmation

Enterprisesaas-17.2sale_subscription

Subscription sales orders now create the expected history log even when an order is created and confirmed in the same background transaction. This improves subscription tracking accuracy for automated processes and integrations, with no expected change to normal UI workflows.

Original PR description

Before this commit, sale.order.log were not created when the SO was created and confirmed in the same transaction. _Mail_track was not called and therefore the result was identical as if the SO was directly created in the progress subscription state. As no subscription_state update was detected, the log could not be created.

This issue does not happens in the UI but it could be observed with odoo shell:

before this commit:
```
In [1]: a = self.env['sale.order'].create({'partner_id': 1, 'user_id': 1, 'subscription_state': '1_draft', 'sale_order_template_id': 2, })
In [2]: a._onchange_sale_order_template_id()
In [3]: a.action_confirm()
Out[3]: True
In [4]: a.order_log_ids
Out[4]: sale.order.log()
```

After:

```
In [1]: a = self.env['sale.order'].create({'partner_id': 1, 'user_id': 1, 'subscription_state': '1_draft', 'sale_order_template_id': 2, })
In [2]: a._onchange_sale_order_template_id()
In [3]: a.action_confirm()
Out[3]: True
In [4]: a.order_log_ids
Out[4]: sale.order.log(384,)
```

#subscriptions#sales orders#logging#automation

[FIX] room: only send presences to interested users

PR #68022

Enterprisesaas-17.2room

This fix ensures room booking presence updates are only sent after the system is properly ready to receive them. It prevents background timing errors that could affect automated checks and helps keep the room booking feature stable.

Original PR description

In the community counterpart of this PR, a debounce is added to the addition of bus channels in order to batch them as much as possible.

The room module uses the `waitForSubscribe` bus helper but never awaits it which trigger errors in other tests.

This PR fixes this issue.

community: https://github.com/odoo/odoo/pull/175463

#room booking#presence#stability

[FIX] mass_mialing: sync sidebar height with the event template `iframe`

PR #186564

Coresaas-17.2mass_mailing

This fixes a display issue in the mass mailing editor where the snippet sidebar could slide under the control panel when using the Event Promo template at higher browser zoom levels. The sidebar now adjusts to the template height while scrolling, keeping the editor controls visible and easier to use.

Original PR description

How to reproduce:
1. create a new mailing.
2. from the existing available Mail Body templates, select Event Promo.
3. zoom In to around 125% or greater scale.
4. scroll the page to the end.

Issue:
5. as you scroll, you will notice the snippet sidebar stays sticky till a certain point, but as we reach the end of the template itself, and the page starts to scroll, the sidebar goes under the control panel.

video of the issue --> https://www.awesomescreenshot.com/video/33360044?key=46734c8ba59b1144830c3939e24ed12f

Reason:
7. in previous version (i.e. 17.0) the sidebar's top and bottom was dynamically controlled on every scroll.
refer --- https://github.com/odoo/odoo/blob/17.0/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js#L91-L96

8. we use `position: sticky` in the current version to achieve that outcome, but when the template itself starts to scroll, the stickiness disappears.

Fix:
9. once the page has started scrolling we recalculate the height of the sidebar to match it with the height of the template.

Task-4137980

[FIX] mass_mailing: prevent snippet from overlapping with the sidebar

PR #184504

Coresaas-17.2mass_mailing

Fixed a display issue in mass mailing templates where the editing sidebar could overlap the email content after returning to a template. This makes template editing more reliable and prevents layout confusion for users.

Original PR description

Previously, the has_snippets_sidebar class was only applied when clicking the template during creation. Now, the fix ensures that the class is correctly applied on load, preventing the body from overlapping with the sidebar when returning to the template.

Task-4266339

#email marketing#templates#sidebar#layout

[FIX] spreadsheet: invalid pivot error message

PR #158079

Coresaas-17.2spreadsheet

Spreadsheet pivot formulas now show the available measures when a user enters an invalid measure. This helps users correct mistakes faster and reduces confusion when working with pivot reports.

Original PR description

Before this commit, applying a pivot formula with an invalid measure returns an error message without
showing possible measures.
This commit fixed that

Task 3754942





---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#spreadsheet#pivot#error message

[FIX] l10n_es_edi_facturae: only show FACe section on invoice for ES companies

PR #196212

Coresaas-17.2l10n_es_edi_facturae

The FACe/Factura-e section on invoices now appears only when the related company is located in Spain. This avoids showing Spain-specific electronic invoicing fields to companies in other countries, reducing confusion for users.

Original PR description

We should show the FACe/Factura-e section on invoice when the related company is located in Spain.

opw-4397651

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#invoicing#Spain#Factura-e#FACe

[FIX] account: outbound shouldnt require validated bank account

PR #195312

Coresaas-17.2account

This fixes a payment validation issue where incoming payments could be blocked by a requirement intended for outgoing payments. It helps avoid confusion and supports payment methods such as Italian RiBa that need a bank account for incoming money without treating it as an outgoing payment.

Original PR description

The `require_partner_bank_account` flag on the payment shouldn't require the `allow_out_payment` flag on it when the payment type is `inbound` as it leads to confusion.

This generates an issue with the `l10n_it_riba` RiBa payment method. It requires the bank account, but the money is incoming, not outgoing.

Enterprise PR: odoo/enterprise#77901

Task [link](https://www.odoo.com/odoo/project/967/tasks/4497749)
task-4497749

#payments#bank-account#riba

[FIX] account: avoid ORM hacks (2)

PR #197120

Coresaas-17.2account

This fix improves how invoice changes are protected from unintended automatic recalculations during updates. It helps keep accounting data consistent when invoices or invoice lines are created or modified.

Original PR description

Missing commit from the forward-port of https://github.com/odoo/odoo/pull/193528

#accounting#invoices#reliability

Other(19)

Miscellaneous changes

[FW][IMP] mrp_workorder: batch creation of quality checks

PR #77601

Enterprisesaas-17.2

Original PR description

During the creation of quality checks a potentially useless `search` was performed. With this commit, we will perform (indirectly) the search only if needed When method `_create_checks` is called,…

During the creation of quality checks a potentially useless `search` was performed. With this commit, we will perform (indirectly) the search only if needed

When method `_create_checks` is called, `quality.check` records are created one at the time. This can become slow wh
en a lot of checks are created at once (ex: Bill of Material defined with steps "manual consumption" and used in a manufacturing order).

Script used for tests:
https://gist.github.com/emi-odoo/d4c6271363dfc3f2e4b7c5efabfed5c1

Before: 3.51s (`_create_checks`) - 17493 queries (total queries of the script, not for the single operation)
![image](https://github.com/odoo/enterprise/assets/70145331/3e484a2a-009b-4328-8ecc-3613e74b3378)


After: 2.08s (`_create_checks`)  - 16103 queries (total queries of the script, not for the single operation)
![image](https://github.com/odoo/enterprise/assets/70145331/c7714bf6-a655-4e83-ad25-dd90276ed1a2)

Comparison of the time taken by Confirming the MRP Order (using `time.process_time()`)

| n_components | before (s) | after (s) | ratio |
| --- | --- | --- | --- |
| 1 | 0.074 | 0.073 | 0.988 |
| 5 | 0.134 | 0.140 | 1.042 |
| 10 | 0.216 | 0.187 | 0.862 |
| 20 | 0.334 | 0.304 | 0.908 |
| 50 | 0.736 | 0.600 | 0.816 |
| 100 | 1.378 | 1.172 | 0.851 |
| 200 | 2.739 | 2.374 | 0.867 |

Forward-Port-Of: odoo/enterprise#66224
Forward-Port-Of: odoo/enterprise#65725

Before this commit, sale.order.log were not created when the SO was created and confirmed in the same transaction. _Mail_track was not called and therefore the result was identical as if the SO was directly created in the progress subscription state. As no subscription_state update was detected, the log could not be created. This issue does not happens in the UI but it could be observed with odoo shell: before this commit: ``` In [1]: a = self.env['sale.order'].create({'partner_id': 1, 'user_id': 1, 'subscription_state': '1_draft', 'sale_order_template_id': 2, }) In [2]: a._onchange_sale_order_template_id() In [3]: a.action_confirm() Out[3]: True In [4]: a.order_log_ids Out[4]: sale.order.log() ``` After: ``` In [1]: a = self.env['sale.order'].create({'partner_id': 1, 'user_id': 1, 'subscription_state': '1_draft', 'sale_order_template_id': 2, }) In [2]: a._onchange_sale_order_template_id() In [3]: a.action_confirm() Out[3]: True In [4]: a.order_log_ids Out[4]: sale.order.log(384,) ```

In the community counterpart of this PR, a debounce is added to the addition of bus channels in order to batch them as much as possible. The room module uses the `waitForSubscribe` bus helper but never awaits it which trigger errors in other tests. This PR fixes this issue. community: https://github.com/odoo/odoo/pull/175463

How to reproduce: 1. create a new mailing. 2. from the existing available Mail Body templates, select Event Promo. 3. zoom In to around 125% or greater scale. 4. scroll the page to the end. Issue: 5. as you scroll, you will notice the snippet sidebar stays sticky till a certain point, but as we reach the end of the template itself, and the page starts to scroll, the sidebar goes under the control panel. video of the issue --> https://www.awesomescreenshot.com/video/33360044?key=46734c8ba59b1144830c3939e24ed12f Reason: 7. in previous version (i.e. 17.0) the sidebar's top and bottom was dynamically controlled on every scroll. refer --- https://github.com/odoo/odoo/blob/17.0/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js#L91-L96 8. we use `position: sticky` in the current version to achieve that outcome, but when the template itself starts to scroll, the stickiness disappears. Fix: 9. once the page has started scrolling we recalculate the height of the sidebar to match it with the height of the template. Task-4137980

Previously, the has_snippets_sidebar class was only applied when clicking the template during creation. Now, the fix ensures that the class is correctly applied on load, preventing the body from overlapping with the sidebar when returning to the template. Task-4266339

Before this commit, applying a pivot formula with an invalid measure returns an error message without showing possible measures. This commit fixed that Task 3754942 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

We should show the FACe/Factura-e section on invoice when the related company is located in Spain. opw-4397651 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The `require_partner_bank_account` flag on the payment shouldn't require the `allow_out_payment` flag on it when the payment type is `inbound` as it leads to confusion. This generates an issue with the `l10n_it_riba` RiBa payment method. It requires the bank account, but the money is incoming, not outgoing. Enterprise PR: odoo/enterprise#77901 Task [link](https://www.odoo.com/odoo/project/967/tasks/4497749) task-4497749

During the creation of quality checks a potentially useless `search` was performed. With this commit, we will perform (indirectly) the search only if needed When method `_create_checks` is called, `quality.check` records are created one at the time. This can become slow wh en a lot of checks are created at once (ex: Bill of Material defined with steps "manual consumption" and used in a manufacturing order). Script used for tests: https://gist.github.com/emi-odoo/d4c6271363dfc3f2e4b7c5efabfed5c1 Before: 3.51s (`_create_checks`) - 17493 queries (total queries of the script, not for the single operation) ![image](https://github.com/odoo/enterprise/assets/70145331/3e484a2a-009b-4328-8ecc-3613e74b3378) After: 2.08s (`_create_checks`) - 16103 queries (total queries of the script, not for the single operation) ![image](https://github.com/odoo/enterprise/assets/70145331/c7714bf6-a655-4e83-ad25-dd90276ed1a2) Comparison of the time taken by Confirming the MRP Order (using `time.process_time()`) | n_components | before (s) | after (s) | ratio | | --- | --- | --- | --- | | 1 | 0.074 | 0.073 | 0.988 | | 5 | 0.134 | 0.140 | 1.042 | | 10 | 0.216 | 0.187 | 0.862 | | 20 | 0.334 | 0.304 | 0.908 | | 50 | 0.736 | 0.600 | 0.816 | | 100 | 1.378 | 1.172 | 0.851 | | 200 | 2.739 | 2.374 | 0.867 | Forward-Port-Of: odoo/enterprise#66224 Forward-Port-Of: odoo/enterprise#65725

### Steps to reproduce: - Create a storable product FP tracked by SN with a BOM: - 1 Operation: - instruction: Register Production type (per product) - 1 x Comp (storable product in stock) - Create and confirm an MO for one unit of FP. - Go to the shopfoor app > open the instruction of your operation - Type a non-existing serial number in the search bar > Create "new_sn" > This opens a form view of the stock.lot model - Save and close the new stock.lot > Invalid operation: You are not allowed to create or edit a lot or serial number for the components with the operation type > "Manufacturing". To change this, go on the operation type and tick the box "Create New Lots/Serial Numbers for > Components" #### Expected behavior: The invalid operation should not be raised as the "required" option concerns only componenets and not final products. ### Cause of the issue: Creating a stock lot will first launch a call of the `_check_create`: https://github.com/odoo/odoo/blob/c25d71f14fa168807f07cd88bed805d15db8add5/addons/stock/models/stock_lot.py#L150-L153 However, since this check does not verifies that the product for which we create the lot is indeed related to a component of the MO it will raise the invalid operation even for final products: https://github.com/odoo/odoo/blob/c25d71f14fa168807f07cd88bed805d15db8add5/addons/mrp/models/stock_lot.py#L11-L17 ### Issue 2: Currently, the `quickCreate` ("Create *sn_name*") option of the lot field of te "register production" dialog calls a `name_create` that will set an error message in the logs as the product_id required field can not be provided neither in the vals or the context of the `name_create`. You then fall back on the same form dialog than the "Create and edit". The `quickCreate` option should therefore just be disabled. Community: https://github.com/odoo/odoo/pull/193965 opw-4452747 --- Forward-Port-Of: odoo/enterprise#77265

### Steps to reproduce: - Create a storable product FP tracked by SN with a BOM: - 1 Operation: - instruction: Register Production type (per product) - 1 x Comp (storable product in stock) - Create and confirm an MO for one unit of FP. - Go to the shopfoor app > open the instruction of your operation - Type a non-existing serial number in the search bar > Create "new_sn" > This opens a form view of the stock.lot model - Save and close the new stock.lot > Invalid operation: You are not allowed to create or edit a lot or serial number for the components with the operation type > "Manufacturing". To change this, go on the operation type and tick the box "Create New Lots/Serial Numbers for > Components" #### Expected behavior: The invalid operation should not be raised as the "required" option concerns only componenets and not final products. ### Cause of the issue: Creating a stock lot will first launch a call of the `_check_create`: https://github.com/odoo/odoo/blob/c25d71f14fa168807f07cd88bed805d15db8add5/addons/stock/models/stock_lot.py#L150-L153 However, since this check does not verifies that the product for which we create the lot is indeed related to a component of the MO it will raise the invalid operation even for final products: https://github.com/odoo/odoo/blob/c25d71f14fa168807f07cd88bed805d15db8add5/addons/mrp/models/stock_lot.py#L11-L17 ### Issue 2: Currently, the `quickCreate` ("Create *sn_name*") option of the lot field of te "register production" dialog calls a `name_create` that will set an error message in the logs as the product_id required field can not be provided neither in the vals or the context of the `name_create`. You then fall back on the same form dialog than the "Create and edit". The `quickCreate` option should therefore just be disabled. Enterprise: https://github.com/odoo/enterprise/pull/77265 opw-4452747 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#193965

Bug Fixes(8)

[IMP] sale_subscription: force flush before and after SO confirmation

[FIX] room: only send presences to interested users

[FIX] mass_mialing: sync sidebar height with the event template `iframe`

[FIX] mass_mailing: prevent snippet from overlapping with the sidebar

[FIX] spreadsheet: invalid pivot error message

[FIX] l10n_es_edi_facturae: only show FACe section on invoice for ES companies

[FIX] account: outbound shouldnt require validated bank account

[FIX] account: avoid ORM hacks (2)

Other(19)

[FW][IMP] mrp_workorder: batch creation of quality checks

Bug Fixes(8)

[IMP] sale_subscription: force flush before and after SO confirmation

[FIX] room: only send presences to interested users

[FIX] mass_mialing: sync sidebar height with the event template `iframe`

[FIX] mass_mailing: prevent snippet from overlapping with the sidebar

[FIX] spreadsheet: invalid pivot error message

[FIX] l10n_es_edi_facturae: only show FACe section on invoice for ES companies

[FIX] account: outbound shouldnt require validated bank account

[FIX] account: avoid ORM hacks (2)

Other(19)

[FW][IMP] mrp_workorder: batch creation of quality checks

[FW][FIX] quality_mrp_workorder: allow finished lot production via quality checks

[FW][IMP] l10n_it_riba: Do not translate Ri.Ba.

[FW][FIX] sale_timesheet_enterprise: don't fetch leaderboard data if feature disabled

[FW][FIX] whatsapp_*: Don't forcecreate whatsapp templates

[FW][FIX] project_sale_subscription: exclude recurring services from SOLs

[FW][FIX] sale_project: exclude recurring services from SOLs

[FW][FIX] point_of_sale: add to context without override

[FW][FIX] hr_expense: Broken access rights

[FW][FIX] website: facebook snippet visibility on mobile

[FW][FIX] point_of_sale: `console.error` unknown issue in `printHtml`

[FW][FIX] point_of_sale: fix crash with problematic chars in htmlToCanvas

[FW][FIX] account: fix access error for `tax_string` field in `product.template` model

[FW][FIX] payment_razorpay: prevent error when webhook secret is not provided

[FW][FIX] mrp: allow finished lot production via quality checks

[FW][FIX] account: on posted invoice it's change sequence number if journal_id key in write vals

[FW][FIX] base: show all groups menu in group view

[FW][FIX] hr_attendance: geolocate check in/out in kiosk mode

[FW][FIX] survey: make "Votes" translatable