Saturday, February 15, 2025
4 changes · saas-18.1
Miscellaneous changes
Issue reproducible on runbot: a blank page appears when clicking on "Identify manually" in the Attendance kiosk mode with the error `Cannot find the definition of component "Pager"` in the console, because the Pager component is missing from the components declaration. Note: also add correct props validation to make kiosk mode work in debug mode. opw-4573687 Forward-Port-Of: odoo/odoo#197661
Original PR description
Issue reproducible on runbot: a blank page appears when clicking on "Identify manually" in the Attendance kiosk mode with the error `Cannot find the definition of component "Pager"` in the console, because the Pager component is missing from the components declaration. Note: also add correct props validation to make kiosk mode work in debug mode. opw-4573687 Forward-Port-Of: odoo/odoo#197661
- Add a fallback to p2p if disconnected from the SFU while still being in the call or after a 5 seconds timeout. - Add logging where: * We obtain a track from a peer or the SFU * The state of the SFU connection changes * Our rtcSession is removed from the Odoo server * The peer-to-peer connections attempt connection recoveries - Raise the default log level of peer-to-peer to `WARN` - Add an `important` option to rtc logging so that logs that are important are recorded ev
Original PR description
- Add a fallback to p2p if disconnected from the SFU while still being in the call or after a 5 seconds timeout. - Add logging where: * We obtain a track from a peer or the SFU * The state of the SFU…
- Add a fallback to p2p if disconnected from the SFU while still being
in the call or after a 5 seconds timeout.
- Add logging where:
* We obtain a track from a peer or the SFU
* The state of the SFU connection changes
* Our rtcSession is removed from the Odoo server
* The peer-to-peer connections attempt connection recoveries
- Raise the default log level of peer-to-peer to `WARN`
- Add an `important` option to rtc logging so that logs that are
important are recorded even without activating the logging setting.
- Remove the generated error trade for logs as it added a lot of noise
and the message itself should be enough.
- Add logging snapshots of p2p and sfu when disconnecting and
downloading the logs.
- Remove the reactive session cleanup as it is redundant
with the `onDelete` of the `thread/rtcSessions` field.
- Remove `rtc.state.serverState` and put it as the `connectionState`
of `selfSession`.
- Await the peer to be ready before sending the tracks.
- Add a new p2p state "searching for network" to make it easier to know
when the connection is stuck where we may need TURN/SFU through a
difficult network.
- Prevent possible traceback when receiving a track for a missing
session in peer-to-peer.
Forward-Port-Of: odoo/odoo#196569Whenever you supply no password you are supposed to get an AccessDenied error. However in this case there will no be password supplied. This happens because of: https://github.com/odoo/odoo/blob/1f9f4dd165fccfaadf06c3ae68d742f5348bc9b6/addons/web/controllers/home.py#L122 When there is no value the key will also not be present. Therefore you will receive a keyerror instead of an accessdenied. This commit fixes that behavior and now you will get the accessdenied error as was originally inte
Original PR description
Whenever you supply no password you are supposed to get an AccessDenied error. However in this case there will no be password supplied. This happens because of: https://github.com/odoo/odoo/blob/1f9f4dd165fccfaadf06c3ae68d742f5348bc9b6/addons/web/controllers/home.py#L122 When there is no value the key will also not be present. Therefore you will receive a keyerror instead of an accessdenied. This commit fixes that behavior and now you will get the accessdenied error as was originally intended. Forward-Port-Of: odoo/odoo#197577
… on company parts Forward-Port-Of: odoo/enterprise#79363
Original PR description
… on company parts Forward-Port-Of: odoo/enterprise#79363