Wednesday, February 19, 2025
4 changes · saas-17.4
Resolved issues and error corrections
This fix prevents the cursor from jumping to the start of a document when the same task description is opened and edited in multiple browser tabs. It improves the collaborative editing experience by preserving each user's current position while background history synchronization occurs.
Original PR description
**Problem**: When the editor gains `focus` for the first time, `_latestComputedSelection` is set. However, `_resetFromClient` is then called to synchronize history steps with another client, recreating the nodes in the editor. This causes new node `oid`s to be generated (so we can't match with the `oid`s), invalidating the existing `_latestComputedSelection` (its `anchorNode` and `focusNode` no longer point to valid nodes). **Solution**: Before recreating the history, save the selection path. This allows the selection to be restored accurately from the newly created nodes. **Steps to reproduce**: 1. Open a task in one browser tab and start editing. 2. Keep that tab open. 3. Open the same task in a second browser tab. 4. Click to start editing in the second tab. 5. Observe that the cursor moves back to the start of the description in the first tab. opw-4235013 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an error that appeared when users opened the Plans smart button from an HR department record. This restores access to department-related planning information and prevents a disruptive traceback in normal HR workflows.
Original PR description
Currently, a traceback is occurring when the user tries to click the `plans` smart button in the hr department record. To reproduce this issue: 1) Install hr 2) Open any hr department record 3) Click…
Currently, a traceback is occurring when the user tries to click the `plans` smart button in the hr department record. To reproduce this issue: 1) Install hr 2) Open any hr department record 3) Click the `Plans` smart button Error:- ``` ValueError: malformed node or string on line 1: <ast.Name object at 0x7333bacc> ``` This error was occurring because of the latest changes from the below commit, https://github.com/odoo/odoo/pull/196430/commits/ec4991330224784571d850fb87ee7940a071080a We used `literal_eval()` from the below line to evaluate the domain in action. Which contains `allowed_company_ids`. This leads to the above error while evaluating in `literal_eval()`. https://github.com/odoo/odoo/blob/b070f9a4aa179799e3412d18b8faba07349bbf7b/addons/hr/models/hr_department.py#L147-L153 The domain in the action was modified from the below commit recently, https://github.com/odoo/odoo/pull/193572/commits/c2243abca397ab6622ec85e6fe6adbfef0d7c47b We can resolve this issue by replacing the `allowed_company_ids` by accessing the value of `allowed_company_ids` from context. sentry-6285774985
This fixes an issue where the main menu could disappear after refreshing a page when the current screen was not directly linked to a menu item. The web client now falls back to the last used menu, improving continuity for users during reloads, though shared or newly opened links may still not show the menu.
Original PR description
[1] introduced a new URL mechanism where the menu_id isn't in the URL anymore. To find the corresponding menu on reload, the web client searches for a menu corresponding to the first application in the URL. The advantage of this, is that a clean URL without superflow is used. One of the limitations is that if the first action in the URL is not linked to a menu, the menu may disappear on reload. This PR fixes this issue by creating a fallback to the last used menu. This is done to improve the user experience on reload. Note that this only fixes the problem on reload. If the URL is opened in a new tab, or shared, the menu will not be display. [1] https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f opw-198103
Accounting report column selections now update immediately when users add or remove columns. This removes the need to manually refresh the page, making report configuration smoother and less confusing.
Original PR description
When toggling columns in any Accounting Report list view, it requires a manual refresh to see the changes. this is caused because this [commit](odoo/enterprise@adc4bb7) removed automatic reactivity, so we need to explicitly recompute the columns after updating optionalActiveFields To resolve this, we override the ListRenderer's `toggleOptionalField` function to explicitly recompute columns before rendering. Steps to reproduce: 0. Activate developer mode 1. Navigate to the 'Accounting Reports' menu in accounting. 2. Open a report (e.g. the balance sheet) 3. Use the column selector to add or remove additional columns OPW-4352833 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr