Saturday, February 22, 2025
2 changes · 17.0
Resolved issues and error corrections
The import screen now correctly keeps and applies the “No Separator” option when users import bank statement CSV files. This prevents the system from accidentally treating commas as the thousands separator, helping avoid incorrect import previews or results.
Original PR description
**Steps to reproduce:** - Install Accounting - On Accounting dashboard, click on "Import File" button of Bank journal - Select a CSV file with bank statements - On the left menu, select "No…
**Steps to reproduce:** - Install Accounting - On Accounting dashboard, click on "Import File" button of Bank journal - Select a CSV file with bank statements - On the left menu, select "No Separator" as "Thousands Separator" **Issue:** "Comma" is displayed as selected instead the first time. The second time "No Separator" stays as selected. However, the value sent when testing or importing is not the correct one. **Cause:** "No Separator" option should have an empty string as value. However, during the generation of the "select" element, the value for the "option" element is evaluated with: `opt.value or opt` As `opt.value` is the empty string (evaluated to False), `opt` is used instead, even if it is an object, which is not correct. The main issue is that the empty string is not handled as a valid value. **Solution:** Handle the empty string as an acceptable value. opw-4325310 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Discuss call interface now checks the correct connection status before showing a warning. This prevents users from seeing misleading call connection alerts when there is no actual issue.
Original PR description
Before this commit, the condition for displaying the call warning was using `rtc.connectionType` instead of `rtc.state.connectionType`, which resulted in the warning being shown in the wrong situations.