Monday, February 24, 2025
8 changes
1 change
Resolved issues and error corrections
This fixes an issue where document shortcut access did not correctly account for the document owner. It helps ensure users can access the document shortcuts they are entitled to while keeping document permissions consistent.
7 changes
Resolved issues and error corrections
This fixes how tax subtotals are calculated on accounting documents. Subtotals now build from the untaxed amount plus earlier taxes, making displayed totals more consistent and easier to understand.
Original PR description
The first subtotal is always the untaxed amount of the document. All following subtotals are just the previous one plus the previous taxes. So the subtotal no longer depend of the taxes under it. opw-4571908 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
PayPal payments no longer fail when started by guests or PoS sessions that use the public user. The payment request now avoids sending missing customer email data and uses the company country code when needed, preventing malformed PayPal payloads.
Original PR description
When making a payment from the PoS, the user would always be the Public User. This would cause the payload sent to paypal to be incorrect and the payment to fail. This happens because we are trying…
When making a payment from the PoS, the user would always be the Public User. This would cause the payload sent to paypal to be incorrect and the payment to fail. This happens because we are trying to make a payment without any user, so this can be reproduced in other workflows. Like making a donation Steps to reproduce: ------------------- * Setup paypal payment provider * Create a PoS payment method with the paypal provider * Create a PoS order and pay with the paypal payment method > Observation: You get an error saying that something is malformed Alternative steps to reproduce: -------------------------------- * Make sure you are not connected on Odoo * Go to the `donation/pay` url * Fill out the form and make the payment via paypal > Observation: You get an error saying that something is malformed Why the fix: ------------ When using the public user, we cannot provide an email address or a country code. To fix this we make sure to not send the email address at all when there is none available. And we send the country code of the company instead of none. opw-4446219
This fixes an eCommerce product page issue where customers could see both “Add to cart” and “Contact Us” after selecting a product option that makes a zero-priced product sellable. The page now shows the appropriate purchase option, reducing customer confusion and improving the shopping flow.
Original PR description
Versions -------- - 18.0+ Steps ----- 1. Enable Prevent Sale of Zero Priced Product; 2. have a product with attributes; 3. set its list price to 0; 4. add a price extra to one of its attributes; 5. go to its eCommerce page; 6. select the price extra attribute. Issue ----- Both the "Add to cart" and "Contact Us" buttons are shown. Cause ----- - Commit 8f4c8ada7e9fe refactored the `website_sale.product` template, moving the "Contact Us" button outside of the `div.js_product` element. - This element gets passed as `$parent` to the `_onChangeCombination` method, which ought to handle these changes. - Because the `#contact_us_wrapper` is no longer in `$parent`, it fails to find it and change its classes accordingly. Solution -------- Instead of querying for the `#contact_us_wrapper` element directly in `$parent`, look for the `#product_details` element first, then query it. opw-4423323
The online store add-to-cart snippets now correctly read true/false settings instead of treating every value as enabled. This ensures quantity options appear only when intended, including outside standard product pages, reducing customer confusion during shopping.
Original PR description
We forgot to parse a boolean which was stored as a string so it was always considered true (both the strings `'true'` and `'false'` evaluate to `true` in a boolean context. This change also fixes the `showQuantity` computation in the product and combo configurators (the computation assumed the user was on the product page, which isn't necessarily the case for "add to cart" snippets).
Images in the HTML editor now keep their resized dimensions after using the transform option. This prevents images from jumping back to their original size or shifting position when rotated, making content editing more reliable.
Original PR description
### Steps to Reproduce: - Open the To-Do App. - Upload an image (e.g., `/image`). - Resize the image to 25%, 50%, or 100%. - Click the `Transform` button in the toolbar. ### Approach: - Initially,…
### Steps to Reproduce: - Open the To-Do App. - Upload an image (e.g., `/image`). - Resize the image to 25%, 50%, or 100%. - Click the `Transform` button in the toolbar. ### Approach: - Initially, `this.transfo.settings.style = this.image.style` created a shared reference to the same `CSSStyleDeclaration` object, meaning changes to one were reflected in both. - Later, when `this.image.style = settings.style` was executed, the inline styles were lost because it reassigned the same reference instead of copying the styles individually, resulting in properties like `width` being reset. ### Description of the issue/feature this PR addresses: - Resizing an image (e.g., 25%, 50%, or 100%) would revert it to its original size after clicking the `Transform` button. - Rotating the image would cause it to be misplaced. ### Desired behavior after PR is merged: - The image retains its resized dimensions after transformation. - The image remains correctly positioned during rotation. task-4251410
Fixed an issue that prevented sales users from opening the commission pivot view. The commission achievement rate can now be aggregated correctly, avoiding the error and restoring access to reporting.
Original PR description
**Problem:** The problematic PR is this one : https://github.com/odoo/enterprise/pull/78537 This fix caused the pivot view to be inaccessible, creating a traceback, because the field 'achieved_rate' needs to be able to be aggregated. The line that removed the aggregator that was added was the new problem. https://github.com/odoo/enterprise/blob/137b233d4990ea9f48c8aa5b6a3990dc4170356b/sale_commission/report/commission_report.py#L19 **Steps to reproduce:** - Go to commissions in the sales app - Click on the pivot view - The traceback will appear **Fix:** Change the aggregator from None to the default one. opw-4512739
The sales commissions pivot view now opens without an error. Commission achievement rates are averaged when results are grouped, giving users a meaningful aggregated view of performance.
Original PR description
**Problem:** This is a reverse and improvement of a previous fix. The first PR is this one : https://github.com/odoo/enterprise/pull/78537 This fix caused the pivot view to be inaccessible, creating a traceback, because the field 'achieved_rate' needs to be able to be aggregated. The line that removed the aggregator that was added was the new problem. https://github.com/odoo/enterprise/blob/137b233d4990ea9f48c8aa5b6a3990dc4170356b/sale_commission/report/commission_report.py#L19 **Steps to reproduce:** - Go to commissions in the sales app - Click on the pivot view - The traceback will appear **Fix:** Change the aggregator from None to 'avg' to pick the average of the achieved_rate in case of a group by. opw-4512739