Wednesday, February 26, 2025
1 change · saas-17.4
Resolved issues and error corrections
This fixes an automated test for the restaurant point of sale tip screen that was failing because order synchronization happened twice too quickly. The change removes unnecessary test steps so payment validation and the tip screen check run reliably, helping keep release validation stable.
Original PR description
- Fix for following runbot error : https://runbot.odoo.com/odoo/runbot.build.error/111599 - Remove useless steps in `tip_screen_tour` so that it run successfully. The tour was always failing except when adding `step_delay`. - The step `TipScreen.isShown()` was failing. This was due because the previous step (validate payment) was not doing anything. This was caused by the fact that the order was syncing two times (syncAllOrders) with too short a time interval, causing the second call to `syncAllOrders` filtering out our order (see `syncingOrders` set in `syncAllOrders` method). - The first call to `syncAllOrders` was triggered by going back to the floorscreen, and I've removed it so now the validate payment and next steps are correctly executed. runbot error: 111599 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr