Wednesday, February 26, 2025
2 changes · saas-17.4
Resolved issues and error corrections
This update fixes several issues affecting combo meals and shared restaurant orders in Point of Sale and self-ordering. Prices, discounts, order splitting, cart display, and navigation now behave more reliably, reducing checkout errors and staff interruptions.
Original PR description
pos*: point_of_sale, pos_restaurant, pos_self_order This is a compilation of bug fix mostly about combos. 1. make pos combo groupable in pos 2. changing discount price or discount does not work 3.…
pos*: point_of_sale, pos_restaurant, pos_self_order This is a compilation of bug fix mostly about combos. 1. make pos combo groupable in pos 2. changing discount price or discount does not work 3. should not be able to set the price on a combo line 4. changing price on combo parent should adapt price 5. when ordering a combo in self, the backend was not showing the good prices 6. when splitting an order with a combo with quantity more than 1, the user was not able to select the quantity he wanted for the combo. It was always 0 or the whole quantity. 7.the price was not working in the cart_page for combos 8. when opening a table on two different device, adding lines on one of them and going to the floor screen, a traceback was shown on the other. 9. When clicking on resume order after a payment, we are sent to the ticket screen. When on it, if the user deletes all the orders on the table and click "Back", a traceback was shown. this was due to the fact that we pass an empty screen name to showScreen(name, props) leading to the method not finding a screen with the name ''. Enterprise PR: odoo/enterprise#73046 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where producing subcontracted items tracked by serial number could skip the expected batch production step and incorrectly validate production with zero completed units. Businesses using subcontracting can now produce multiple serial-numbered units from purchase-related subcontracting orders without losing the required serial number workflow.
Original PR description
### Steps to reproduce: - In the settings enable "Multi-Step Routes" and "Subcontracting" - Inventory > Configuration > Warehouse Management > Operation Types - Unarchive "Subcontracting" - Create a…
### Steps to reproduce:
- In the settings enable "Multi-Step Routes" and "Subcontracting"
- Inventory > Configuration > Warehouse Management > Operation Types
- Unarchive "Subcontracting"
- Create a product tracked by SN with:
- A set vendor
- A bom of type subcontracting with your vendor set as subcontractor
- Create and confirm a PO for 3 units of your product with your vendor.
- Go to inventory > Subcontracting (operation type) > the related SBC
- Click on "Produce All" (this should pop a batch produce wizard)
#### > It does not and you have validated the MO for 0 units without backorder
### Cause of the issue:
Since Commit 5722286a36838f644bb4e95c305b65b412774d75 (saas-17.1), the `action_mass_produce` used to split a tracked MO and generate the assocated SN:
https://github.com/odoo/odoo/blob/bc5414602920ee712c45397d7992863a0b1ea161/addons/mrp/models/mrp_production.py#L2281-L2292
should be returned by the `pre_button_mark_done` to be performed: https://github.com/odoo/odoo/blob/bc5414602920ee712c45397d7992863a0b1ea161/addons/mrp/models/mrp_production.py#L2128 https://github.com/odoo/odoo/blob/bc5414602920ee712c45397d7992863a0b1ea161/addons/mrp/models/mrp_production.py#L1994-L1997
However, for subcontracted MO, the returned value of the `pre_button_mark_done` is currently always True, skipping the batch production wizard:
https://github.com/odoo/odoo/blob/bc5414602920ee712c45397d7992863a0b1ea161/addons/mrp_subcontracting/models/mrp_production.py#L105-L108
opw-4447631
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr