Monday, March 3, 2025
15 changes · 18.0
Resolved issues and error corrections
Fixed an issue where a point of sale order could be saved without a responsible user when different employees used the same POS session. This ensures backend order records correctly reflect the user who finalized the sale, improving traceability and reporting accuracy.
Original PR description
Currently, when using the same pos session with different users can result in some order being created without user_id. Steps to reproduce: ------------------- * Open register as Mitchell Admin * Make a pos order, pay with cash, validate, select 'new order' * Log out * Log with Marc Demo and open the pos * Make a pos order, pay with cash, validate * In the backend, see both orders > Observation: For the second order, Mard Demo is written in the chatter as the one who created the order but on the form no user is registered Why the fix: ------------ This happens because when selecting 'new order', an order gets created which will then be loaded back when logging with the second user. When loaded the order has an unidentified user but still has a user_id in the vals of the setup. We do not want to use this user as it is the one that created the order, not the one who finalized it. opw-4566194
The website recruitment form now makes toggle labels available for translation, so they can appear correctly in different languages. This improves the experience for multilingual job applicants without changing recruitment workflows.
Original PR description
- add the _t() to translate the labels coming from options. - add the label values to the template to be available on the pot file Task: 4488490 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a small typo in the information shown for product combinations in the online store. The change helps keep customer-facing product details clear and professional without altering functionality.
Original PR description
Fix a typo introduced in 4ec8d2198a1a042cde397b73e2afd56e108c7892
Hungarian invoice PDFs now apply the standard small company logo styling. This prevents oversized logos from disrupting invoice layout when a large image is uploaded.
Original PR description
The company logo on the hungarian invoices are too big if the used picture is big, because the size is not limited on the PDF report. So we set the class "o_company_logo_small" on the picture just like on everywhere in Odoo. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error that could occur in Safari 18.3 when users returned from the Sales app to the home menu. It improves reliability during guided interface behavior so users can continue navigating without interruption.
Original PR description
Steps:
- Install `sale_management`
- Open Sales
- Go back to home menu
- traceback
`getParentScroll` can return `null`
```js
const scrollParentElement = getScrollParent(this.currentTarget);
const targetBounds = this.currentTarget.getBoundingClientRect();
if (targetBounds.bottom > scrollParentElement.clientHeight)
```
```js
export function getScrollParent(element) {
if (!element) {
return null;
}
```
This commit adds a fallback for the return value of `getScrollParent` to
prevent this traceback.
opw-4600271Miscellaneous changes
This commit fixes the runbot test failures related to invoice generation when the user is not logged in and VAT values are missing. - Cause an issue for MX and EC country code - VAT field is removed from mandatory fields - No need to remove the vat field manually, when the country changes the mandatory field list will be changed accordingly. Runbot Errors: 111328, 111329 Related: https://github.com/odoo/enterprise/pull/79646 --- I confirm I have signed the CLA and read the PR guide
Original PR description
This commit fixes the runbot test failures related to invoice generation when the user is not logged in and VAT values are missing. - Cause an issue for MX and EC country code - VAT field is removed from mandatory fields - No need to remove the vat field manually, when the country changes the mandatory field list will be changed accordingly. Runbot Errors: 111328, 111329 Related: https://github.com/odoo/enterprise/pull/79646 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#198506
Issue: When you try to acssess the kiosk mode for a company which has no lang set on its partner, a blocking error is raised solve: add the env.lang as a default lang if the partner lang return false Task: 4465594 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#199028
Original PR description
Issue: When you try to acssess the kiosk mode for a company which has no lang set on its partner, a blocking error is raised solve: add the env.lang as a default lang if the partner lang return false Task: 4465594 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#199028
The lack of borders in the modals of the front-end is problematic when there is some content overflowing the height of the modal. This PR restores the borders for a better visual hierarchy. Non-optimal design introduced in front-end redesign: https://github.com/odoo/odoo/pull/120302 task-4001380 | Before | After | |--------|--------| | <img width="979" alt="Screenshot 2024-06-20 at 11 41 54" src="https://github.com/odoo/odoo/assets/110090660/31e0d3c7-fcd9-43c9-9aae-7db3b4e49af2"> |
Original PR description
The lack of borders in the modals of the front-end is problematic when there is some content overflowing the height of the modal. This PR restores the borders for a better visual hierarchy. Non-optimal design introduced in front-end redesign: https://github.com/odoo/odoo/pull/120302 task-4001380 | Before | After | |--------|--------| | <img width="979" alt="Screenshot 2024-06-20 at 11 41 54" src="https://github.com/odoo/odoo/assets/110090660/31e0d3c7-fcd9-43c9-9aae-7db3b4e49af2"> | <img width="978" alt="Screenshot 2024-06-20 at 11 42 26" src="https://github.com/odoo/odoo/assets/110090660/09f12eb0-79e4-454f-9896-af238b26a7b3"> | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170105
- Open a posted invoice - Reset to draft - Action > Switch into invoice/credit note Validation Error will raise `You cannot switch the type of a posted document.` However the message is misleading, because we check that the document has not been posted at all opw-4509455 Forward-Port-Of: odoo/odoo#199494 Forward-Port-Of: odoo/odoo#198592
Original PR description
- Open a posted invoice - Reset to draft - Action > Switch into invoice/credit note Validation Error will raise `You cannot switch the type of a posted document.` However the message is misleading, because we check that the document has not been posted at all opw-4509455 Forward-Port-Of: odoo/odoo#199494 Forward-Port-Of: odoo/odoo#198592
A traceback error occurs when creating an employee without working hours, setting up an accrual allocation for that employee, and choosing a start date before yesterday. **Steps to reproduce the issue:** 1- Create a new employee in the Employees module with an empty "Working Hours" field. 2- Create an accrual plan: - Go to Time Off > Configurations > Accrual Plans > New. - Create a new milestone for X amount of days hourly, source: Calendar. 3- Create an accrual allocation for t
Original PR description
A traceback error occurs when creating an employee without working hours, setting up an accrual allocation for that employee, and choosing a start date before yesterday. **Steps to reproduce the…
A traceback error occurs when creating an employee without working hours, setting up an accrual allocation for that employee, and choosing a start date before yesterday. **Steps to reproduce the issue:** 1- Create a new employee in the Employees module with an empty "Working Hours" field. 2- Create an accrual plan: - Go to Time Off > Configurations > Accrual Plans > New. - Create a new milestone for X amount of days hourly, source: Calendar. 3- Create an accrual allocation for that employee: - Go to Time Off > Management > Allocations > New. - Select the accrual plan created earlier. If you choose any start date before yesterday, a traceback error occurs (see screenshots attached) <img src="https://github.com/user-attachments/assets/03198eb8-5e9a-4633-a87f-b0c07aec600d" alt="traceback_error" width="400"/> The PO (GMF) confirmed that there should always be a fallback for "Working Hours" in this order: Working hours from Contract > Working Hours from Employee > Working Hours from company opw-4281311 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#197505 Forward-Port-Of: odoo/odoo#185428
Certain certificates contain additional fields beyond those currently included (CN, OU, O, C), such as "2.5.4.97" and "L". Since these additional fields are not incorporated into the issuer name, attempts to validate the signed document on the following sites will result in errors: - https://face.gob.es/es/facturas/validar-visualizar-facturas - https://valide.redsara.es/valide/validarFirma/ejecutar.html These errors typically indicate that the signature is either invalid and that the cer
Original PR description
Certain certificates contain additional fields beyond those currently included (CN, OU, O, C), such as "2.5.4.97" and "L". Since these additional fields are not incorporated into the issuer name, attempts to validate the signed document on the following sites will result in errors: - https://face.gob.es/es/facturas/validar-visualizar-facturas - https://valide.redsara.es/valide/validarFirma/ejecutar.html These errors typically indicate that the signature is either invalid and that the certificate does not match the values within `<KeyInfo>`. This discrepancy occurs because all certificate fields are included in the signature, but some are missing from the `<X509IssuerName>` field. This fix adds the missing certificate fields to ensure consistency between the signature and the issuer name. Based on my tests, the order of these fields does not affect the validation process. opw-4484906 opw-4482626 Forward-Port-Of: odoo/odoo#199852 Forward-Port-Of: odoo/odoo#196576
<img width="1047" alt="Captura de pantalla 2024-12-12 a las 10 23 09 a m" src="https://github.com/user-attachments/assets/89e3ced3-7a62-4ae8-b661-f40d4e312df0" />
Original PR description
<img width="1047" alt="Captura de pantalla 2024-12-12 a las 10 23 09 a m" src="https://github.com/user-attachments/assets/89e3ced3-7a62-4ae8-b661-f40d4e312df0" />
This commit fixes the runbot test failures related to invoice generation when the user is not logged in and VAT values are missing. Runbot Errors: 111328, 111329 Related: https://github.com/odoo/odoo/pull/198506 Forward-Port-Of: odoo/enterprise#79646
Original PR description
This commit fixes the runbot test failures related to invoice generation when the user is not logged in and VAT values are missing. Runbot Errors: 111328, 111329 Related: https://github.com/odoo/odoo/pull/198506 Forward-Port-Of: odoo/enterprise#79646
__Steps to reproduce:__ 1. Create a project (billable). 2. Give the user access to Company A + B, while the default is A 3. Add a task with a customer belonging to company B 4. Create a task and add products to it. __Description of the issue:__ - The **"Decrease"** button is disabled, with raised error message that the amount is delivered. - This happens because the domain fetching `stock.move` uses user’s default company instead of SO’s company which leads to the wrong default WH _
Original PR description
__Steps to reproduce:__ 1. Create a project (billable). 2. Give the user access to Company A + B, while the default is A 3. Add a task with a customer belonging to company B 4. Create a task and add products to it. __Description of the issue:__ - The **"Decrease"** button is disabled, with raised error message that the amount is delivered. - This happens because the domain fetching `stock.move` uses user’s default company instead of SO’s company which leads to the wrong default WH __Description of the solution:__ - Update warehouse logic to fetch the default warehouse using the SO’s company context, ensuring `stock.move` domain aligns with the sale order’s company - opw-4471366 Forward-Port-Of: odoo/enterprise#80007
When users attempt to send a template with 10 body variables, the sample values for `Free Text 1` and `Free Text 10` are swapped. Steps to Produce: - Create a template with 10 body variables - Give sample value for `Body - {{1}}` as 1 and `Body - {{10}}` as 10 - Open the WhatsApp composer using the created template - `Free text 1` will have a value of 10 instead of 1 - `Free text 10` will have a value of 1 instead of 10 Problem: The variables are sorted by name, causing `{{10}}`
Original PR description
When users attempt to send a template with 10 body variables, the sample values for `Free Text 1` and `Free Text 10` are swapped.
Steps to Produce:
- Create a template with 10 body variables
- Give sample value for `Body - {{1}}` as 1 and `Body - {{10}}` as 10
- Open the WhatsApp composer using the created template
- `Free text 1` will have a value of 10 instead of 1
- `Free text 10` will have a value of 1 instead of 10
Problem:
The variables are sorted by name, causing `{{10}}` to appear before `{{1}}`, which leads to the values being swapped.
Solution:
Sort the variables by extracting the index from the variable name, so they are ordered numerically rather than alphabetically.
Task-4212923
Forward-Port-Of: odoo/enterprise#71307