Tuesday, March 4, 2025
2 changes · saas-17.4
Resolved issues and error corrections
This fixes tax calculations so retention taxes use the correct base amount when a price-included tax should not affect later taxes. Businesses will see more accurate invoice and point-of-sale discount tax amounts in affected tax setups.
Original PR description
**Steps to reproduce:** - Install Accounting - Create an included tax: * Amount: 20% * Included in Price: [enabled] * Affect Base of Subsequent Taxes: [disabled] - Create a retention tax: * Amount: -5% * Included in Price: [disabled] * Affect Base of Subsequent Taxes: [disabled] * Base Affected by Previous Taxes: [enabled] - Create an invoice: * Price: 120.0 * Taxes: [Both created taxes] **Issue:** The base amount used to compute the retention tax is including the amount of the included tax (i.e. 120.0), but it should not (i.e. 100.0) as the included tax doesn't affect the base of subsequent taxes. **Cause:** When "special_mode" is False, all excluded taxes following an included tax have their base affected by the included tax. opw-4451617 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The sign-up form now enforces the configured minimum password length before a new user submits it. This prevents incomplete account creation after purchases and reduces cases where customers are later blocked by an invalid sign-up token.
Original PR description
When trying to sign in (for a new user) after making a purchase (existing token), we can choose a password of less than the minimum length allowed in the configuration. The _check_password_policy method prevents the save of the password to the user but arrives too late in the flow as the initiation of the user creation is half done leading to an Invalid token issue at the next attempt (no partner found for the existing token with _signup_retrieve_partner). By adding the minlength attribute in the form of the sign up, we force the respect of the password policy minimum length in the front end and minimize the risk to encounter the issue. previous PR unmerged: https://github.com/odoo/odoo/pull/186622 opw-4514350