Friday, March 7, 2025
4 changes · saas-18.2
Resolved issues and error corrections
Archiving course content from the website no longer triggers an error. This lets course managers remove or archive content smoothly from the front-end confirmation dialog.
Original PR description
Steps to reproduce ================== - Open any course on the front-end side. - Click on the delete button of any content to open the confirmation dialog. - Click on the Archive button of the dialog. Technical ============ Here https://github.com/odoo/odoo/commit/22e777c046521f3f89b62caa5876680beb7f5aba#diff-42aed129bdbb169fcea12a40c91754f8d556fa11d3b2c1989a442760a101d031 we changed the public widgets into the interactions where we used for...in loop. - We were using a for...in loop, which iterates over the keys/indices of an array, not the values. which caused the issue. - To fix the issue, we replaced the for...in loop with a for...of loop, which correctly iterates over the elements of the array. Task-4625895
This fixes an automated live chat test so it correctly expects the operator join message in the operator's language. It helps keep release validation reliable after translation updates, without changing the customer-facing live chat behavior.
Original PR description
Before this commit, the test `test_chatbot_fw_operator_matching_lang` failed at the following step: ``` "trigger": ".o-livechat-root:shadow .o-mail-Message:contains('Hello! I'm a bot!')" }, {…
Before this commit, the test `test_chatbot_fw_operator_matching_lang` failed at the following step:
```
"trigger": ".o-livechat-root:shadow .o-mail-Message:contains('Hello! I'm a bot!')"
},
{
"trigger": ".o-livechat-root:shadow button:contains(I want to speak with an operator)",
"run": "click"
},
---------- FAILED: [3/3] Tour chatbot_fw_operator_matching_lang → Step .o-livechat-root:shadow .o-mail-NotificationMessage:contains(joined the channel) ----------
{
"trigger": ".o-livechat-root:shadow .o-mail-NotificationMessage:contains(joined the channel)"
},
------------------------------------------------------------------------------------------------------------------------------------------------------------------
```
This happens because when the chatbot forward to operator, the message notification "Operator joined the channel" uses the language of the operator. This is not ideal but this is a technical limitation that cannot change in stable.
The test was asserting "joined the channel" message notification when the chatbot forwards to a French operator. However in practice this is actually shown as "a rejoint le channel", because this uses the operator language which is French.
The test was passing due to french translations not being updated, thus it was still relying on the English version. When translations have been updated, this test failed as expected.
This commit fixes the issue by assertion presence of message notification like before but it takes into account the language of the operator.
Note that this is definitely not ideal: the message notification should actually adapt the language on the viewer. We plan to improve this, but this needs non-trivial changes to message notifications to make this work.
runbot-159895The Kenya payroll SHIF report wizard has been updated to work after the payslip number field was removed. It also skips payslips with zero SHIF or NHIF amounts, preventing empty report entries and making reports cleaner.
Original PR description
Problem ---------- - Number field of HrPayslip model was removed, it makes crash the SHIF Report wizard - Demo data payslips doesn't contains NHIF or SHIF amount, it makes the SHIF report wizard add the payslip with an amount of 0. Objective ---------- - fix the SHIF Report wizard - check if the SHIF/NHIF amount == 0 before add it in report entries. Solution ---------- - replace payslip.number by payslip.name - add a condition on the SHIF/NHIF amount to add the payslip task-4463586
Knowledge article comments now hide reply and forward options because comments are meant for notes on specific content, not separate conversations. This keeps article feedback clearer and prevents users from accidentally sending or responding to comments in unsupported ways.
Original PR description
Comments are intended for adding notes or remarks on specific parts of the body and are not meant to be forwarded or replied to. This PR disables the reply and forward actions for comments on knowledge articles. Task-4624027