Monday, March 17, 2025
3 changes · master
Resolved issues and error corrections
The website resource editor now has better spacing between its Save and Close buttons, so the controls are easier to distinguish. The warning dialog shown when opening the editor has also been tidied up for clearer spacing and button layout, while keeping the same message.
Original PR description
This PR aims to fix minor design issues within the resource editor that require a small amount of changes for a high gain. 1) The `save` and `close` buttons in the top right corner are missing a…
This PR aims to fix minor design issues within the resource editor that require a small amount of changes for a high gain. 1) The `save` and `close` buttons in the top right corner are missing a spacing, making them stick together ; 2) When opening the resource editor, a modal is displayed to indicate that the changes applied here could be lost during an upgrade. The content of that modal was missing a bit of spacing, and there was an issue with the layout of the bottom buttons. This PR takes care of these changes while keeping the same content. task-4008742 | //////// | Master | This PR | |--------|--------|--------| | Top-right buttons spacing | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/a410183e-14b6-4891-bb5c-880f4575d5a6"> | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/0ed96f9e-a9d8-4e7e-9ba1-fb116ed9c73f"> | | Modal design | <img width="721" alt="image" src="https://github.com/user-attachments/assets/2ec0bc3b-91a6-451b-8620-f805f0a4b368"> | <img width="704" alt="image" src="https://github.com/user-attachments/assets/73723490-9348-4fec-9704-c02fcaa0b5ca" /> | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Text alignment keyboard shortcuts in the HTML editor were removed because they overlapped with common browser shortcuts, such as hard refresh. This prevents accidental browser actions or editor commands and makes editing behavior more predictable for users.
Original PR description
Description of the issue this PR addresses: This commit removes the text alignment shortcuts introduces in commit [1](https://github.com/odoo/odoo/commit/5e06eba56427a8c58bb503d160a8df815d2d8b9a) as they conflicted with certain browsers shortcuts. For example, Ctrl+Shift+R, which was assigned to align text to the right, is commonly used for a hard reload in browsers. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an internal style-checking service from failing when Odoo is loaded inside a blank embedded page. It avoids unnecessary error messages and helps keep embedded views stable for users.
Original PR description
The `scssErrorNotificationService` uses the `browser.location.origin` as base url for a check. In the case of an iframe with `src="about:blank"`, the origin is `"null"`, which isn't a valid base URL and throws a TypeError. In such a case anyway, any sheet's origin would be different from the iframe's, so we just bypass the error service entirely.