Tuesday, March 18, 2025
4 changes · saas-17.4
Resolved issues and error corrections
Users opening and editing tags linked to company-specific fields could encounter a traceback after switching companies. The change prevents the crash by showing a clear access error when the dialog cannot be reloaded, keeping the workflow understandable instead of failing unexpectedly.
Original PR description
- On a view with a company-dependent field with a `many2many_tags` widget, where the `edit_tags` option is set to `true`; - Click on a tag; - Change the company; - Save the tag; - Open the same tag again; A traceback error is displayed. This error occurs because, since [1], when loading the form view the access errors are handled, the company is added to the selected companies and the record is reloaded. The issue is that this cannot be done with a dialog form view, not only is an unreachable action service function is called, but also the dialog is not reopened when reloading. In this commit, we fix this by showing the access error.
This fix ensures loyalty points are only granted when a point-of-sale order has actually been paid. It prevents customers from incorrectly receiving rewards for draft or unfinished orders when multiple POS orders are synchronized together.
Original PR description
In point of sale it is possible to manage several orders at the same time and, whenever an order is paid, all orders will be synchronized with the backend. This causes an issue with loyalty rewards…
In point of sale it is possible to manage several orders at the same time and, whenever an order is paid, all orders will be synchronized with the backend. This causes an issue with loyalty rewards that are granted even for orders not yet completed. Steps to reproduce: - Have a Loyalty Program configured as follows: - Program Type: Loyalty Card - Grant 1 point per $ spent - Create a Loyalty card for [Partner] - Open POS Session - Add a [Partner] as customer - Add product - Leaving the order as it is, create a new order - Add just a product - Validate & Pay the second order Issue: Loyalty points will be added to [Partner] Card, as if the order was actually paid This occurs because we don't check that the order has been actually paid before processing rewards opw-4538040 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale promotions for “buy X get Y” now apply consistently when triggered automatically. This prevents customers from receiving an extra free item beyond the intended offer and aligns automatic promotions with manual reward selection.
Original PR description
In Point of sale promotion program may be auto applied to the order whenever the conditions of the promotions are satisfied. However, a promo 'buy x get y' is auto applied inconsistently when…
In Point of sale promotion program may be auto applied to the order
whenever the conditions of the promotions are satisfied.
However, a promo 'buy x get y' is auto applied inconsistently when
comparing the output with the reward button (or applying the promotion on a sales
order)
Steps to reproduce:
- Have a promo program like follows:
- Program Type: Buy X Get Y
- Condition:
- Minimum quantity: 2
- Grant: 1 credit per order
- Product: [PRODUCT]
- Reward:
- In exchange of: 1 credit
- Product: [PRODUCT]
- Quantity rewarded: 1
- Open POS Session
- Add 2x [Product]
Issue:
- "Free" [PRODUCT] line is added to the order with negative price
So the customer will buy 1 [PRODUCT] and get 2 that is not what we want
with the promo program
If we delete the reward line, click on reward button and choose again
the same promo we get the correct behavior:
- Exisitng [PRODUCT] line quantity raised to 3
- "Free" [PRODUCT] line added to the order with negative price
opw-4563825Self-service customers can no longer proceed with combo products until all required options are selected, preventing checkout errors. Combo item quantities now match what the customer chose, reducing incorrect orders and staff corrections.
Original PR description
Issue 1: Traceback =================== Steps to Reproduce: --------------------- 1. Open POS Self Order. 2. Select a combo product (e.g., "Burger Menu Combo"). 3. Choose a main product (e.g., "Cheese…
Issue 1: Traceback =================== Steps to Reproduce: --------------------- 1. Open POS Self Order. 2. Select a combo product (e.g., "Burger Menu Combo"). 3. Choose a main product (e.g., "Cheese Burger") but **do not** select its attributes. 4. Click the "Next" button. 5. Select the remaining combo child product (e.g., "Water"). 6. Click "Add to Cart" → **Traceback occurs.** Fix: ==== The "Next" button is now **disabled** until all required product attributes are selected, ensuring behavior is consistent with normal products. --- Issue 2: Combo Product Quantity Mismatch ================================== Before this commit: ------------------------- When increasing the quantity of a combo product before adding it to the cart, only `1 unit` was added due to a hardcoded quantity value. After this commit: ----------------------- - The hardcoded quantity of `1` was removed. - The selected quantity is now correctly added to the cart, preserving user input. Task-4592610