Friday, March 21, 2025
10 changes
1 change
Resolved issues and error corrections
The VoIP interface now displays country flags correctly no matter which page users open it from. This fixes a visual issue caused by flag image links only working from the home page.
Original PR description
When opening the VoIP interface from any page other than the home page, it doesn't show the flag as the uri for the flag was relative. This commit fixes that by changing the relative uri (`base/...) to an absolute uri.
9 changes
Resolved issues and error corrections
This fixes a visual issue in the Discuss sidebar where pinned thread entries were all treated as the first item in the list. The change restores the intended styling so users can scan pinned conversations more clearly.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/200310 PR above made a small typo: it removed `isCategoryOpen` which was alias for `thread.discussAppCategory.open` in template, but this was still mistakenly used in the `isFirst` props of a sub-thread template. As a result, the list of pinned thread was not shown correctly, as all items we wrongly flagged as the first item. Before / After  
The website editor now shows the Donation Button preview correctly while it is being dragged. This prevents extra prefilled donation buttons from appearing in the drag preview, making the editing experience clearer and less confusing.
Original PR description
**[FIX] website_payment: fix donation button preview on drag** Steps to reproduce: - Enter edit mode. - If not already installed, click the "Donation Button" in the snippet menu to install the "website_payment" app. - Start dragging the "Donation Button" without dropping it onto the page to display its preview. - Bug: Prefilled buttons are displayed in the preview when they shouldn't be. This bug was introduced by commit [1], where the prefilled buttons were added to the "s_donation" snippet template so that they would be visible in the "s_donation" preview in the snippets dialog. Unfortunately, this change also made them visible for the inner "Donation Button" snippet, which shouldn't be the case. [1]: https://github.com/odoo/odoo/commit/edf81c13d8f2f6d29a77d68cbfa0dc9216da3c2a
This fixes an error that occurred when selling a physical gift card in Point of Sale after removing the expiration date. Staff can now create valid physical gift cards with no expiry date, avoiding checkout interruptions.
Original PR description
Creating a physical gift card in the PoS without an expiration date led to an Odoo error.
Steps to reproduce:
-------------------
* Open a PoS
* Add a gift card
* Click on Sell physical gift card?
* Input a unique code and a value
* Remove the default expiration date
* Click on Add Balance
> Observation:
TypeError: value.toFormat is not a function
at serializeDate
Why the fix:
------------
the addBalance() method was trying to format the expiration date with serializeDate(this.state.expirationDate) without verrifing that it exists.
opw-4623141
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update fixes an automated sales test so it confirms a quotation using the visible confirmation button instead of relying on a navigation shortcut that is unavailable in the test flow. This improves reliability of the test coverage for quotation handling without changing day-to-day user behavior.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/194593 This PR added test coverage for the fix, but it failed at the last step '.o_menu_brand' to confirm the quotation. The intent is to save to quotation, but it relies on implicit action to quit (and save) the record from the app icon, which acts as a "go to main page of app". This button is not present in tours for some reasons, hence the step failing. This commit fixes it by manually confirming the quotation by clicking on the dedicated button, which is present in practice and in the tour. runbot-161274 In practice  In tour <img width="558" alt="Screenshot 2025-03-21 at 11 13 11" src="https://github.com/user-attachments/assets/8013a70a-0a0a-4a73-8820-d49678af84a5" />
The eCommerce product combo configurator no longer shows internal product reference codes to website visitors. This keeps backend-only information out of the storefront and presents a cleaner shopping experience.
Original PR description
This reference should only be shown in the backend.
Draft invoice PDFs now show only the draft invoice label instead of including a temporary placeholder invoice number. This prevents customers or staff from seeing misleading invoice numbers before an invoice is finalized.
Original PR description
### Steps to reproduce: - Create a new draft invoice - In the actions click "PDF without Payment" - In the PDF the name is "Draft Invoice INV/2023/0001" - It should only be "Draft Invoice" ### Cause: "INV/2023/0001" is the placeholders in the XML. It is displayed because the name for draft moves is no longer '/' but null. ### Solution: Change the condition to also check if `o.name` exists. opw-4607518
This fixes sale orders so global or fixed discount lines are automatically removed when all product lines are deleted. It prevents leftover discounts from remaining on empty orders, keeping order totals and records cleaner for sales teams.
Original PR description
## Description of the issue/feature this PR addresses: Ensured that the discount line is removed when all products are deleted from the sale order. ## Current behavior before PR: have a look at [this](https://excalidraw.com/#json=FsEs8xRNq5druyUCVA0yF,8aHZoS4w1p8SWKRPr4WPEQ) ## Desired behavior after PR is merged: Discount(Global/Fixed) lines will be deleted if there are no products in the order line --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adjusts Odoo's internal unit tests to work better with recent Hoot testing changes. It helps ensure test results are more accurate and reliable, reducing the risk of missed issues during development without affecting customer-facing features.
Original PR description
## Pull Request HOOT (PRHOOT) 29 This pull requests brings various improvements and fixes to Hoot and the Odoo unit test ecosystem. See the different commit messages for more details. Note: these changes are made in stable to avoid having to support multiple versions of the HOOT API. As such, these changes are intended to be strictly limited to unit tests as to not put the rest of the code base at risk. Community: https://github.com/odoo/odoo/pull/199461 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adds a test to ensure that when a bank statement line linked to a batch payment is reset, the related payments are also reset correctly. This helps prevent accounting inconsistencies, especially for payments that do not use an outstanding account.
Original PR description
Test that resetting a statement line that was merged with a batch payment also resets the payments, especially for payments without an outstanding account. It wasn't the case because there is no real link between the batch payment and the statement line, and neither between the statement line and the payment itself. The fix is in community.