Tuesday, March 25, 2025
15 changes · master
Enhancements to existing features
This update removes unused animation code from the VoIP menu area. It helps keep the interface code cleaner and avoids relying on an animation name that browsers do not recognize, with no expected change for users.
Original PR description
This commit removes the unused `o-voip-SystrayItem-vibrateAnimation` CSS animation and also removes the `vibrate` animation as it is an unknown CSS animation-name. Reference: - https://developer.mozilla.org/en-US/docs/Web/CSS/animation
This update streamlines automated testing across Point of Sale and related country-specific modules by removing duplicate checks, merging overlapping test scenarios, and splitting large tests into easier-to-maintain parts. It helps improve test reliability and maintainability without changing business functionality.
Original PR description
Cleaning all tours and tests in PoS related modules, removing duplicated tests and tours, and fixing some issues in the tests. Deleted / merged tests: - The test `test_01_pos_basic_order` is now splitted in separate method to easier debug and maintain. - The test `test_06_pos_discount_display_with_multiple_pricelist` is merged with `test_01_pos_basic_order` in `pos_pricelist` tour. - The test `test_product_combo_price` is removed since test content is duplicate in `test_07_product_combo` which also tests prices. - The test `test_autofill_cash_count` is merged with `test_properly_display_price` since it is a sub-test of it. - The test `test_product_search_2` is merged with `test_product_search` - Tests `test_rounding_up`, `test_rounding_down` and `test_rounding_half_up` are deleted since class `TestPosCashRounding` already tests rounding. taskId: 4467373
The barcode interface has been tidied up by removing an animation that was incorrectly defined and therefore not working. This reduces unnecessary styling code without changing how users interact with barcode operations.
Original PR description
This commit removes the malformed (and thus unapplied) `highlighting-flash-primary` CSS animation.
In a nutshell, the animation as written in SCSS doesn't interpret the `theme-color("primary")` call and write it as-is in the generated CSS... which, in return, is an unknown CSS value.
Note: this commit also removes the `highlighting-flash-white` animation as it isn't used.Resolved issues and error corrections
The payroll accounting test for Belgian salary advances now includes the required journal setup, so it no longer fails when demo data is not installed. This improves reliability of automated testing without changing behavior for end users.
Original PR description
Before this fix, the salary advance test was failing when no demo data was installed due to a missing journal on the structure. This commit adds a journal to the structure to avoid test failure without demo data. task-4672827
Code cleanup and technical improvements
This draft refactor removes remaining field service references from several business areas, helping simplify the product and reduce maintenance around a discontinued scope. The change touches manufacturing work orders, sales planning, spreadsheets, and Studio tests, with limited direct impact expected for end users.
Miscellaneous changes
Steps to reproduce: - Open Expenses. - Upload a sample expense pdf. The blue ribbon shows up saying “” - Do not click on the refresh button. Instead, put in some value for the amount and submit and approve the expense. - Go back to the expenses list view Issue: Notice this expense is at the top of the list and grayed out Cause: The order is determined by the extract_state_processed field: https://github.com/odoo/enterprise/blob/ba06e216ab73c73e3a67fd917623c6ad357b869f/hr_expense_ext
Original PR description
Steps to reproduce: - Open Expenses. - Upload a sample expense pdf. The blue ribbon shows up saying “” - Do not click on the refresh button. Instead, put in some value for the amount and submit and…
Steps to reproduce: - Open Expenses. - Upload a sample expense pdf. The blue ribbon shows up saying “” - Do not click on the refresh button. Instead, put in some value for the amount and submit and approve the expense. - Go back to the expenses list view Issue: Notice this expense is at the top of the list and grayed out Cause: The order is determined by the extract_state_processed field: https://github.com/odoo/enterprise/blob/ba06e216ab73c73e3a67fd917623c6ad357b869f/hr_expense_extract/models/hr_expense.py#L21 An expense is muted when this field is set to `True`: https://github.com/odoo/enterprise/blob/1df090289f3c45c200d133734989a6d9a8073145/hr_recruitment_extract/views/hr_applicant_views.xml#L67 Solution: We override `iap_extract` method https://github.com/odoo/enterprise/blob/2e3113562309bf4d440e12ab09eaf94d0b302f1f/iap_extract/models/extract_mixin.py#L69 If the expense is not in draft, it indicates that the process continued without waiting for the extraction process to complete (values were manually entered). To ensure a consistent extraction state, we extend the "Check OCR Status" logic to prevent an infinite waiting_extraction status. opw-4239404 Forward-Port-Of: odoo/enterprise#80705 Forward-Port-Of: odoo/enterprise#75202
This fixes an internal automated test issue in the recruitment appointment module when demo data is not available. It helps keep validation checks reliable so future updates can be tested without false failures.
Original PR description
runbot-160911
Spreadsheet test helpers now use a faster pivot insertion approach by default. This reduces waiting time during automated test runs, helping developers validate spreadsheet changes more quickly without changing customer-facing behavior.
Original PR description
This commit changes the default insertion mode of the pivot in the tests helpers, to use the dynamic pivot instead of the static one. It allows to avoid to wait for the pivot to be loaded before actually inserting it. The gain is about 20% of the time for spreadsheet tests, 15% for spreadsheet_edition tests (enterprise) and 5% for the whole spreadsheet test suite. Task: 4655122
Steps to reproduce: - With an ES company setup - Create and confirm invoice with: - Spanish partner - Amount > 3005.06 (mod347 threshold) - Type for mod 347: Regular operation - Create and confirm a jounral entry with: - Payable account, debit 4000 - Receivable account, credit 4000 - Type for mod 347: Regular operation - Check Mod 347 Tax Report Issue: 'Total number of persons and entities' shows 0 This occurs because some lines of mod 347 report need to be grouped by
Original PR description
Steps to reproduce: - With an ES company setup - Create and confirm invoice with: - Spanish partner - Amount > 3005.06 (mod347 threshold) - Type for mod 347: Regular operation - Create and confirm a jounral entry with: - Payable account, debit 4000 - Receivable account, credit 4000 - Type for mod 347: Regular operation - Check Mod 347 Tax Report Issue: 'Total number of persons and entities' shows 0 This occurs because some lines of mod 347 report need to be grouped by partner, only keeping the partners whose balance for the line is above 3005.06€, so we first get all the partners that match the domain but don't reach the threshold. We exclude these partners with a 'NOT IN' clause. However, when the partner is not set, a NULL values is retrieved causing the clause to be evaluated NULL instead of False and the total count will be 0 opw-4544950 Forward-Port-Of: odoo/enterprise#81954 Forward-Port-Of: odoo/enterprise#81687
Forward-Port-Of: odoo/enterprise#82033 Forward-Port-Of: odoo/enterprise#81564
Original PR description
Forward-Port-Of: odoo/enterprise#82033 Forward-Port-Of: odoo/enterprise#81564
Steps to reproduce: 1. In recruitment app, generate an offer for an applicant. 2. Send the offer by email and sign it by both parties. Bug: The generated sign request is not linked to the offer using the reference_doc field. Fix: Link the offer to the sign request upon creation in the submit endpoint. task-4607475 Forward-Port-Of: odoo/enterprise#80391
Original PR description
Steps to reproduce: 1. In recruitment app, generate an offer for an applicant. 2. Send the offer by email and sign it by both parties. Bug: The generated sign request is not linked to the offer using the reference_doc field. Fix: Link the offer to the sign request upon creation in the submit endpoint. task-4607475 Forward-Port-Of: odoo/enterprise#80391
Before this commit: The "I Take It" button visibility was inconsistent across different view because different conditions were used to determine its visibility in each view. After this commit: This commit enhance the visibility of the "I Take It" button now it has consistent visibility across the views by follow same condition for every view. task-4455488 Forward-Port-Of: odoo/enterprise#81950 Forward-Port-Of: odoo/enterprise#79319
Original PR description
Before this commit: The "I Take It" button visibility was inconsistent across different view because different conditions were used to determine its visibility in each view. After this commit: This commit enhance the visibility of the "I Take It" button now it has consistent visibility across the views by follow same condition for every view. task-4455488 Forward-Port-Of: odoo/enterprise#81950 Forward-Port-Of: odoo/enterprise#79319
This test tour fails on sunday. Reason: - Here in the test create timesheets in previous week to check overtime in timesheets. - The formula works as today - current week day --> gives monday of this week - But on when it sunday it gives monday of previous week. - Timesheets are further created the previous weeks if given monday. - But we only go one week previous to check Fix: - Selecting next monday if weekday is sunday as we go back one previous week in tour. task-4667966
Original PR description
This test tour fails on sunday. Reason: - Here in the test create timesheets in previous week to check overtime in timesheets. - The formula works as today - current week day --> gives monday of this week - But on when it sunday it gives monday of previous week. - Timesheets are further created the previous weeks if given monday. - But we only go one week previous to check Fix: - Selecting next monday if weekday is sunday as we go back one previous week in tour. task-4667966 Forward-Port-Of: odoo/enterprise#81975
Since there is no else condition, the rule raises an error on payslip computation. Forward-Port-Of: odoo/enterprise#81979
Original PR description
Since there is no else condition, the rule raises an error on payslip computation. Forward-Port-Of: odoo/enterprise#81979
Issue: cannot groupby status on appraisal analysis neither filter by state in graph view Solve: update the state field values of report to match the original model Task: 4653149 Forward-Port-Of: odoo/enterprise#81600
Original PR description
Issue: cannot groupby status on appraisal analysis neither filter by state in graph view Solve: update the state field values of report to match the original model Task: 4653149 Forward-Port-Of: odoo/enterprise#81600