Wednesday, April 2, 2025
13 changes · saas-17.4
Miscellaneous changes
Currently, An error occurs when quick create an hr leave (Time Off Request). Step to produce: - Install the `hr_holidays` module. - Enable debug mode. - Open Settings / Technical / Resource / Resource Time Off, Create a new record, and attempt to quick create a 'Time Off Request'. Traceback: ``` File "/home/odoo/odoo/community/odoo/http.py", line 1788, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "/home/odoo/odoo/community/odoo/service/m
Original PR description
Currently, An error occurs when quick create an hr leave (Time Off Request). Step to produce: - Install the `hr_holidays` module. - Enable debug mode. - Open Settings / Technical / Resource /…
Currently, An error occurs when quick create an hr leave (Time Off Request).
Step to produce:
- Install the `hr_holidays` module.
- Enable debug mode.
- Open Settings / Technical / Resource / Resource Time Off, Create a new record, and attempt to quick create a 'Time Off Request'.
Traceback:
```
File "/home/odoo/odoo/community/odoo/http.py", line 1788, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/home/odoo/odoo/community/odoo/service/model.py", line 133, in retrying
result = func()
File "/home/odoo/odoo/community/odoo/http.py", line 1816, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/home/odoo/odoo/community/odoo/http.py", line 2020, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/home/odoo/odoo/community/odoo/addons/base/models/ir_http.py", line 221, in _dispatch
result = endpoint(**request.params)
File "/home/odoo/odoo/community/odoo/http.py", line 757, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/home/odoo/odoo/community/addons/web/controllers/dataset.py", line 24, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/home/odoo/odoo/community/addons/web/controllers/dataset.py", line 20, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/home/odoo/odoo/community/odoo/api.py", line 464, in call_kw
result = _call_kw_model(method, model, args, kwargs)
File "/home/odoo/odoo/community/odoo/api.py", line 435, in _call_kw_model
result = method(recs, *args, **kwargs)
File "/home/odoo/odoo/community/odoo/models.py", line 1708, in name_create
record = self.create({self._rec_name: name})
File "<decorator-gen-165>", line 2, in create
File "/home/odoo/odoo/community/odoo/api.py", line 414, in _model_create_multi
return create(self, [arg])
File "/home/odoo/odoo/community/addons/hr_holidays/models/hr_leave.py", line 937, in create
if mapped_validation_type[leave_type_id] == 'no_validation':
KeyError: None
```
The error occurs because the system attempts to access 'leave_type_id' from the `vals_list` at [1], But vals_list has no data.
Link [1]: https://github.com/odoo/odoo/blob/a1969de6e6a292b14ad1d19c256ead04dc202528/addons/hr_holidays/models/hr_leave.py#L945C17-L945C68
To resolve this issue, remove the `quick_create` option for `Time Off Request` field from the 'Resource Time Off' form view.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#199163Steps to reproduce: - Create a copy of the CRM lead dashboard - Go to the duplicated dashboard, change some global filter - Go to the CRM lead original dashboard => The global filter has the same value as the one in the duplicated dashboard - Try to change a global filter => The data is filtered, but nothing change in the global filter topbar This was caused by a faulty t-key, which was based on the filter id, which is not unique across dashboards. This commit changes the t-key to be base
Original PR description
Steps to reproduce: - Create a copy of the CRM lead dashboard - Go to the duplicated dashboard, change some global filter - Go to the CRM lead original dashboard => The global filter has the same value as the one in the duplicated dashboard - Try to change a global filter => The data is filtered, but nothing change in the global filter topbar This was caused by a faulty t-key, which was based on the filter id, which is not unique across dashboards. This commit changes the t-key to be based on the dashboard id and the filter id, so that the filter is unique across dashboards. Task: 4636672 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#204155 Forward-Port-Of: odoo/odoo#204110
Reconciliation model use case: - No auto-validate - No Match Invoice/bill fields set. --- Expected result: - The amls suggested should be as expected, i.e., do not filter for data that is not defined in the reconciliation model. --- See also PR: https://github.com/odoo/enterprise/pull/82560 Manual forward port of https://github.com/odoo/odoo/pull/194482 TT52146 Credits to: Victor Martinez <victor.martinez@tecnativa.com> --- I confirm I have signed the CLA and read t
Original PR description
Reconciliation model use case: - No auto-validate - No Match Invoice/bill fields set. --- Expected result: - The amls suggested should be as expected, i.e., do not filter for data that is not defined in the reconciliation model. --- See also PR: https://github.com/odoo/enterprise/pull/82560 Manual forward port of https://github.com/odoo/odoo/pull/194482 TT52146 Credits to: Victor Martinez <victor.martinez@tecnativa.com> --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#204165
In the xml we sent, we have to specify the unit code, there is mapping for that on the documentation: https://developer.nilvera.com/en/code-lists#birim-kodlari This commit will extend what has been done in the base edi module with the UOM_TO_UNECE_CODE dictionary. We added some new unit of measure and each unit of measure will be linked to a code. The default value is C62. task-4457115 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
In the xml we sent, we have to specify the unit code, there is mapping for that on the documentation: https://developer.nilvera.com/en/code-lists#birim-kodlari This commit will extend what has been done in the base edi module with the UOM_TO_UNECE_CODE dictionary. We added some new unit of measure and each unit of measure will be linked to a code. The default value is C62. task-4457115 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#193030
- adding a field to set the coretax UoM code from UoM form view - raise error when country is not set on the customer - use the main customer's address in invoice as address in e-Faktur instead of the main customer's - fix calculation for tax incde in price configuration - adding CustomDocMonthYear to the XML by parsing month and year from invoice_date ticket-4622364 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#20
Original PR description
- adding a field to set the coretax UoM code from UoM form view - raise error when country is not set on the customer - use the main customer's address in invoice as address in e-Faktur instead of the main customer's - fix calculation for tax incde in price configuration - adding CustomDocMonthYear to the XML by parsing month and year from invoice_date ticket-4622364 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#204126 Forward-Port-Of: odoo/odoo#203203
### Description of the issue/feature this PR addresses: There is no need to print the tax detail information when the invoice's currency is not the same as the company's currency. This change removes that part of the report, and it only affects the AR Invoice Legal report. This functionality was added to the account module and affects all the invoice reports, but we do not want them to be in the AR legal report. For more information about the extra tax detail in the company's currency, you
Original PR description
### Description of the issue/feature this PR addresses: There is no need to print the tax detail information when the invoice's currency is not the same as the company's currency. This change removes…
### Description of the issue/feature this PR addresses: There is no need to print the tax detail information when the invoice's currency is not the same as the company's currency. This change removes that part of the report, and it only affects the AR Invoice Legal report. This functionality was added to the account module and affects all the invoice reports, but we do not want them to be in the AR legal report. For more information about the extra tax detail in the company's currency, you can check this commit https://github.com/odoo/odoo/commit/8823e01040f9522947e5d11c7312d09c50867cc4 ### Current behavior before PR:  ### Desired behavior after PR is merged:  LATAM task 1329 / Adhoc ticket 88609 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#201084
- With a IT company, create a vendor bill with a line with the tax 22% G RC and set l10n_it_payment_method to MP01. - Export the bill with "Send Tax Integration". - Import the xml generated. The l10n_it_payment_method field is not set to MP01. In the l10n_it_edi_import_invoice, the l10n_it_payment_method field was not imported opw-4646816 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I
Original PR description
- With a IT company, create a vendor bill with a line with the tax 22% G RC and set l10n_it_payment_method to MP01. - Export the bill with "Send Tax Integration". - Import the xml generated. The l10n_it_payment_method field is not set to MP01. In the l10n_it_edi_import_invoice, the l10n_it_payment_method field was not imported opw-4646816 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#203232
Steps to reproduce: - Install the Website. - Enter edit mode. - Click on the "Add to Cart Button" snippet in the snippet menu. - Bug: The message displayed in the dialog is "Do you want to install the Add to Cart Button app?". This is incorrect; the app name should be the module name instead of the snippet name. This commit displays the module name as expected and slightly enhances the design of the dialog (line break before the link + add an arrow icon before the link to the app info).
Original PR description
Steps to reproduce: - Install the Website. - Enter edit mode. - Click on the "Add to Cart Button" snippet in the snippet menu. - Bug: The message displayed in the dialog is "Do you want to install the Add to Cart Button app?". This is incorrect; the app name should be the module name instead of the snippet name. This commit displays the module name as expected and slightly enhances the design of the dialog (line break before the link + add an arrow icon before the link to the app info). #### Preview | Before | |--------| |  | | After | |--------| |  | task-4434981 Forward-Port-Of: odoo/odoo#201873 Forward-Port-Of: odoo/odoo#201757
**Problem**: When the text is long, the switch for "Autoconvert to Relative Link" is not visible. **Solution**: Adjust CSS to properly display the switch when the text is long. **Before**:  **After**:  **Steps to Reproduce**: 1. Change language to **Dutch**. 2. Open the **website editor**. 3. Click on
Original PR description
**Problem**: When the text is long, the switch for "Autoconvert to Relative Link" is not visible. **Solution**: Adjust CSS to properly display the switch when the text is long. **Before**:  **After**:  **Steps to Reproduce**: 1. Change language to **Dutch**. 2. Open the **website editor**. 3. Click on any **link**. 4. Copy your current link and paste it into the link input to trigger the "Autoconvert to Relative Link" switch. - **Issue**: The switch is not visible. **opw-4558476** --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#204286 Forward-Port-Of: odoo/odoo#204244
Change VAT in invoice report if the invoice is set as cfdi to public to use a generic vat for both national and international clients to have more coherence with the xml that is generated for the invoice. task-4588311 Forward-Port-Of: odoo/enterprise#79775
Original PR description
Change VAT in invoice report if the invoice is set as cfdi to public to use a generic vat for both national and international clients to have more coherence with the xml that is generated for the invoice. task-4588311 Forward-Port-Of: odoo/enterprise#79775
Isuue: - When on a relatively slower network, if we double click the comments icon present on the social media post, the comments dialog box opens up twice. - Can be spotted easily on the runbot as well. Video of the issue https://drive.google.com/file/d/1abe7Cq3otsVNH4hGRHFV34jC3uIGHY6m/view?usp=drive_link Reason: - There is no existing mechanism present to prevent this kind of scenario. Fix: - We simply use a flag to prevent this. We set/reset the value as we desire. Task-418
Original PR description
Isuue: - When on a relatively slower network, if we double click the comments icon present on the social media post, the comments dialog box opens up twice. - Can be spotted easily on the runbot as well. Video of the issue https://drive.google.com/file/d/1abe7Cq3otsVNH4hGRHFV34jC3uIGHY6m/view?usp=drive_link Reason: - There is no existing mechanism present to prevent this kind of scenario. Fix: - We simply use a flag to prevent this. We set/reset the value as we desire. Task-4184968 Forward-Port-Of: odoo/enterprise#82457 Forward-Port-Of: odoo/enterprise#82411
Reconciliation model use case: - No auto-validate - No Match Invoice/bill fields set. --- Expected result: - The amls suggested should be as expected, i.e., do not filter for data that is not defined in the reconciliation model. --- See also PR: [odoo/odoo#203994](https://github.com/odoo/odoo/pull/204165) Manual forward port of odoo/odoo#194482 TT52146 Credits to: Victor Martinez <victor.martinez@tecnativa.com> Forward-Port-Of: odoo/enterprise#82560
Original PR description
Reconciliation model use case: - No auto-validate - No Match Invoice/bill fields set. --- Expected result: - The amls suggested should be as expected, i.e., do not filter for data that is not defined in the reconciliation model. --- See also PR: [odoo/odoo#203994](https://github.com/odoo/odoo/pull/204165) Manual forward port of odoo/odoo#194482 TT52146 Credits to: Victor Martinez <victor.martinez@tecnativa.com> Forward-Port-Of: odoo/enterprise#82560
There is a special case where users can make invoices "B" to foreign customers. However, we are not allowing to create credit or debit notes "B" to adjust those invoices. This PR adds the possibility to create "B" credit and debit notes (code "6" and "7" respectively) for foreign customers. _**Behavior before this PR:**_ An error message like the following was raised when validating the credit/debit note on AFIP: ``` Esto es lo que obtenemos: Observaciones de validación de la AFIP: *
Original PR description
There is a special case where users can make invoices "B" to foreign customers. However, we are not allowing to create credit or debit notes "B" to adjust those invoices. This PR adds the possibility…
There is a special case where users can make invoices "B" to foreign customers. However, we are not allowing to create credit or debit notes "B" to adjust those invoices. This PR adds the possibility to create "B" credit and debit notes (code "6" and "7" respectively) for foreign customers. _**Behavior before this PR:**_ An error message like the following was raised when validating the credit/debit note on AFIP: ``` Esto es lo que obtenemos: Observaciones de validación de la AFIP: * Code 10015: Para facturas B (CbteDesde igual a CbteHasta) mayor o igual a $417288, DocTipo debe ser uno de los valores devueltos por el método FEParamGetTiposDoc distinto a 99 y DocNro deberá ser mayor a 0. * Code 10015: Factura B (CbteDesde igual a CbteHasta), DocTipo: 80, DocNro 0 no se encuentra registrado en los padrones de AFIP y no corresponde a una cuit pais. ``` This happened because we have to send the "CUIT país" (vat number for the foreign country) as the customer vat so the document can be validated on AFIP. For invoices, we had the logic in the code to look for the country vat and set it in the XML we send to the organism, so I just added the related documents codes so they follow the same flow. **_Behavior after this PR:_** The credit/debit note should be validated on AFIP. **_Steps to reproduce the error:_** 1) Install l10n_ar_edi 2) Set a testing enviroment 3) Create an invoice "B" to a foreign customer. This customer won't have any VAT set. 4) Validate the invoice 5) Create a credit note from the invoice that you created before. 6) Try to validate it, and check that an error message is raised. Forward-Port-Of: odoo/enterprise#80169