Monday, April 7, 2025
3 changes · saas-17.4
Resolved issues and error corrections
Point of Sale now handles scanned combo product barcodes correctly by opening the combo selection popup instead of adding an incomplete order line. This helps cashiers process combo offers accurately when barcodes are printed or scanned at checkout.
Original PR description
It is currently not possible to scan a combo. To reproduce the issue: (Use demo data) 1. Point of Sale > Products > Product Variantes, edit Office Combo - Add a barcode 2. Start the PoS Furniture…
It is currently not possible to scan a combo. To reproduce the issue: (Use demo data) 1. Point of Sale > Products > Product Variantes, edit Office Combo - Add a barcode 2. Start the PoS Furniture Shop 3. Scan the barcode Error: a line is added on the left-side panel. Scanning the combo should actually open a popup so that the PoS user can select the products. About the behaviour: since [1], the barcode field is invisible on the template form of a combo. It is even mentioned on the excalidraw. However, the field is still visible on all other views. Moreover, there isn't any constraint or anything to prevent such a template from having a barcode. Discussed with the PO, for spec clarifications: > Scanning a combo wasn't really planned in the first place. > I can imagine the case where they print the barcodes on the side. > It's OK if it's scannable, but that doesn't mean we should make > the field visible About the issue: quite simple, when scanning the barcode, it leads to https://github.com/odoo/odoo/blob/6a6b70c9bf2420380ae91ca8f5b21f2bfbc1a5b9/addons/point_of_sale/static/src/app/screens/product_screen/product_screen.js#L209-L213 Where the third argument is `false`, cf `needToConfigure`: https://github.com/odoo/odoo/blob/7a2923af64bd196a8271af4c99a37ac8ce3e15f8/addons/point_of_sale/static/src/app/models/product_product.js#L39-L49 The call to `addLineToCurrentOrder` will lead to `addLineToOrder`, where the parameter `configure` is `false` (as explained just above). As a result, even if the product is correctly identified as a combo, we don't open the popup https://github.com/odoo/odoo/blob/14d51bd960d7dd49cb234722b7725b98549feb04/addons/point_of_sale/static/src/app/store/pos_store.js#L735-L742 Taking the `configure` parameter doesn't seem to make sense with combo products, as these ones always stand for some other products that the user should select. [1] https://github.com/odoo/odoo/commit/65652c73ba5331f77911186543062dfddf50f077 OPW-4474214
Autofilling date values in exploded spreadsheet pivots now handles week, month, or quarter groupings when crossing year boundaries. This prevents crashes and keeps date autofill usable by looping bounded date values correctly.
Original PR description
Issue : Given a pivot grouped by date with anything else than year as aggregate (I tried with week, quarter and month), Given the pivot is exploded When I autofill the date cells and the date passes from one year to another, it crashes hard New behaviour: For bounded date fields, the autofill loop around when reaching the upper bound. Task: 4700703 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes a crash when users autofill date values in expanded spreadsheet pivots grouped by week, month, or quarter across a year boundary. Date autofill now wraps within valid bounds, helping users continue spreadsheet analysis without interruption.
Original PR description
Issue : Given a pivot grouped by date with anything else than year as aggregate (I tried with week, quarter and month), Given the pivot is exploded When I autofill the date cells and the date passes from one year to another, it crashes hard New behaviour: For bounded date fields, the autofill loop around when reaching the upper bound. Task: 4700703