Friday, April 11, 2025
2 changes
Resolved issues and error corrections
Notification emails for sales quotations and orders no longer show the portal viewing button to followers who do not have portal access. This prevents confusion from sending those contacts to a login page they cannot use, while still keeping the button available for portal-enabled customers.
Original PR description
**Description of the issue/feature this PR addresses:** Currently all followers without portal access are able to see the button, in the email notification, that redirects to the portal (to see the…
**Description of the issue/feature this PR addresses:** Currently all followers without portal access are able to see the button, in the email notification, that redirects to the portal (to see the quotation or sale order). This may be confusing and not logic, as the button will redirect them to the login page of the portal, to which they do not have access. **Current behavior before PR:** Currently the followers without portal access get access to the button to view the order or quotation, as the follower group is configured to have 'has_button_access' to True. That leads them to the login page of the portal. **Steps to reproduce** 1. Configure odoo to be able to send out emails. 2. Install sale_management. 3. Create a sale order for a customer and add as follower another partner that has no portal access. This follower needs to have an email you have access to. 4. Send a message to the follower. 5. Test in the received email that the "View Quotation/Order" button is shown and when clicked, the user is redirected to the login page. **Desired behavior after PR is merged:** Only followers with portal access, which will be categorized as "portal_customer" instead of "follower", will have access to the button. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The calendar's Share Availabilities menu now only shows appointment types that are based on staff users. This prevents resource-based options, such as room or table bookings, from appearing in a menu where they do not apply.
Original PR description
Steps to reproduce: 1) Open the Appointment module without loading demo data. 2) Create a resource-based appointment type using the helper (e.g., 'Book a Resource' or 'Table Booking'). 3) Open the calendar and check the 'Share Availabilities' dropdown menu—resource-based appointments appear there. Issue: Resource-based appointments should not be visible in the dropdown menu. Technical: We have set default value of `staff_user_ids` as self user. Inside the `appointment_get_user_appointment_types`'s domain we only specified, `staff_user_ids` but while creating a resource based appointment from the Helper, we directly select, `schedule_based_on` as `resources`, thus will not see `staff_user_ids` in view, there for its compute will never called, and we will get its default value, as the result that appointment will be valid as per `appointment_get_user_appointment_types`'s domain. After this PR: Only User based appointments will be displayed. Task-4680418