Tuesday, April 15, 2025
3 changes · saas-17.4
Resolved issues and error corrections
This update tidies Swiss localization screens by documenting hidden technical fields that are still needed for compatibility checks. It helps keep stable-version tests passing while avoiding disruption to customized views.
Original PR description
Before this commit, several invisible fields were present in the views in `l10n_ch`, whereas after https://github.com/odoo/odoo/pull/162009 these fields need to be either justified or removed. The needed fields are fetched automatically after https://github.com/odoo/odoo/pull/137031. This commit adds a comment to each field so that the tests pass in stable versions, to avoid potential issues with inheritance in custom views. We will removes the unnecessary invisible fields in master. opw-4629332 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Log notes posted on a record from a chat window will now remain as separate entries instead of being merged together. This makes record discussions clearer and helps users avoid missing individual internal notes.
Original PR description
Purpose of this commit: This commit aims to restrict the log notes to not be squashed when posted on a record from a chat window. task-4718225
A test setup for timesheet and holidays was corrected so it uses the right employee and user relationship when creating leave records. This prevents internal automated tests from failing after stricter access rules were applied, helping keep the module stable without changing business behavior.
Original PR description
https://runbot.odoo.com/odoo/error/163099 This issue became visible as part of the change to test ACLs (removal of demo data, possibly change to groups too) as well as running the "single app tests" on *every module*, not just the apps. The issue is that `self.Requests.user` and `self.employee_user` are unrelated (the amazingly named `self.employee_user` doesn't even have a user). On leave creation, this triggers the rule `hr_leave_rule_employee_update` which checks if: - The current user is the employee's, which is not the case because the employee doesn't have a user. - Or the current user is the employee's leave manager, which is also not the case because the employee does not have a leaves manager. As a result the creation of the leaves fails immediately. Fix in 17.4 as the test was introduced in #53940 which was merged in (what would become) 17.3, even though the test setup means it might not be possible to trigger there because of all the demo messing with groups.