Tuesday, April 29, 2025
4 changes · saas-18.3
Resolved issues and error corrections
Bank reconciliation now handles statement groups that do not include a balance, preventing an error that could interrupt users reviewing bank statement lines. Invalid statement groups are also clearly highlighted so users can identify records that need attention.
Original PR description
The aim of this commit is fixing a traceback when we have a statement group with no balance passed as props. It could happen when we have statement lines without any statement between 2 groups of statement lines with statement. This commit changes the component to set this props as optional (as before) and adds a new props "isValid" to put the label of the statement group in text-danger when the statement is not valid. no task id
EC Sales List return checks now apply consistently across all relevant countries, not only Belgium. Warning messages are clearer, and a bug was fixed so failed checks are correctly recognized before submission.
Original PR description
[IMP] account_reports: EC Sales List return: checks improvement - Make the checks generic for all returns made for any EC Sales List, not just for Belgium - Improve the phrasing of the check messages [FIX] account_reports: EC Sales List generic check: wrong warning keys The account_reports prefix was missing ; so the check was never considered a failure.
This update fixes an automated test for the VoIP Do Not Disturb selector that could fail because different environments format the AM/PM time spacing differently. It improves test reliability without changing the customer-facing VoIP behavior.
Original PR description
"Do not disturb selector changes state correctly with limited time" is failing with this error: ``` 9. [toBe] Failed to find 1 of "p" with text "Until Jan 1, 2025, 1:15 AM" (Timeout of 3 seconds). Found 0 instead. > Expected: true > Received: false ``` Depending on the environment, it seems that the time is sometimes formatted with a nonbreaking space before the AM, and sometimes not. This is likely the reason for the failure. This commit adapts the test in order to exclude the problematic space from the selector.
This update fixes internal test setup issues for fleet-related disallowed expense checks by ensuring the test user has the right fleet permissions. It helps prevent false test failures during validation without changing day-to-day product behavior.
Original PR description
Creating fleet objects requires being a fleet administrator or sudo. However because copying fleet objects (specifically vehicles) as well as posting moves *also* requires those rights, using sudo requires about 20 changes throughout the setup and tests. Maybe fleet will eventually want some more specificity in their test ACL management, but just setting the current user as fleet admin seems to do a good job while avoiding most of the mess. https://runbot.odoo.com/odoo/error/163135 https://runbot.odoo.com/odoo/error/181531 Backport of odoo/enterprise#84108