Saturday, May 3, 2025
2 changes · master
Miscellaneous changes
**[FIX] portal_rating: replace the old modal with the new one** This commit fixes the modal of the "portal rating composer". Before this commit when a message was post a new modal was added after the old one. So when we want to modify the review the old modal was displayed. In this commit we delete the old modal before adding the new one. Steps to reproduce: * Install website_sildes * Login as an internal user or portal user * Go to the website (if not already there) * Click to "Co
Original PR description
**[FIX] portal_rating: replace the old modal with the new one** This commit fixes the modal of the "portal rating composer". Before this commit when a message was post a new modal was added after the…
**[FIX] portal_rating: replace the old modal with the new one**
This commit fixes the modal of the "portal rating composer".
Before this commit when a message was post a new modal was added after
the old one. So when we want to modify the review the old modal was
displayed.
In this commit we delete the old modal before adding the new one.
Steps to reproduce:
* Install website_sildes
* Login as an internal user or portal user
* Go to the website (if not already there)
* Click to "Courses" menu
* Click on the "Basics of Gardening course"
* Click on "Add Review"
* Entre a review
* Click on "Post review"
* Click on "Edit Review"
=> Bug there is two modal in the DOM and the showed one is the oldest
modal.
---
**[FIX] website_slides: tour doesn't wait the modal to disappear**
This commit fixes the undeterministic error, the tour needs to wait that
the modal is closed to ensure that the change has been sent.
After that we can reload the page to see the message.
Note:
The following step
```
{
trigger: "a[id=review-tab]",
run: "click",
},
```
was overkill as we are already in "Reviews tab".
The goal of this step is to wait the modal to be closed.
This is now explicit.
runbot-error-161614
Original commit that add this undeterministic error:
https://github.com/odoo/odoo/commit/0e621e73219c3a081cce6874938474f2892b4762
---
**[FIX] website_slides: wait for end animation**
This commit fixes the undeterministic error, wait for the emoji to be
visible.
runbot-error-181751
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#208094Before the following commit-https://github.com/odoo/enterprise/commit/33216fa2a3d6a4728bfc96b52a4234d3f7edb1cc While installing `l10n_in_reports`, the Accounting module was auto installed. But after the above mentioned commit The Accounting module is not auto installed and the menu items for GSTR aren't invisible. In this commit, we add the depedency of Accounting in `l10n_in_reports` Forward-Port-Of: odoo/enterprise#84614
Original PR description
Before the following commit-https://github.com/odoo/enterprise/commit/33216fa2a3d6a4728bfc96b52a4234d3f7edb1cc While installing `l10n_in_reports`, the Accounting module was auto installed. But after the above mentioned commit The Accounting module is not auto installed and the menu items for GSTR aren't invisible. In this commit, we add the depedency of Accounting in `l10n_in_reports` Forward-Port-Of: odoo/enterprise#84614