Saturday, May 3, 2025
4 changes · saas-18.3
Resolved issues and error corrections
Installing the India reports module now also installs the Accounting module as expected. This ensures Indian GSTR menu items behave correctly and remain available only in the right accounting context.
Original PR description
Before the following commit-https://github.com/odoo/enterprise/commit/33216fa2a3d6a4728bfc96b52a4234d3f7edb1cc While installing `l10n_in_reports`, the Accounting module was auto installed. But after the above mentioned commit The Accounting module is not auto installed and the menu items for GSTR aren't invisible. In this commit, we add the depedency of Accounting in `l10n_in_reports`
Miscellaneous changes
**[FIX] portal_rating: replace the old modal with the new one** This commit fixes the modal of the "portal rating composer". Before this commit when a message was post a new modal was added after the old one. So when we want to modify the review the old modal was displayed. In this commit we delete the old modal before adding the new one. Steps to reproduce: * Install website_sildes * Login as an internal user or portal user * Go to the website (if not already there) * Click to "Co
Original PR description
**[FIX] portal_rating: replace the old modal with the new one** This commit fixes the modal of the "portal rating composer". Before this commit when a message was post a new modal was added after the…
**[FIX] portal_rating: replace the old modal with the new one**
This commit fixes the modal of the "portal rating composer".
Before this commit when a message was post a new modal was added after
the old one. So when we want to modify the review the old modal was
displayed.
In this commit we delete the old modal before adding the new one.
Steps to reproduce:
* Install website_sildes
* Login as an internal user or portal user
* Go to the website (if not already there)
* Click to "Courses" menu
* Click on the "Basics of Gardening course"
* Click on "Add Review"
* Entre a review
* Click on "Post review"
* Click on "Edit Review"
=> Bug there is two modal in the DOM and the showed one is the oldest
modal.
---
**[FIX] website_slides: tour doesn't wait the modal to disappear**
This commit fixes the undeterministic error, the tour needs to wait that
the modal is closed to ensure that the change has been sent.
After that we can reload the page to see the message.
Note:
The following step
```
{
trigger: "a[id=review-tab]",
run: "click",
},
```
was overkill as we are already in "Reviews tab".
The goal of this step is to wait the modal to be closed.
This is now explicit.
runbot-error-161614
Original commit that add this undeterministic error:
https://github.com/odoo/odoo/commit/0e621e73219c3a081cce6874938474f2892b4762
---
**[FIX] website_slides: wait for end animation**
This commit fixes the undeterministic error, wait for the emoji to be
visible.
runbot-error-181751
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#208094### Steps to reproduce: - In the settings enable: Click & Collect, Multi Steps Routes - Set up a a demo payment provider - Create a second warehouse for the company of your website - Create a storable product, put units in stock for WH2 and publish it on the website - As an anonymous portal user, add one unit to your chart using the "pickup in store" button > select warehouse 2 - Click on checkout fill the form and pay #### > The sale order was attached to the warehouse 1 and the associ
Original PR description
### Steps to reproduce: - In the settings enable: Click & Collect, Multi Steps Routes - Set up a a demo payment provider - Create a second warehouse for the company of your website - Create a…
### Steps to reproduce: - In the settings enable: Click & Collect, Multi Steps Routes - Set up a a demo payment provider - Create a second warehouse for the company of your website - Create a storable product, put units in stock for WH2 and publish it on the website - As an anonymous portal user, add one unit to your chart using the "pickup in store" button > select warehouse 2 - Click on checkout fill the form and pay #### > The sale order was attached to the warehouse 1 and the associated delivery is therefore erroneous. ### Cause of the issue: Once a product is added to the chart, the sale order is created and since you added it using the pick up in store option, the sale order's warehouse_id and pickup location will be correcty updated by these calls: https://github.com/odoo/odoo/blob/785ea79c9ccd655079abeb4b13806e8174968dc3/addons/website_sale_collect/controllers/delivery.py#L22-L36 https://github.com/odoo/odoo/blob/785ea79c9ccd655079abeb4b13806e8174968dc3/addons/website_sale_collect/models/sale_order.py#L34-L36 However, during the checkout you will set a `partner_id` on the SO this will mark the `warhouse_id` field as a field to recompute because of the chain of dependencies of its compute methods: https://github.com/odoo/odoo/blob/785ea79c9ccd655079abeb4b13806e8174968dc3/addons/sale/models/sale_order.py#L463-L464 https://github.com/odoo/odoo/blob/785ea79c9ccd655079abeb4b13806e8174968dc3/addons/sale_stock/models/sale_order.py#L185-L186 And, the computed value of the `warehouse_id` will then override the current one.. opw-4737862 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#208271 Forward-Port-Of: odoo/odoo#208056
Versions -------- - 17.0+ Steps ----- 1. Create a product with 3 attributes; 2. add a never-create multi-select attribute; 3. archive the first two variants; 4. publish the product to eCommerce; 5. open /shop. Issue ----- > 500: Internal Server Error Cause ----- Commit 30994723e9ee5 updated the `_cartesian_product` method to handle `multi`-type attributes. When these are on the last attribute line, the method will yield the current partial combination. Issue is when conti
Original PR description
Versions -------- - 17.0+ Steps ----- 1. Create a product with 3 attributes; 2. add a never-create multi-select attribute; 3. archive the first two variants; 4. publish the product to eCommerce; 5.…
Versions -------- - 17.0+ Steps ----- 1. Create a product with 3 attributes; 2. add a never-create multi-select attribute; 3. archive the first two variants; 4. publish the product to eCommerce; 5. open /shop. Issue ----- > 500: Internal Server Error Cause ----- Commit 30994723e9ee5 updated the `_cartesian_product` method to handle `multi`-type attributes. When these are on the last attribute line, the method will yield the current partial combination. Issue is when continuing after the `yield`, it attempts to get the `current_ptav_index` from the `current_line_values` recordset, which is empty for `multi`-type attributes. This causes an `IndexError`. Solution -------- Only assign the `current_ptav` variable if `current_line_values` is not falsey, i.e. isn't on a `multi` attribute line. Because `current_ptav_index` will always be `-1` in this scenario, it will skip over the conditional branches where `current_ptav` gets used, and instead go to either `continue` or `break`. opw-4653696 Forward-Port-Of: odoo/odoo#203093