**Steps to reproduce:** - Install Accounting - Create a product: * Product Name: XYZ * Internal Reference: 1234 - Create a second product with the same name: * Product Name: XYZ * Internal Reference: 5678 - Go to "Accounting / Vendors / Bills" - Upload a Peppol BIS Billing 3.0 XML containing 2 invoice lines with the created products: `<cbc:Name>XYZ</cbc:Name>` `<cac:SellersItemIdentification><cbc:ID>1234</cbc:ID></cac:SellersItemIdentification>` and `<cbc:Name>XYZ</cbc:Name>`

**Steps to reproduce:**
- Install Accounting
- Create a product:
  * Product Name: XYZ
  * Internal Reference: 1234
- Create a second product with the same name:
  * Product Name: XYZ
  * Internal Reference: 5678
- Go to "Accounting / Vendors / Bills"
- Upload a Peppol BIS Billing 3.0 XML containing 2 invoice lines with the created products:
`<cbc:Name>XYZ</cbc:Name>`
`<cac:SellersItemIdentification><cbc:ID>1234</cbc:ID></cac:SellersItemIdentification>` and
`<cbc:Name>XYZ</cbc:Name>`
`<cac:SellersItemIdentification><cbc:ID>5678</cbc:ID></cac:SellersItemIdentification>`

**Issue:**
The 2 invoice lines of the generated bill have the same exact product, even when 2 different codes are provided for the products.

**Cause:**
In "_retrieve_product" method, a search is made on the name, the code and the barcode, but an "OR" operator is applied.
Not an "AND".
Several products may satisfy the domain but only the first one is returned.

**Solution:**
If several products matches the conditions, instead of directly returning the first one, try to select one based on the following
priority: barcode, code, name.
opw-4466322




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#209048
Forward-Port-Of: odoo/odoo#205739

**Steps to reproduce:** - Install account - Activate a foreign currency (e.g. EUR) - Set at least 2 different currency rates for date1 and date2 - Create an invoice: * Customer: [any] * Invoice Date: date1 * Currency: EUR * Invoice line: [any] - Save the invoice - Check debit and credit amounts in "Journal Items" tab - Change the price of the product and set "Invoice Date" to date2 - Save the invoice - Check debit and credit amounts in "Journal Items" tab **Issue:** The

**Steps to reproduce:**
- Install account
- Activate a foreign currency (e.g. EUR)
- Set at least 2 different currency rates for date1 and date2
- Create an invoice:
  * Customer: [any]
  * Invoice Date: date1
  * Currency: EUR
  * Invoice line: [any]
- Save the invoice
- Check debit and credit amounts in "Journal Items" tab
- Change the price of the product and set "Invoice Date" to date2
- Save the invoice
- Check debit and credit amounts in "Journal Items" tab

**Issue:**
The debit and credit amounts have been recomputed with the new currency rate, but the conversion has been applied on the old price.

**Cause:**
In "_sync_invoice" method, when the currency rate has changed, balance (and subsequently debit/credit) is recomputed from amount_currency.
However, in this case, balance should be recomputed completely because the line subtotal has changed and amount_currency is not up-to-date with it.

**Solution:**
Do not recompute balance based on amount_currency when price_subtotal of a line has changed.
In that case, it will be recomputed anyway.

opw-4658156



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#207905

Fixes two issue with EMV QR generation: - The regex applied on comments is wrong and actually does nothing. - VietQR allows less character than that general regex, so we filter it more. opw-4671523 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#208956

Fixes two issue with EMV QR generation:
- The regex applied on comments is wrong and actually does nothing.
- VietQR allows less character than that general regex, so we filter it more.

opw-4671523

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#208956

ISSUE: When you remove the user from an employee all the linked vehicles are removed as `work_contact_id` is written by the new value before updating the fleet model REPRODUCE: - create a vehicle and link it an employee with user - remove the user from the employee - employee and driver is removed from the vehicle As the issue of persistent 'work_contact_id' on employee has been fixed, all the updates are made auto and these extra code interduce the wrong behavior Task: 4680261 -

ISSUE: When you remove the user from an employee
all the linked vehicles are removed as `work_contact_id` is written by the new value before updating the fleet model

REPRODUCE:
- create a vehicle and link it an employee with user
- remove the user from the employee
- employee and driver is removed from the vehicle

As the issue of persistent 'work_contact_id' on employee has been fixed, all the updates are made auto and these extra code interduce the wrong behavior

Task: 4680261

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#209298
Forward-Port-Of: odoo/odoo#206396

Commit odoo/odoo@abd909498e4fd relaxed the multi-company rule for hr.employee (more records are visible). Instead the action domains were updated to include the restricted company rules (see only from your company) The domains in the Employee dashboard was not updated though. It means the dashboard takes into account employees from other companies (as allowed by the ir.rule) opw-4777122 Forward-Port-Of: odoo/enterprise#84972

Commit odoo/odoo@abd909498e4fd relaxed the multi-company rule for hr.employee (more records are visible).

Instead the action domains were updated to include the restricted company rules (see only from your company)

The domains in the Employee dashboard was not updated though.

It means the dashboard takes into account employees from other companies (as allowed by the ir.rule)

opw-4777122

Forward-Port-Of: odoo/enterprise#84972

**Steps to reproduce:** - Install Accounting and l10n_lu_reports - Switch to a Luxembourgish company (e.g. LU Company) - Go to "Accounting / Reporting / Statement Reports / Profit and Loss" - Set custom date from "01/01/2025" to "31/12/2025" - Export XML **Issue:** In the exported XML, for "CA_BILAN" declaration section, the start date is set to "01/12/2025" instead of "01/01/2025". **Cause:** When generating the report values of that section, the options are recomputed with the co

**Steps to reproduce:**
- Install Accounting and l10n_lu_reports
- Switch to a Luxembourgish company (e.g. LU Company)
- Go to "Accounting / Reporting / Statement  Reports / Profit and Loss"
- Set custom date from "01/01/2025" to "31/12/2025"
- Export XML

**Issue:**
In the exported XML, for "CA_BILAN" declaration section, the start date is set to "01/12/2025" instead of "01/01/2025".

**Cause:**
When generating the report values of that section, the options are recomputed with the comparison filter.
This section is based on "Balance Sheet" report and recomputing the options of that report provides a different "from date" coming from "_init_options_date" method.

**Solution:**
Force the "from date" of the original options when using a custom range date.

opw-4737810

Forward-Port-Of: odoo/enterprise#85025
Forward-Port-Of: odoo/enterprise#84672

A previous commit 9b133b2cd03a726d330c87a1227903fc925b0ed5 restricted the view and actions we had on the accounting dashboard for a bank journal from a branch company, if the journal belongs to the parent company. In Odoo 17 the fix made sense, but in Odoo 18, the dashboard data added conflicts with another one, resulting in no data being displayed at all when the journal is connected to an online account. This PR adapts the initial fix to use the existing data (deprecate `show_bank_connec

A previous commit 9b133b2cd03a726d330c87a1227903fc925b0ed5 restricted the view and actions we had on the accounting dashboard for a bank journal from a branch company, if the journal belongs to the parent company.

In Odoo 17 the fix made sense, but in Odoo 18, the dashboard data added conflicts with another one, resulting in no data being displayed at all when the journal is connected to an online account.

This PR adapts the initial fix to use the existing data (deprecate `show_bank_connect` in favor of `display_connect_bank_in_dashboard`) and adds the 'credit' type journal in the condition for `show_sync_action` to be used by the dashboard data.

Forward-Port-Of: odoo/enterprise#84976

Steps to reproduce: - Raise Product Price Accuracy to 6 - Set Global Rounding - Fetch latest currency rate for USD from Bank of Mexico - Create a [TEST] Product with: - UNSPSC Category: 12141502 Magnesium Mg - UMT Aduana: kg - Make an Invoice as follows: - Customer: Deco Addict - Currency USD - Product: [TEST] - Price: 3,114.515000 - Qty UMT: 11 - Incoterm: EX WORKS - External Trade: Definitive - Confirm Invoice - Send CFDI Issue: Validation will fail with er

Steps to reproduce:
- Raise Product Price Accuracy to 6
- Set Global Rounding
- Fetch latest currency rate for USD from Bank of Mexico
- Create a [TEST] Product with:
  - UNSPSC Category: 12141502 Magnesium Mg
  - UMT Aduana: kg
- Make an Invoice as follows:
  - Customer: Deco Addict
  - Currency USD
  - Product: [TEST]
  - Price: 3,114.515000
  - Qty UMT: 11
  - Incoterm: EX WORKS
  - External Trade: Definitive
- Confirm Invoice
- Send CFDI

Issue: Validation will fail with error
"""
Code : CCE122
Message : El atributo cce20:ComercioExterior:TotalUSD no coincide con la suma de ValorDolares de las mercancías. """

In the xml, the ValorDolares for the sold item will be 3114.5150 but the attribute TotalUSD will be 3114.52 This occurs because ValorDolares are emitted as unrounded amount, but TotalUSD is rounded to 2 decimals. When working with 3+ digits the amounts might not add up correctly.
Note: Before version 18, ValorDolares (`product_values['total']`) amount was already rounded according to the currency decimals (2) and there was no issue

opw-4662692
opw-4686226

Forward-Port-Of: odoo/enterprise#84027

Issue: Syntax error is raised when applying period comparison on partner ledger report. Purpose of this PR: Group queries with the parentheses. Steps to Reproduce in Runbot: - install accounting - add period comparison to Partner Ledger Report - try to apply period comparison opw-4730435 Forward-Port-Of: odoo/enterprise#85074 Forward-Port-Of: odoo/enterprise#83652

Issue:
Syntax error is raised when applying period comparison on partner ledger report.

Purpose of this PR:
Group queries with the parentheses.

Steps to Reproduce in Runbot:
- install accounting
- add period comparison to Partner Ledger Report
- try to apply period comparison

opw-4730435

Forward-Port-Of: odoo/enterprise#85074
Forward-Port-Of: odoo/enterprise#83652