Sunday, May 11, 2025
8 changes · saas-18.3
Resolved issues and error corrections
Discuss message bubbles now have slightly rounder corners and a dedicated tail shape, making conversations look more polished and modern. Message borders were also adjusted for more consistent contrast, especially in mailbox-style card layouts.
Original PR description
### [FIX] mail: make discuss message bubble rounder Before this commit, the roundness of message bubble was 6px. Messaging app competitors have rounded bubble, around 7.5px, which looks better than Odoo discuss. This commit increases the roundness of discuss bubble to 7.5px, thanks to new `.o-rounded-bubble` classnames. ### [FIX] mail: add tail tip on non-squashed bubble Before this commit, the tail tip was simulated in a rudimentary way using non-rounded corner at the place of tail tip. This commit adds a dedicated tail element so this looks best, especially with message bubble now being rounder. Note that the message border has been adjusted to not make use of opacity, because the opacity color on tail looks different and also doesn't overlap well. Another benefit of this adjusted color is to have better contrast in message bubble with card layout like in mailboxes. Forward-Port-Of: odoo/odoo#209270
This update fixes intermittent test failures in the barcode manufacturing flow by making the automated test click a more stable part of the screen. It helps keep build checks reliable and reduces false alarms during development.
Original PR description
The tests `test_barcode_production_create` and `test_barcode_production_create_tracked_bom` sometime fail. This commit modifies their tour to avoid random fails by clicking on the kanban's article itself instead of one of its div child. runbot build error: [190625](https://runbot.odoo.com/odoo/runbot.build.error/190625) and [190613](https://runbot.odoo.com/odoo/runbot.build.error/190613)
Miscellaneous changes
Continuing some cleaning in various test classes to lessen setup and/or have it done in as few places as possible. Improve some asserts tools. Task-4224145: [marketing_automation] Improve test coverage Forward-Port-Of: odoo/odoo#209388 Forward-Port-Of: odoo/odoo#208720
Original PR description
Continuing some cleaning in various test classes to lessen setup and/or have it done in as few places as possible. Improve some asserts tools. Task-4224145: [marketing_automation] Improve test coverage Forward-Port-Of: odoo/odoo#209388 Forward-Port-Of: odoo/odoo#208720
This commit adds counters in the mobile discuss app navbar, so that it's much easier to find the right category containing unread and important conversations. - "Mailboxes" category shows the unread counter in inbox - All other categories show the counter of category, similary to the counter when folding a category in desktop discuss sidebar. Livechat tab reconciles for all livechats, as if there's only 1 livechat category - Unread channels do not show a counter, however the navbar item dis
Original PR description
This commit adds counters in the mobile discuss app navbar, so that it's much easier to find the right category containing unread and important conversations. - "Mailboxes" category shows the unread counter in inbox - All other categories show the counter of category, similary to the counter when folding a category in desktop discuss sidebar. Livechat tab reconciles for all livechats, as if there's only 1 livechat category - Unread channels do not show a counter, however the navbar item displays a dot (unread indicator), similarly to chat bubble and next to discuss sidebar item. Task-4781564 Before  After  Forward-Port-Of: odoo/odoo#209308
An error occurs when trying to send a reversed invoice to ZATCA if it included a downpayment that was also reversed. Steps to reproduce: - Install "Sales" and "Saudi Arabia - E-invoicing" apps. - Create a quotation and confirm it. - Create a downpayment and post it to ZATCA. - Create an invoice **A** including the downpayment and post it. - Reverse the downpayment and post it to ZATCA. - Reverse invoice **A** and try posting it to ZATCA. An error will occur: ```python File ".../l10
Original PR description
An error occurs when trying to send a reversed invoice to ZATCA if it included a downpayment that was also reversed. Steps to reproduce: - Install "Sales" and "Saudi Arabia - E-invoicing" apps. -…
An error occurs when trying to send a reversed invoice to ZATCA if it included a downpayment that was also reversed.
Steps to reproduce:
- Install "Sales" and "Saudi Arabia - E-invoicing" apps.
- Create a quotation and confirm it.
- Create a downpayment and post it to ZATCA.
- Create an invoice **A** including the downpayment and post it.
- Reverse the downpayment and post it to ZATCA.
- Reverse invoice **A** and try posting it to ZATCA.
An error will occur:
```python
File ".../l10n_sa_edi/models/account_edi_xml_ubl_21_zatca.py", line 356, in _l10n_sa_get_line_prepayment_vals
'prepayment_id': prepayment_move_id.name,
^^^^^^^^^^^^^^^^^^^^^^^
File ".../odoo/fields.py", line 1154, in __get__
record.ensure_one()
File ".../odoo/models.py", line 5204, in ensure_one
raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: account.move(190098, 190096)
```
This fix ensures that only the actual downpayment move is used by filtering on the move type.
opw-4567756
Forward-Port-Of: odoo/odoo#208259
Forward-Port-Of: odoo/odoo#201322When a record is pushed directly into db having partial values like missing checkout date will lead to raising validation error. Steps to Reproduce: - In kiosk try to do a login/logout using the same employee having irregular record it raises validation error. Issue: - Unresponsive kiosk system. Reason: - When a validation error is raised from rpc call it directly displays the error dialog and moves and returns thus making the lockScanner reset, thus not allowing next users to us
Original PR description
When a record is pushed directly into db having partial values like missing checkout date will lead to raising validation error. Steps to Reproduce: - In kiosk try to do a login/logout using the same employee having irregular record it raises validation error. Issue: - Unresponsive kiosk system. Reason: - When a validation error is raised from rpc call it directly displays the error dialog and moves and returns thus making the lockScanner reset, thus not allowing next users to use kiosk. Fix: - Catching the error and posting it as notification (dialog can also be done) and letting the whole function execute. task-4760381 Forward-Port-Of: odoo/odoo#209306 Forward-Port-Of: odoo/odoo#207904
Integrate whatsapp into marketing automation test tools and flow. Module marketing_automation_whatsapp has been added but is still not integrated into global marketing automation tests. Cover more activity types and scenarios, notably to spot corner cases currently badly covered. Added tests: whatsapp / sms types, opposite triggers (aka: cancel mail not open when mail is opened), rescheduling, scheduling for new participants / new activities, ... Add long awaited performance tests
Original PR description
Integrate whatsapp into marketing automation test tools and flow. Module marketing_automation_whatsapp has been added but is still not integrated into global marketing automation tests. Cover more…
Integrate whatsapp into marketing automation test tools and flow. Module marketing_automation_whatsapp has been added but is still not integrated into global marketing automation tests. Cover more activity types and scenarios, notably to spot corner cases currently badly covered. Added tests: whatsapp / sms types, opposite triggers (aka: cancel mail not open when mail is opened), rescheduling, scheduling for new participants / new activities, ... Add long awaited performance tests for marketing automation. As it may be quite a time consuming module by generating participants, traces for millions of records, better start with some performance tests in order to prepare work for some optimizations. Finally, fix various issues in marketing automation detected when writing tests. Task-4066243: [marketing_automation] Rescheduling issues Task-4224145: [marketing_automation] Improve test coverage Task-4759343: [marketing_automation] Integrate Whatsapp into MA test suite Prepares Task-4224152: [marketing_automation] Performance / Scalability Forward-Port-Of: odoo/enterprise#85229 Forward-Port-Of: odoo/enterprise#84848
Task-4781564 Forward-Port-Of: odoo/enterprise#85149
Original PR description
Task-4781564 Forward-Port-Of: odoo/enterprise#85149