Friday, May 16, 2025
5 changes · saas-17.4
Resolved issues and error corrections
This update documents why certain hidden fields remain in localized Odoo views, keeping automated checks satisfied while avoiding disruption to custom view extensions. It is a low-risk maintenance fix that prepares these fields for later removal in the main version without changing day-to-day functionality.
Original PR description
Before this commit, several invisible fields were present in the views, whereas after https://github.com/odoo/odoo/pull/162009 these fields need to be either justified or removed. The needed fields are fetched automatically after https://github.com/odoo/odoo/pull/137031 This commit adds a comment to each field so that the tests pass in stable versions, to avoid potential issues with inheritance in custom views. We will removes the unnecessary invisible fields in master. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue in Mail where the new message banner could stay visible after messages were marked as read when the composer was focused. This prevents users from seeing outdated unread-message indicators and keeps the conversation view accurate.
Original PR description
Purpose of this commit: When a mail thread contains a banner and the composer is focused, the banner remains visible even after the `mark_as_read` action is triggered. This issue arises because the sync parameter isn't set to true when markAsRead is executed during `onFocusin`. Setting it to true would also update the `new_message_separator`, which isn't always necessary. This commit introduces a partial sync mechanism that only syncs the `localMessageUnreadCounter`, which controls the banner's visibility. task-4102924
This fix prevents sales orders from crashing when users edit a product line after creating a down payment invoice under certain unit-of-measure settings. Down payment lines without unit information are now ignored for quantity-change logging, keeping the sales workflow stable.
Original PR description
Versions -------- - 17.4+ Steps ----- 1. Configure UoM decimal accuracy to be 0 digits; 2. create, confirm a SO; 3. create a downpayment invoice; 4. go back to the SO; 5. modify the product line's…
Versions -------- - 17.4+ Steps ----- 1. Configure UoM decimal accuracy to be 0 digits; 2. create, confirm a SO; 3. create a downpayment invoice; 4. go back to the SO; 5. modify the product line's price. Issue ----- > AssertionError: precision_rounding must be positive, got 0. Cause ----- When checking for quantity changes to log on `write`, a fallback rounding value is retrieved using `precision_get`. This returns a `precision_digits` value, but is being used as a `precision_rounding` value, resulting in an error when it is 0. In previous versions, this fallback value was never used, as `display_type` lines were skipped, and any other line is guaranteed to have a `product_uom.rounding` value. As of 9aa52dd6418e, the constraint was changed for `is_downpayment` lines not having to be of `display_type` nor require a `product_uom` value, meaning the faulty fallback value now gets used. Solution -------- Remove the fallback value, and only log lines with a `product_uom` value. opw-4566621
Clicking the Welcome Bot in a live chat member list no longer causes an error. This keeps chat conversations usable when staff view participant details, improving reliability with minimal user-facing change.
Original PR description
Traceback: https://pastebin.com/UmtLxudu Steps to reproduce: - Open conversation with a visitor in chat window - Using the thread actions, open the channel member list - Click on the Welcome bot > leads to a traceback The Welcome Bot partner does not have user_id hence when opening its avatar card leads to a traceback as the avatar card requires a user_id. This commit address this issue.
This update addresses internal view definitions where hidden fields now need to be clearly justified under newer validation rules. It adds explanatory comments so stable-version tests continue to pass while reducing the risk of issues for customer-specific customizations.
Original PR description
Before this commit, several invisible fields were present in the views, whereas after https://github.com/odoo/odoo/pull/162009 these fields need to be either justified or removed. The needed fields are fetched automatically after https://github.com/odoo/odoo/pull/137031 This commit adds a comment to each field so that the tests pass in stable versions, to avoid potential issues with inheritance in custom views. We will removes the unnecessary invisible fields in master.