Friday, May 16, 2025
6 changes · saas-18.3
Resolved issues and error corrections
Sales teams can now create a draft down payment invoice even when a confirmed sales order has no remaining order lines. This prevents an error that previously blocked the invoicing flow in this edge case.
Original PR description
This error occurs when creating an invoice for a sale order with no SO line.
Steps to reproduce:
---
- Install `sale_management` module
- Create a New SO and `Add a Section` > Confirm
- Remove SO line > Create Invoice > Down Payment > Create Draft
Traceback:
---
`TypeError: 'int' object is not iterable`
At [1], the error occurs because `self.order_line.mapped('sequence')` returns an empty list. The fallback value 10 is used, but since it's an integer (not a list), it causes a TypeError.
[1]- https://github.com/odoo/odoo/blob/f101a9b6d65e34cf3d3175a341b87e3f14c44a02/addons/sale/models/sale_order.py#L2052
sentry-6601545000
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fix prevents the system from crashing when it needs to show a contact that does not have a name entered. It improves reliability for edge cases where contact records are incomplete or imported without a name.
Original PR description
The partner `name` field is not technically required. Following refactoring in odoo/odoo@29f747543758, ensure that we don't crash when computing display name for such partner (where name is empty, i.e equal to `False`) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes Argentina localization settings so exempt purchase taxes no longer appear incorrectly on domestic vendor bills. It also removes an incorrect foreign-customer responsibility setting from the domestic fiscal position, helping businesses apply the right tax configuration.
Original PR description
Fix 1: In tax `0% EXEMPT` (Purchase), remove the fiscal position AR Domestic from the field Fiscal Position. This causes the tax to appear on vendor bills using “AR Domestic”, even when not applicable. Fix 2: In fiscal position `AR Domestic`, clear the field AFIP Responsibility Type. It should not include `Cliente del exterior`. This value is incorrect for domestic fiscal position and should be removed. Task-4794985 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents website configuration from failing when product category generation hits an access-related issue. Instead of showing an unexpected error, the website setup flow can handle the situation more gracefully, improving reliability for users configuring an online shop.
Original PR description
If an AccessError occurs during category generation while configuring
the website, it results in a traceback.
Traceback:
```
File "/home/odoo/src/odoo/addons/website_sale/models/website.py", line 330, in generate_categories
if not response:
UnboundLocalError: cannot access local variable 'response' where it is not associated with a value
```
https://github.com/odoo/odoo/blob/101437b08887a234623da81dc3101d262c3e972b/addons/website_sale/models/website.py#L322-L332
Here, If an AccessError occurs during the category generation,
the ``response`` variable is not initialized, resulting in an UnboundLocalError
when the code later tries to access ``response`` outside the try block.
sentry-6600425803
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe IoT log download button now responds properly when selected instead of showing an error. This helps users access device logs reliably when troubleshooting IoT issues.
Original PR description
The iot download logs button widget js code didn't have an onClick method which resulted in an error when you press it:
```
UncaughtClientError > OwlError
Uncaught Javascript Error > Invalid handler (expected a function, received: 'undefined')
Occured on 80350261-saas-18-3-all.runbot177.odoo.com on 2025-05-15 12:30:59 GMT
OwlError: Invalid handler (expected a function, received: 'undefined')
Error: Invalid handler (expected a function, received: 'undefined')
at Object.mainEventHandler (https://80350261-saas-18-3-all.runbot177.odoo.com/web/assets/debug/web.assets_web.js:14945:23)
at HTMLButtonElement.listener (https://80350261-saas-18-3-all.runbot177.odoo.com/web/assets/debug/web.assets_web.js:9281:20)
```
This PR fixes this issue by properly definining an "onClick" method
task-4797770The point of sale IoT setup no longer shows a "no IoT box found" notification when newer connection wizards are available. This avoids confusing staff with an outdated warning during device setup.
Original PR description
Since the PR https://github.com/odoo/enterprise/pull/83066 which adds new wizards for IoT Box connection it is no longer necessary to display "no iot box found" notification. This PR removes this notification which could still be seen