Monday, June 2, 2025
3 changes · saas-18.3
Resolved issues and error corrections
This fix speeds up upgrade processing by simplifying an internal validation check for buttons in views. Upgrade builds should complete view validation much faster, reducing wait time and improving reliability of the upgrade process.
Original PR description
During upgrades, it looks like a big part of the view validation is taken by one single check, checking that the method on a button is public.  This was actually slown down by the introduction of [api.private](https://github.com/odoo/odoo/pull/195402). The check now needs to get the mro and find if the method is _api_private using get_public_method. This is actually quite slow and not relevant in the context of view validation. This check is there to avoid development mistakes (in code or editing views in database). Missing a few corner cases is not a problem here. The change was most likely made to allow to deprecate check_method_name. This pr simplifies the check to remove 5-8 minutes on upgrade builds. After this pr, upgrade build validate views takes around ~3m30s (was ~11 minutes) backport of #211940
This fixes an issue that could block users from creating an employee when starting from certain payroll screens and leaving the employee lookup blank before choosing create. The system now avoids sending an empty default name, preventing the save error and keeping the employee creation flow working smoothly.
Original PR description
Currently, an error occurs when the user attempts to create an employee from any view. Steps to replicate: - Install `hr_payroll`, go to `Payroll > Work Entries` and click on create. - Now click on…
Currently, an error occurs when the user attempts to create an employee from any view. Steps to replicate: - Install `hr_payroll`, go to `Payroll > Work Entries` and click on create. - Now click on the `Employee`(dont type anything), and click on create. - Type any name and click save. Error: `IndexError: string index out of range` The error occurs because of the `default_name` being passed as empty string from line [1], which is due to a recent change([PR](https://github.com/odoo/odoo/pull/209835)). This causes the line [2] to receive the `name` as empty string and causes the error. This commit resolves the issue by passing default value in the context only ifit exists so we don't get any errors during avatar creation. [1]- https://github.com/odoo/odoo/blob/9cebb8c23d66a6aadd06bf0d806c65b67dc13ae7/addons/web/static/src/views/fields/relational_utils.js#L312 [2]-https://github.com/odoo/odoo/blob/bfc98c30e1a4faa458bc1101dc572e96cfa31d47/odoo/addons/base/models/avatar_mixin.py#L65 sentry-6619892365 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes filtering on the restaurant kitchen preparation screen, including clearing filters and selecting time filters. Staff can now rely on the display controls to show the right preparation items without confusion.
Original PR description
Steps to reproduce: ==== - Install pos_restaurant - Open kitchen display > preparation screen - Open Sidebar > click any item > click Clear All Filters OR click any time Issue: ==== - Filters are not working as expected Cause: ==== - setTime function is not defined and preparationDisplay written instead of prepDisplay Fix: ==== - Defined the setTime function and replace preparationDisplay with prepDisplay --- task-4759803