Saturday, June 7, 2025
3 changes
1 change
Resolved issues and error corrections
This fix removes redundant tooltip titles from message dropdown actions where the icon and label already explain the action. It reduces visual obstruction and makes message menus easier to use.
Original PR description
Message dropdown actions show both icon and label in text content. There's no need to have a redundant title as the text content that's annoying because it obstructs the list.
2 changes
Resolved issues and error corrections
Chat windows now keep their intended size more consistently in Safari. This prevents the chat panel from becoming too narrow when the browser window has limited vertical space, improving usability for Safari users.
Original PR description
Before this commit, chat window size on Safari sometimes look off. The intended sizing is 380px in width and 9/15 ratio, with height being limited by 95vh. Safari `aspect-ratio` has strange behavior: instead of shrinking just the height from max-height, it gives too much priority on enforcing the aspect-ratio, thus the chat window becomes thinner and thinner the less vertical space there are. This commit fixes the issue by replacing the `aspect-ratio` style by a max-height that is computed with ratio and 95vh.
This fix prevents portal users from seeing an error when they click Comment to reply in the chatter. Replies now correctly show the user's avatar and keep the conversation flow working as expected.
Original PR description
Before this commit, clicking on "Comment" button in portal chatter to reply to a message leads to the following crash: ``` TypeError: Cannot read properties of null (reading 'effectiveSelf') ``` This…
Before this commit, clicking on "Comment" button in portal chatter to reply to a message leads to the following crash: ``` TypeError: Cannot read properties of null (reading 'effectiveSelf') ``` This happens because it opens the composer to reply to the message. Replying to a message should normally use the composer of thread and rely on `props.messageToReplyTo` from the `useMessageToReplyTo` hook, but portal chatter instead makes a composer linked to the message. The problem is that a message linked to a composer is actually meant to say the composer is for editing the message, and when editing the message the composer shows no avatar as this is shown by the `Message` component. Portal chatter reply to comment should display avatar of self user, but the problem is that the component `Composer` isn't directly linked to `thread`, therefore the LOC `thread.effectiveSelf` crashes in template. This commit fixes the issue by using the `message` linked to composer when no immediate thread is found in order to display the `effectiveSelf` avatar. A composer is necessarily linked to either a thread or composer, thus this ensures the `effectiveSelf` is defined.