Monday, June 23, 2025
2 changes · saas-18.1
Resolved issues and error corrections
A typo in the hardware drivers module caused an update step to fail during git checkout. This fix corrects the data passed to the update process, allowing checkouts to complete as expected.
Original PR description
Introduced in odoo/odoo#213177. A simple typo meant the `update_conf` method was being called with a set instead of a dict, leading to an error being thrown and preventing the git checkout. This commit fixes the typo. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reduces a flaky automated test failure in the Mail app by allowing a more flexible check of edited message text. It helps keep validation runs reliable without changing end-user behavior.
Original PR description
Following non-deterministic test failure happens on runbot: ``` [HOOT] Test "@mail/message/message/Can edit message comment in chatter" failed: [HOOT] Error: Failed to find 1 of ".o-mail-Message…
Following non-deterministic test failure happens on runbot:
```
[HOOT] Test "@mail/message/message/Can edit message comment in chatter" failed:
[HOOT] Error: Failed to find 1 of ".o-mail-Message .o-mail-Composer-input" with value "edited again" (Timeout of 3 seconds). Found 0 instead.
```
We couldn't reproduce in practice to see why this fails, and we are not helped from HOOT tests on runbot being run in headless mode thus screenshots are useless.
One theory of failure is race condition of composer input still containing the trailing `\n` character when we'd expect it to be removed. The `contains({ value })` of mail test helpers checks for exact match of value thus the error.
This commit attempts to fix the issue by using relaxing the condition for input containing at least the expected character. In other words: it replaces the `{ value }` (exact match) by `:value()` (includes match). That way if the value still has the `/n` trailing character, assertion `edited again` would pass with `edited again/n`.
Note that `:value` seems to not see newlines `\n` in inputs. This is a bit annoying so we had to relax the other value assertion too. There's plan to use web selectors rather than mail ones, which is another reason to not improve mail_test_helpers further and instead put effort to migrate to web test helpers.
runbot-181952