### [FIX] html_editor: prevent removal of unremovable links with images

The override that remove a link on `deleteImage` command did not check
if the link was unremovable before removing it.

### [FIX] html_editor: prevent removal of links in contenteditable=false

If a link was `contenteditable=true`, but inside a
`contenteditable=false`, it could be removed

### [FIX] html_editor: prevent removal of unremovable links in batch removal

If the selection covers several links, the "unlink" of the toolbar
removes all the links selected. This included the links which were
supposed to be unremovable.

The procedure for removing the links is changed to avoid removing the
unremovable nodes.

The availability of the tool in the toolbar is also changed to better
reflect whether there is links to remove. In case of unremovable links,
the tool is shown as disabled

Steps to reproduce:
- Open website builder
- In the toolbar, insert links just before and after the "Contact Us"
- Select from the link inserted before, to the one after
- In the toolbar, click "Remove Link"
- Bug: the link on "Contact Us" is gone, but it was "unremovable"
  (Saving after these steps currently breaks the toolbar's rendering)

Description of the issue/feature this PR addresses:
This pull request adds  `l10n_ar.partner.tax_billing` on the `l10n_ar_partner_tax` model, granting read, write, and create permissions (but not unlink) to users in the `account.group_account_invoice` group.

Current behavior before PR:
Only users with administrator access rights on the Accounting module could modify the "Perceptions / Withholdings" Section on the "Accounting" tab of the partners.
<img width="1236" height="673" alt="image" src="https://github.com/user-attachments/assets/92b42973-2b01-4019-8e23-5e3cbf5111a4" />


Desired behavior after PR is merged:
Users with invoicing rights can modify the Accounting module could modify the "Perceptions / Withholdings" Section on the "Accounting" tab of the partners. This is needed to properly create the invoices with the perceptions / withholding that apply, for example in cases where by default all partners are set with perceptions, but some depending on their activity are not taxed. In that case, the user that created the partner needs to be able to modify the field by putting a 0% aliquot or deleting the perception line on the contact. 




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#225180

Versions
--------
- saas-18.4+

Steps
-----
1. Configure Stripe;
2. go to `/my/payment_method`;
3. create a payment token.

Issue
-----
> Internal Server Error

Cause
-----
Commit 5db75d32d718a added a method that compares notification data values to the transaction values. For most operations, the structure of Stripe notification data is similar, but for `SetupIntent` responses, these don't include an amount or currency value (unless the currency is supported by Indian eMandates, in which case it's part of a `mandate_options` dict)[^1].

The error is the result of `payment_data.get('currency').upper()`. Because there is no currency value, `upper` gets called on `None`.

Additionally, when the transaction amount is zero (as is expected for validation operations), the base `_compare_notification_data` method assumes the amount is missing, throwing a validation error.

[^1]: https://docs.stripe.com/api/setup_intents/confirm

Solution
--------
- Skip comparing notification data for validation transactions.
- If the `currency` value is in fact missing unexpectedly, fall back on the empty string, so that we get to the intended validation error.

opw-5008858

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/15a11a468 [REL] 18.4.10 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)
https://github.com/odoo/o-spreadsheet/commit/8e9603c88 [FIX] package: saas-18.4 is no longer the latest version [](https://www.odoo.com/odoo/2328/tasks/)
https://github.com/odoo/o-spreadsheet/commit/d021c7ff6 [FIX] Menu: Fix item text truncation [Task: 5072649](https://www.odoo.com/odoo/2328/tasks/5072649)
https://github.com/odoo/o-spreadsheet/commit/424fb57e8 [FIX] xlsx: remove useless warnings on import [Task: 5075112](https://www.odoo.com/odoo/2328/tasks/5075112)
https://github.com/odoo/o-spreadsheet/commit/c3bad9029 [FIX] clipboard: insert cells bugged with array formulas [Task: 4938311](https://www.odoo.com/odoo/2328/tasks/4938311)
https://github.com/odoo/o-spreadsheet/commit/f4282501a [FIX] xlsx: `=undefined` when importing array formula [Task: 4812508](https://www.odoo.com/odoo/2328/tasks/4812508)
https://github.com/odoo/o-spreadsheet/commit/eb13639d0 [REV] xlsx: make import verbose [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)

Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com>
Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com>
Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com>
Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com>
Co-authored-by: Ronak Mukeshbhai Bharadiya <rmbh@odoo.com>
Co-authored-by: Florian Damhaut (flda) <flda@odoo.com>
Co-authored-by: Rémi Rahir (rar) <rar@odoo.com>
Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com>
Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

This commit fixes two bugs related to the "Sign in" in button of the registration form.

First bug:
------------
If there is more ordered seats than available seats, an error modal is displayed with a "Sign In" button. This button shouldn't be present. On click, a 500 error is triggered. Now, the button does not appeared on this modal.

Reproduce:
Check "Mandatory" for "Sign in/up at checkout" in the settings. In the event form, add a limit of 1 available seat and add two tickets with each one 1 seat. With a public user, on the website page of the event, click on "Register" to open the registration modal. In the tickets form, select the maximum number of registrations for each tickets. The error modal with the "Sign In" button should appear. Clicking on this button trigger the 500 error.

Second bug:
----------------
The "Sign in" button is displayed even if the tickets have no price. So the label of the button is wrong because public users are not redirected to the checkout. Now, the "Confirm Registration" button is displayed in this case.

Reproduce:
With the same settings as for the first bug, create an event without tickets. Order a registration with an public user. Click on the "Sign In" button of the attendee details form. The confirmation page appears instead of the sign in page.

task-4797022

Forward-Port-Of: odoo/odoo#215585

Since the initial [website builder refactor], when in translate mode
in website builder, pressing an arrow key when the cursor is inside the
text of a carousel moved to the next slide once, pressing again caused
a crash. Before the refactor, there was also the slide behavior but not
the crash.

The arrows triggers the slide because the contenteditable is inside
the slide in translate mode. It does not trigger it in normal edit mode
because the contenteditable is on an ancestor.

This commit fixes it by changing the config pass to the bootstrap
carousel in edit mode, so that the carousel does not slide on keyboard.
Changing this config makes the event handlers to stop the keydown event
on the other parts of the carousel redundant, so they are removed

Steps to reproduce:
- Open website bulider
- Drop the snippet "Quotes Minimal"
- Add a second language to the website
- Edit the translation for the second language
- Click on the text in the quote in the carousel
- Press a left or right arrow key
- Bug: the slide changed (instead of moving the cursor in side the text)
- Click on the text of the slide that is now shown
- Press again the arrow key
- Bug: Crash

[website builder refactor]: https://github.com/odoo-dev/odoo/commit/9fe45e2b7ddbbfd0445ffe25a859e67a316d02b2
task-4367641

Steps to reproduce:
1) Install `website_sale_slides`.
2) Create a course with enroll policy 'On payment' and publish it. 
3)  Add a content allow preview it and add a quiz
4) Go to website, click Share button and open the generated link in incognito. 
5) Login as a portal user, pass the quiz and click "Buy this course".

Issue:
- A traceback occurred:
`Cannot read properties of undefined (reading 'addToCart')`.

Cause:
- The method call `self.call('websiteSale', 'addToCart', ...)` relied on the deprecated `call` service, which was removed in commit https://github.com/odoo/odoo/commit/b8d0ab4275b24510161de9db793020f3489b0446.
- The service and method `call('websiteSale', 'addToCart'` is not valid and was not updated here : 
https://github.com/odoo/odoo/blob/35161ecf0dd3fde47db9b2166718339c2e30ac92/addons/website_sale_slides/static/src/js/slides_course_join.js#L29
- As a result, `addToCart` was no longer accessible and triggered a JS error.

Solution:
- Update the code to use the new service and method: `call('cart', 'add',`


opw-5045424

Forward-Port-Of: odoo/odoo#224760

The system crashes with an error when a user tries to create an invoice.

**Steps to produce:-**
- Install `Accounting` module and switch to `BE Company`.
- Go to `Settings > Users & Companies > Companies` and remove the country from the BE company.
- Create a new customer with:-
    - Country as `Belgium`. 
    - Tax ID as `DE123456788`.
- `Accounting > configuration > settings > enable Verify VAT Numbers`.
- Now try to make `invoice` with customer as previously created customer.

**Error:-**
`TypeError : argument of type 'bool' is not iterable`

**Root cause:-**
- At [1], the code attempts to access `company.country_id`, but since the country was manually removed from the company, it evaluates to null record, leading to the error.

**Solution:-**
- Add a safeguard to ensure `company.country_id` also exist before accessing `country_group_codes`.

[1] -https://github.com/odoo/odoo/blob/4c2330f3cc0d1a0046e28d351f894763aeea57d2/addons/base_vat/models/res_partner.py#L764

**sentry-6851141424**

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#225158

ISSUE
=====

Introduced in bce7e94650c337a9046958a7689c81db5b2a4c73, We now handle capacity when booking users.
They have each a max capacity of user_capacity for each slot.

However, when it comes to the manual confirmation treshold, we do not account for the total capacity of all users combined, but consider the maximum to be user_capacity!

This can lead to a lot of 'request' meetings as we reach the manual confirmation percentage very quickly.

STEPS TO REPRODUCE
==================

1. Create an appointment type based on users, with 'manage capacities' enabled, 'manual confirmation' enabled and 'when over' 50% total capacity. Set 2 users and 3 'seats max'. This way, the total capacity of your appointment is 2 * 3 = 6 per slot.
2. As a public user, take an appointment for 2 capacity in the front end
3. The meeting will end up as a 'request', even though the capacity booked is 2/6 < 50%, and should be 'booked'

FIX
===

We now multiply the number of users on the appointment type by the user_capacity when computing the total capacity and comparing it to the asked capacity on booking an appointment.

A test is included

Task-4930778

## Issue:
Creating multiple suggestions sequences for differents Workorder in Manufacturing Orders that are added aside BoM defined WorkOrder cause an issue with a Traceback error

## Cause:
In the method `add_check_in_chain()`, the `point.sequence` cause issue because the check can have multiple points
https://github.com/odoo/enterprise/blob/e85d11f9b3bf07a55e5365adac7370955a149566/mrp_workorder_plm/models/mrp_workorder.py#L58-L66
That the case because multiple quality checks sequences are created when the operation_id is False
That's unexpected because PLM isn't made to suggest WorkOrder additions and Suggestions to New WO, but only Suggestions to existing operations

So we avoid to create `quality.point` when there is no operation_id

## Information:
To get the Traceback, you need to install Quality_control because this module will copy the QC to the MO including the one with operation_id set to False

## Steps to reproduce:
Quality_control and plm need to be installed
- Enable Work Orders in Settings
- Create a Product with a BoM
- Create a MO for the Product
- Add an extra WO
- In the Shop Floor, Mark as Done the BoM's WO
- On the Extra WO, click Gear Icon > Update Instructions > Improvement Suggestion > Add a Step
- Insert a Title and Propose Change
- Duplicate the MO and redo the Shop Floor steps to get the Traceback

opw-4874108

Forward-Port-Of: odoo/enterprise#92384

ISSUE
=====

Introduced in odoo/enterprise@bce7e94650c337a9046958a7689c81db5b2a4c73 , we now allow configuring a number of max simulatenous appointments per resource / user per slot, when manage_capacity is False.

However, this broke the booking flow when enabling a payment on the appointment type as well, for resources with capacity > 1. More specifically, as soon as the remaining capacity is lower than the resource's own capacity.

STEPS TO REPRODUCE
==================

0. Install payment_demo, in order to be able to test the payment issue. Install website_appointment_sale to ease the testing too.
1. Create an appointment type for 'Resources', enable 'Up-front payment'.
2. Set a new resource with capacity = 2 on the appointment type.
3. Make sure manage_capacity is False, and number of simultaneous appointments (max_bookings) is set to 1.
4. Go to the front end and pick any slot.
5. Fill the form and 'proceed to payment'
6. Try to 'pay now'
7. You get a validation error message telling you that the slot is not available anymore. But it is not the case since it is a new type and new resource.

FIX
===

For resources, created booking lines were setting capacity_used to the resource's capacity, unless shared. (meaning: the resource is completely used, even if the reserved quantity is smaller). It made sense before but not for this new feature. It should only use 1 capacity, as we count the number of different simulatenous appointments, and it is unrelated to the resource's own capacity.

When creating the meeting at the end of the regular flow, the computed field on capacity_used on appointment.booking.line will set it to 1 when manage_capacity is False. Hence, no issue will happen there in practice as the meeting is always created in that case and capacity_used updated.

However, when enabling a payment, we create a calendar.booking instead, with calendar.booking.lines. And based on those, we evaluate availability when checking the cart before going to payment.

Those are simply created from values in the controller, and the model is much simpler. Therefore, we fix the issue by manually setting the capacity_used to 1 when creating the booking lines in the front-end booking flow, in the case of an appointment without capacity management.

Task-4963012

Description of the issue this PR addresses:

Issue 1:

Steps to Reproduce:

- Open the website.
- Create a mega menu.
- Enter edit mode.
- Change the mega menu template to “Cards”.
- Click on any option available in the mega menu.
- A link popover will open.
- Click the Edit link button in the popover.
- Click the Apply button to save the link.
- A traceback occurs.

The error occurs because the text-wrap class is applied to the link. When the
hasColor method is triggered, it checks whether a.nav-link has a text color
class. However, TEXT_CLASSES_REGEX incorrectly matches text-wrap as a color
class. As a result, the removeColor method attempts to remove it and triggers
_applyColor to remove the color, but in _applyColor method it does not find any
color to remove on selected text. As a result, the removeColor process enters an
infinite loop, which eventually leads to a traceback.

Solution:

Update TEXT_CLASSES_REGEX so that it only matches valid text color classes and
excludes formatting classes such as text-wrap, text-center, etc.

Issue 2:

This commit ensures that the remove format action is disabled when a button
(.btn element) has custom color or background color applied.

Because buttons include padding, there is no proper way to remove a background
color from a partially selected button, so the action must be ignored in this
case.

task-5062715


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#225703
Forward-Port-Of: odoo/odoo#225477

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/ef829f491 [REL] 18.3.20 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)
https://github.com/odoo/o-spreadsheet/commit/d78bb8f17 [FIX] Menu: Fix item text truncation [Task: 5072649](https://www.odoo.com/odoo/2328/tasks/5072649)
https://github.com/odoo/o-spreadsheet/commit/b4439808d [FIX] xlsx: remove useless warnings on import [Task: 5075112](https://www.odoo.com/odoo/2328/tasks/5075112)
https://github.com/odoo/o-spreadsheet/commit/89c22db73 [FIX] clipboard: insert cells bugged with array formulas [Task: 4938311](https://www.odoo.com/odoo/2328/tasks/4938311)
https://github.com/odoo/o-spreadsheet/commit/5e7e4f50a [FIX] xlsx: `=undefined` when importing array formula [Task: 4812508](https://www.odoo.com/odoo/2328/tasks/4812508)
https://github.com/odoo/o-spreadsheet/commit/506ccf690 [REV] xlsx: make import verbose [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)

Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com>
Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com>
Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com>
Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com>
Co-authored-by: Ronak Mukeshbhai Bharadiya <rmbh@odoo.com>
Co-authored-by: Florian Damhaut (flda) <flda@odoo.com>
Co-authored-by: Rémi Rahir (rar) <rar@odoo.com>
Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com>
Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

This commit fixes two bugs related to the "Sign in" in button of the registration form.

First bug:
------------
If there is more ordered seats than available seats, an error modal is displayed with a "Sign In" button. This button shouldn't be present. On click, a 500 error is triggered. Now, the button does not appeared on this modal.

Reproduce:
Check "Mandatory" for "Sign in/up at checkout" in the settings. In the event form, add a limit of 1 available seat and add two tickets with each one 1 seat. With a public user, on the website page of the event, click on "Register" to open the registration modal. In the tickets form, select the maximum number of registrations for each tickets. The error modal with the "Sign In" button should appear. Clicking on this button trigger the 500 error.

Second bug:
----------------
The "Sign in" button is displayed even if the tickets have no price. So the label of the button is wrong because public users are not redirected to the checkout. Now, the "Confirm Registration" button is displayed in this case.

Reproduce:
With the same settings as for the first bug, create an event without tickets. Order a registration with an public user. Click on the "Sign In" button of the attendee details form. The confirmation page appears instead of the sign in page.

task-4797022

Forward-Port-Of: odoo/odoo#215585

Steps to reproduce:
1) Install `website_sale_slides`.
2) Create a course with enroll policy 'On payment' and publish it. 
3)  Add a content allow preview it and add a quiz
4) Go to website, click Share button and open the generated link in incognito. 
5) Login as a portal user, pass the quiz and click "Buy this course".

Issue:
- A traceback occurred:
`Cannot read properties of undefined (reading 'addToCart')`.

Cause:
- The method call `self.call('websiteSale', 'addToCart', ...)` relied on the deprecated `call` service, which was removed in commit https://github.com/odoo/odoo/commit/b8d0ab4275b24510161de9db793020f3489b0446.
- The service and method `call('websiteSale', 'addToCart'` is not valid and was not updated here : 
https://github.com/odoo/odoo/blob/35161ecf0dd3fde47db9b2166718339c2e30ac92/addons/website_sale_slides/static/src/js/slides_course_join.js#L29
- As a result, `addToCart` was no longer accessible and triggered a JS error.

Solution:
- Update the code to use the new service and method: `call('cart', 'add',`


opw-5045424

Forward-Port-Of: odoo/odoo#224760

## Issue:
Creating multiple suggestions sequences for differents Workorder in Manufacturing Orders that are added aside BoM defined WorkOrder cause an issue with a Traceback error

## Cause:
In the method `add_check_in_chain()`, the `point.sequence` cause issue because the check can have multiple points
https://github.com/odoo/enterprise/blob/e85d11f9b3bf07a55e5365adac7370955a149566/mrp_workorder_plm/models/mrp_workorder.py#L58-L66
That the case because multiple quality checks sequences are created when the operation_id is False
That's unexpected because PLM isn't made to suggest WorkOrder additions and Suggestions to New WO, but only Suggestions to existing operations

So we avoid to create `quality.point` when there is no operation_id

## Information:
To get the Traceback, you need to install Quality_control because this module will copy the QC to the MO including the one with operation_id set to False

## Steps to reproduce:
Quality_control and plm need to be installed
- Enable Work Orders in Settings
- Create a Product with a BoM
- Create a MO for the Product
- Add an extra WO
- In the Shop Floor, Mark as Done the BoM's WO
- On the Extra WO, click Gear Icon > Update Instructions > Improvement Suggestion > Add a Step
- Insert a Title and Propose Change
- Duplicate the MO and redo the Shop Floor steps to get the Traceback

opw-4874108

Forward-Port-Of: odoo/enterprise#92384

**Steps to reproduce:**:
- Install the module "account_reports_cash_basis"
- Create a new account
- Create an invoice with a line in the newly created account
- Create a number of payments on the invoice
- Go to general ledger, and set method to cash basis
- Set limit to a value less than the number of payments
- Open the account on the general ledger, and click on load more

**Issue:**
After clicking on 'Load more', we get a traceback due to duplicate lines

**Cause:**
The same aml can return multiple results when using "account_reports_cash_basis" module. While this has been taken into consideration for each batch of lines loaded into the report (we won't get the same line referenced two times in the same batch, since they are grouped together), if we load a new batch by clicking "Load More", we can potentially get a line that was referenced in the first batch, and we get an error for having two lines in the report referencing the same thing.

**Solution:**
We add a add a GROUPBY statement in the query of _get_aml_values()
This will add up all the cash basis lines in the query itself.

opw-4635115

Forward-Port-Of: odoo/enterprise#93904
Forward-Port-Of: odoo/enterprise#86817

This commit introduces several related fixes to the LLM API service to make tool
call processing more robust and prevent silent failures.

- **Unknown Tool Calls**: When an LLM requests a tool with an invalid or unknown
  name, it previously resulted in an empty response, causing the conversation to
  stall. This change ensures that a proper error message is now returned to the
  LLM for the invalid tool call. This allows the LLM to process the failure and
  continue the conversation.

- **Failing on Limits**: The query processing loop in `_request_llm` has limits
  for both successive API calls and the number of tool calls per request.
  Previously, these limits would be reached silently.

  - **API Call Limit**: If the `AI_MAX_SUCCESSIVE_CALLS` limit is reached
    without the LLM providing a final answer, a `ValueError` is now raised. This
    prevents silent failures and makes it clear to the calling code that the
    request could not be completed.

  - **Tool Call Limit**: If the number of tool calls in a single response
    exceeds `AI_MAX_TOOL_CALLS_PER_CALL`, any calls beyond the limit are now
    provided with a result stating that the limit was reached. This gives the
    LLM the opportunity to try the unprocessed tool calls again in a subsequent
    turn.

- **Ignore Explanatory Text**: The text that LLMs often include alongside a tool
  call request (the "thinking" text) is now ignored to provide a cleaner and
  more concise final response to the user.

__Current behavior before commit:__
The color palette for SVG Dynamic Colors doesn't work properly.
The color preview doesn't show the current color and some colors make
the SVG disappear.

__Description of the fix:__
- The [`_update_svg_colors`] backend method only works with rgb, hex and
the palette colors matching `/^o-color-[1-5]$/`. So all other custom CSS
variables (e.g. `var(--white)`) are converted to hex notation in the SVG
URL search params.
- Furthermore, to show the correct color in the little color preview
circle, [`getValue`] now always returns a normalized CSS color value.
- The regex matching rgba color in [`convertCSSColorToRgba`] has been
fixed to include alpha values that don't have the 0 before the decimals
(e.g. `rgba(255, 255, 255, .5)`).

__Steps to reproduce:__
1. Open the website builder
2. Switch to "Artists" theme
2. Drop a Horizontal Attributes snippet
3. Click on one of the SVG icon => the color previews in
Image > Dynamic Colors don't correspond to the SVG colors
4. Click on one of the color to open the palette
5. Choose one in the top row => the SVG disappears
6. Go in the "Custom" tab of the color palette => the current color is
not the correct one
7. Choose one of the grey shade at the top => the SVG disappears

[`_update_svg_colors`]: https://github.com/odoo/odoo/blob/64efa6b7dc7/addons/html_editor/controllers/main.py#L92
[`getValue`]: https://github.com/odoo/odoo/blob/64efa6b7dc7/addons/website/static/src/builder/plugins/dynamic_svg_option_plugin.js#L29
[`convertCSSColorToRgba`]: https://github.com/odoo/odoo/blob/64efa6b7dc7/addons/web/static/src/core/utils/colors.js#L218

Forward-Port-Of: odoo/odoo#224850

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/bd79eea46 [REL] 19.0.1 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)
https://github.com/odoo/o-spreadsheet/commit/5c0bf705c [FIX] dashboard: align sort icon with text [Task: 5075237](https://www.odoo.com/odoo/2328/tasks/5075237)
https://github.com/odoo/o-spreadsheet/commit/7c8c52255 [FIX] translation: dynamic translation for chart terms [Task: 5076040](https://www.odoo.com/odoo/2328/tasks/5076040)
https://github.com/odoo/o-spreadsheet/commit/0ac0e86e0 [REL] version 19.0 [](https://www.odoo.com/odoo/2328/tasks/)
https://github.com/odoo/o-spreadsheet/commit/325073b55 [FIX] Menu: Fix item text truncation [Task: 5072649](https://www.odoo.com/odoo/2328/tasks/5072649)
https://github.com/odoo/o-spreadsheet/commit/3c7a71302 [IMP] carousel: improve  drag & drop of chart over carousel [Task: 5059979](https://www.odoo.com/odoo/2328/tasks/5059979)
https://github.com/odoo/o-spreadsheet/commit/6e09fa499 [FIX] xlsx: remove useless warnings on import [Task: 5075112](https://www.odoo.com/odoo/2328/tasks/5075112)
https://github.com/odoo/o-spreadsheet/commit/b5ad83388 [FIX] selection: copy then paste instead of copy/paste loop [Task: 4930718](https://www.odoo.com/odoo/2328/tasks/4930718)
https://github.com/odoo/o-spreadsheet/commit/4a4312e57 [REF] Border: Bordel [Task: 4852413](https://www.odoo.com/odoo/2328/tasks/4852413)
https://github.com/odoo/o-spreadsheet/commit/6fa1bbcdc [REF] cellComputedStyle: use positionmap [Task: 4930718](https://www.odoo.com/odoo/2328/tasks/4930718)
https://github.com/odoo/o-spreadsheet/commit/71360e47d [MOVE] positionMap: move to helper [Task: 4930718](https://www.odoo.com/odoo/2328/tasks/4930718)
https://github.com/odoo/o-spreadsheet/commit/7be6b4636 [FIX] clipboard: insert cells bugged with array formulas [Task: 4938311](https://www.odoo.com/odoo/2328/tasks/4938311)
https://github.com/odoo/o-spreadsheet/commit/27bbe0fa6 [FIX] xlsx: `=undefined` when importing array formula [Task: 4812508](https://www.odoo.com/odoo/2328/tasks/4812508)
https://github.com/odoo/o-spreadsheet/commit/9bfd31dff [REV] xlsx: make import verbose [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)

Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com>
Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com>
Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com>
Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com>
Co-authored-by: Ronak Mukeshbhai Bharadiya <rmbh@odoo.com>
Co-authored-by: Florian Damhaut (flda) <flda@odoo.com>
Co-authored-by: Rémi Rahir (rar) <rar@odoo.com>
Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com>
Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

Since [1], we removed the 'lang' value from mail templates, as we allow to use a fallback on main partner's lang instead.

However, when deleting a calendar.meeting (from Form or calendar) we usually (if no sync is on, and when deleting a single event) open the wizard of confirmation that allows to preview and send cancelation email to the attendees, in order for them to have the information before complete deletion. (see the following wizard: calendar.popover.delete.wizard)

Before [1], we wanted to make sure the template had a lang set. But we forgot to change that condition, resulting in a lot of cases where deletion is just not working, and redirects to the calendar view instead (default behavior), as the lang on the template is not set.

We now use the ´_render_lang´ method instead in order to compute the lang value and use it in the condition as well, actively opening the confirmation modal instead of doing nothing and redirecting to the calendar event.

[1]: odoo/odoo@dc016190e3f3fd90b10fb1eac07204e22d715109

Task-5079771

The system crashes with an error when a user tries to create an invoice.

**Steps to produce:-**
- Install `Accounting` module and switch to `BE Company`.
- Go to `Settings > Users & Companies > Companies` and remove the country from the BE company.
- Create a new customer with:-
    - Country as `Belgium`. 
    - Tax ID as `DE123456788`.
- `Accounting > configuration > settings > enable Verify VAT Numbers`.
- Now try to make `invoice` with customer as previously created customer.

**Error:-**
`TypeError : argument of type 'bool' is not iterable`

**Root cause:-**
- At [1], the code attempts to access `company.country_id`, but since the country was manually removed from the company, it evaluates to null record, leading to the error.

**Solution:-**
- Add a safeguard to ensure `company.country_id` also exist before accessing `country_group_codes`.

[1] -https://github.com/odoo/odoo/blob/4c2330f3cc0d1a0046e28d351f894763aeea57d2/addons/base_vat/models/res_partner.py#L764

**sentry-6851141424**

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#225158

Steps to reproduce:
1) Install `website_sale_slides`.
2) Create a course with enroll policy 'On payment' and publish it. 
3)  Add a content allow preview it and add a quiz
4) Go to website, click Share button and open the generated link in incognito. 
5) Login as a portal user, pass the quiz and click "Buy this course".

Issue:
- A traceback occurred:
`Cannot read properties of undefined (reading 'addToCart')`.

Cause:
- The method call `self.call('websiteSale', 'addToCart', ...)` relied on the deprecated `call` service, which was removed in commit https://github.com/odoo/odoo/commit/b8d0ab4275b24510161de9db793020f3489b0446.
- The service and method `call('websiteSale', 'addToCart'` is not valid and was not updated here : 
https://github.com/odoo/odoo/blob/35161ecf0dd3fde47db9b2166718339c2e30ac92/addons/website_sale_slides/static/src/js/slides_course_join.js#L29
- As a result, `addToCart` was no longer accessible and triggered a JS error.

Solution:
- Update the code to use the new service and method: `call('cart', 'add',`


opw-5045424

Forward-Port-Of: odoo/odoo#224760

**Current behavior:**
Since https://github.com/odoo/odoo/commit/84dda968146d2f3743ab7fc516300e50780725e3, we valuate an unbuild operation by attempting
to match the ensuing OUT layer with the IN layer from the
original MO.

The point being to eliminate a potential valuation imbalance for
the manufactured product (might affect cost, etc.).

**New behavior**
Don't attempt to match an unbuild valuation layer with the
original MO valuation layer. If there is some cost difference
between build time and unbuild time, make a corrective journal
entry for it.

**Issue with current behavior**
The following sequence:
1. Create Product A with average costing, real-time valuation
2. Create 2 components, avg costing, real-time val
3. Create a BoM for Product A with the components
4. Manufacture 3 units of Product A with different component
quantities (can set flexible consumption on BoM)
5. Unbuild the first manufactured unit

Results in Product A's cost not matching the expected average
cost according to the valuation layers.

**Cause of the issue:**
Unbuilding the first MO created an out move at the original
"build time" cost, but since we've built 2 additional qty, that
original cost is not the current average cost- thus the
"theoretically current" standard price of the product (sum of
layers value divided by remaining qty) is no longer the value we
see on the product form.

**Fix:**
Don't try and match the valuation layers. Aside from issues such
as the one described above, it might not actually make
functional sense to do so (e.g., FIFO isn't actually adhering to
first-in-first-out if we're preferring the original IN layer for
an unbuild valuation).

Instead we make a journal entry with any excess cost of
production (it was actually a solution proposed in the
discussion on https://github.com/odoo/odoo/commit/84dda968146d2f3743ab7fc516300e50780725e3 in the first place).

Additionally, now that we aren't doing this mapping, we can
revert the non-test difference of https://github.com/odoo/odoo/commit/3a69456a291da593748475c86e7efc6234019e47, as this commit was
fixing an issue introduced by the change which added the
mapping.

opw-[4877597](https://www.odoo.com/web#id=4877597&view_type=form&model=project.task)

Forward-Port-Of: odoo/odoo#222014
Forward-Port-Of: odoo/odoo#221718

## Issue:
Creating multiple suggestions sequences for differents Workorder in Manufacturing Orders that are added aside BoM defined WorkOrder cause an issue with a Traceback error

## Cause:
In the method `add_check_in_chain()`, the `point.sequence` cause issue because the check can have multiple points
https://github.com/odoo/enterprise/blob/e85d11f9b3bf07a55e5365adac7370955a149566/mrp_workorder_plm/models/mrp_workorder.py#L58-L66
That the case because multiple quality checks sequences are created when the operation_id is False
That's unexpected because PLM isn't made to suggest WorkOrder additions and Suggestions to New WO, but only Suggestions to existing operations

So we avoid to create `quality.point` when there is no operation_id

## Information:
To get the Traceback, you need to install Quality_control because this module will copy the QC to the MO including the one with operation_id set to False

## Steps to reproduce:
Quality_control and plm need to be installed
- Enable Work Orders in Settings
- Create a Product with a BoM
- Create a MO for the Product
- Add an extra WO
- In the Shop Floor, Mark as Done the BoM's WO
- On the Extra WO, click Gear Icon > Update Instructions > Improvement Suggestion > Add a Step
- Insert a Title and Propose Change
- Duplicate the MO and redo the Shop Floor steps to get the Traceback

opw-4874108

Forward-Port-Of: odoo/enterprise#92384

When changing the expense policy of an expense product, the
compute of analytic distribution of all expenses linked to the product
is triggered.

Steps:

- Have an expense product X with expense policy 'at_sales'
- Create several expenses with an expense product X and  any analytic account
- Create an analytic distribution model that link the expense account of
  X with a specific analytic account AA
- Create a new expense for product X, the analytic account AA should be set
  from the distribution model
- Go to the form view of product x and change the expense policy to
  'cost'
- Go back to the expense list view
-> All expenses having the product X have the AA account

Cause:

`sale_order_id` has been added to the `depends` of `hr_expense._compute_analytic_distribution`
by 2b3bf5e0fe31d4b4ef6b487da493657f695b14e1 but this wrong since we have
the `sale_expense._onchange_sale_order_id` that add the
`analytic_dostribution` field to the fields to be computed.
The compute is triggered since we change `product_id.expense_policy`,
which triggers the `_compute_can_be_reinvoiced` which triggers
the `_compute_sale_order_id`

Fix:

With this commit, we emove the depends on the compute and we also adapt
`test_compute_analytic_distribution_expense` in a way that it triggers the onchange
as we do in the original flow.

opw-4998899

In this bug, when there are multiple warehouse, and a warehouse is supplied by another one, the security lead time is repeated in calculations.

To reproduce the bug:
1- Create a db with, stock, mrp, sale installed.
2- Unarchive `MTO` route.
3- Set `Security Lead` Time in Setting.
4- Create two warehouses wh1, wh2.
5- In wh1, set `Manufacture to Resupply` to True.
6- In wh2, set `Manufacture to Resupply` to False and make it resupply from wh1.
7- Create a product and track inventory.
8- Create a BOM for the product.
9- Enable `Manufacture`, `MTO`, `wh2: Supply Product from wh1` routes for the product.
10- Create a new Quote for the product and in the Delivery, select `wh2` as the warehouse. Confirm the Quote.
11- Open MO. Security lead time is considered twice in dates calculations which is mistake.

To solve this issue, we must call `_get_dates_info` only once. The current condition might be True more than once for multiple moves. We should also check that it is not True for next moves which otherwise means the security lead time is already effected.

This issue is reproduced because this condition is not sufficient to ensure it is called once:
https://github.com/odoo/odoo/blob/c0a7b51c9e14d29cefa96c29dd716b7aec698818/addons/stock/models/stock_move.py#L1656-L1657

The above condition is written to ensure we are adding the delay only when move location is warehouse stock location.

This cause problem in multi-warehouse because we have this case that move location is warehouse stock location once for wh1 and once in wh2.

To solve this issue, we make sure the call `_get_dates_info` doesn't affect when the move has rules with src location in warehouse stock location.

related: #112325

opw-4889642

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/7e6662c53 [REL] 18.0.44 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)
https://github.com/odoo/o-spreadsheet/commit/9ca5b656c [FIX] Menu: Fix item text truncation [Task: 5072649](https://www.odoo.com/odoo/2328/tasks/5072649)
https://github.com/odoo/o-spreadsheet/commit/6a7eee11b [FIX] xlsx: remove useless warnings on import [Task: 5075112](https://www.odoo.com/odoo/2328/tasks/5075112)
https://github.com/odoo/o-spreadsheet/commit/e81d09c1e [FIX] xlsx: `=undefined` when importing array formula [Task: 4812508](https://www.odoo.com/odoo/2328/tasks/4812508)
https://github.com/odoo/o-spreadsheet/commit/71808b2b1 [REV] xlsx: make import verbose [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)
https://github.com/odoo/o-spreadsheet/commit/44df57169 [FIX] clipboard: insert cells bugged with array formulas [Task: 4938311](https://www.odoo.com/odoo/2328/tasks/4938311)

Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com>
Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com>
Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com>
Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com>
Co-authored-by: Ronak Mukeshbhai Bharadiya <rmbh@odoo.com>
Co-authored-by: Florian Damhaut (flda) <flda@odoo.com>
Co-authored-by: Rémi Rahir (rar) <rar@odoo.com>
Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com>
Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

## Versions:
16.0+

## Issue:
After confirming a Sales Order (SO), loyalty points are incorrectly calculated when applying additional promotions. This causes only one reward to be applied instead of all eligible ones.

## Cause:
When the SO is confirmed, the cost in points for each line is retrieved and deducted to compute remaining available points. However, when promotions are re-applied, the system re-evaluates the total cost of the SO and deducts the points again, effectively double-counting the same lines.

## Steps to reproduce:
- Set up a `Discount & Loyalty` promotion program:
  - 2 points granted per purchase (minimum $0).
  - Rewards:
    - 5% discount on "Simple Pen" (costs 1 point).
    - 10% discount on "Whiteboard Pen" (costs 1 point).
  - Create a Quotation with "Simple Pen" and "Whiteboard Pen".
  - Confirm the Quotation into a Sales Order.
  - Apply promotions:
    - The first reward applies correctly
    - The second reward does not apply

opw-4753472

Forward-Port-Of: odoo/odoo#211342

steps to reproduce:
-------------------
1. Install `l10n_cl`.
2. Create a new company and set Chile as the country.
3. Go to Accounting > Configuration > Journals.
4. Create a journal with type Purchase and enable Use Documents.
5. Go to Accounting > Vendors > Bills and create a bill.
6. Print Invoices / Invoices without payments.

issue:
------
The customer and company data are swapped (interchanged), and It is wrong from vendor bills point of view.

solution:
---------
The l10n_cl reports layout should only be applied to: 
- out_invoice or out_refund
- or when l10n_latam_document_type_id = (46) Electronic Purchase Invoice

**Before:**
<img width="762" height="425" alt="image" src="https://github.com/user-attachments/assets/e042485b-5d82-455f-9f34-03a0a9cdf5cc" />
**After:**
<img width="770" height="624" alt="image" src="https://github.com/user-attachments/assets/c5d09e58-bcf0-48ab-a0ae-0e37c0473a67" />



opw-4937097

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#224454

Currently, an error is encountered when a financial report contains a line with a formula that results in a division by zero.

**Steps to Reproduce:**
- Install **accountant, account_reports module** (without Demo).
- Navigate to Accounting>Reporting>Profit & Loss
- Enable Developer mode, Click on the Edit(Gear Icon) smart button, then click Create to add a new line.
- In the new expression line, set the following:
>- Computation Engine: Aggregate Other Formulas
>- Formula: NEP.balance / REV.balance
- Save the new report line.
- Reopen Profit & Loss, Report error will encounter

**Error:**
`ZeroDivisionError: float division by zero`

**Root Cause:**
At [1], in the `else` block, the case of a potential ZeroDivisionError is not handled properly, causing this issue.

[1] https://github.com/odoo/enterprise/blob/770582d4c85629568b2e64f58651f59a9a9a5f86/account_reports/models/account_report.py#L3549-L3556

**Solution:**
This commit prevents the error by ensuring that the case of a potential zero division is handled properly.

Sentry-**6720835207**