Monday, September 15, 2025
11 changes · saas-18.2
Resolved issues and error corrections
This fixes a URL formatting issue that could block Razorpay OAuth webhook generation when website payments are enabled. Businesses using Razorpay payments should see a smoother setup flow without authentication failures caused by malformed links.
Original PR description
A bad URL could be generated when the `website_payment` module is installed, as it overrides `get_base_url` and may return a URL ending with `/`. Using f-strings to create URLs could result in a double slash `//`, causing errors. Steps to reproduce: - Install `website_payment` and `payment_razorpay_oauth` - Go to Payment Acquirers and connect via OAuth - Click "Generate your webhook" - "Authentication failed" error appears This fix uses `url_join`, like other payment providers, to build URLs correctly and avoid the double slash issue. opw-5079295 Forward-Port-Of: odoo/odoo#226248
Fixes an issue where Indonesian e-Faktur documents could fail to download when an invoice line had more than one non-luxury tax applied. This helps accounting users complete tax document downloads reliably and avoids a crash during invoice processing.
Original PR description
The system crashes with an error when a user tries to `download the e-Faktur` document. **Steps to produce:-** - Install `Accounting` and switch to `ID Company`(with demo data). - Create a `new…
The system crashes with an error when a user tries to `download the e-Faktur` document.
**Steps to produce:-**
- Install `Accounting` and switch to `ID Company`(with demo data).
- Create a `new invoice` and select customer as `ID Company`.
- Add the product and in `taxes add 11% and 0% (2 non-luxury taxes)` and confirm the invoice.
- Click on gear icon and click on `Download e-Faktur` button.
**Error:-**
`ValueError: ValueError('Expected singleton: account.tax(5, 15)') while
evaluating 'action = records.download_efaktur()'`
**Root cause:-**
- When more than one non-luxury tax is applied and the e-Faktur document is downloading, the code at [1] expects a single tax record, but multiple non-luxury taxes are found.
**Solution:-**
- Since luxury tax is already excluded from the regular tax computation at [2], I think we can directly sum all non-luxury taxes.
[1]: https://github.com/odoo/odoo/blob/52aa6231130ea165fdb44e6370ec3e396b7603cc/addons/l10n_id_efaktur_coretax/models/account_move_line.py#L52
[2]: https://github.com/odoo/odoo/blob/52aa6231130ea165fdb44e6370ec3e396b7603cc/addons/l10n_id_efaktur_coretax/models/account_move_line.py#L24-L25
**sentry-6837559933**
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#224419Fixed an issue where loyalty points could be counted twice after a sales order was confirmed, preventing eligible rewards from being applied. Customers and sales teams can now apply all valid loyalty promotions consistently on confirmed orders.
Original PR description
## Versions: 16.0+ ## Issue: After confirming a Sales Order (SO), loyalty points are incorrectly calculated when applying additional promotions. This causes only one reward to be applied instead of…
## Versions:
16.0+
## Issue:
After confirming a Sales Order (SO), loyalty points are incorrectly calculated when applying additional promotions. This causes only one reward to be applied instead of all eligible ones.
## Cause:
When the SO is confirmed, the cost in points for each line is retrieved and deducted to compute remaining available points. However, when promotions are re-applied, the system re-evaluates the total cost of the SO and deducts the points again, effectively double-counting the same lines.
## Steps to reproduce:
- Set up a `Discount & Loyalty` promotion program:
- 2 points granted per purchase (minimum $0).
- Rewards:
- 5% discount on "Simple Pen" (costs 1 point).
- 10% discount on "Whiteboard Pen" (costs 1 point).
- Create a Quotation with "Simple Pen" and "Whiteboard Pen".
- Confirm the Quotation into a Sales Order.
- Apply promotions:
- The first reward applies correctly
- The second reward does not apply
opw-4753472
Forward-Port-Of: odoo/odoo#226156
Forward-Port-Of: odoo/odoo#211342The purchase catalog now shows supplier prices using the vendor's unit of measure instead of the product's default unit. This prevents misleading prices and unit labels when buyers create purchase orders from the catalog.
Original PR description
## Issue: The price in the catalog is incorrect when opening it for a purchase order if the vendor use another unit of measure than the product The displayed unit of measure's name is also incorrect…
## Issue: The price in the catalog is incorrect when opening it for a purchase order if the vendor use another unit of measure than the product The displayed unit of measure's name is also incorrect and don't match with the displayed price ## Cause: The `seller.discounted_price` was used but it give prices using the product UoM and not the one the vendor's UoM that the catalog currenlty use Calling the function `_update_order_line_info()` (https://github.com/odoo/odoo/blob/fd29fc43241c6e4b892aae5ba1b251fb4bcc0d84/addons/purchase/models/purchase_order.py#L1149-L1183) multiple times, will fix the unit price because it recompute the catalog price from the `purchase_order_line` using the right UoM https://github.com/odoo/odoo/blob/536b3536e429f563a5c6ef024fc03db866f72394/addons/purchase/models/purchase_order_line.py#L336 ## Limitations: When opening the catalog, the UoM is always set to the first vendor UoM and never updated afterwards For vendors with multiple UoMs, changing quantity will not switch the UoM, which can cause mismatches between the ordered quantity and the vendor option that offers the best price For example, if the vendor offers a lower price starting from 5 kg but the first UoM is 3kg, ordering 6 kg will result in 2 times 3kg instead of 6 times 1 kg but keep the cheaper price ## Steps to reproduce: - Create a Product to Buy (Cost 10$ par kg) - Add a Purchase line (Unit (Name: 2kg, Quantity: 2.0 kg), Unit Price: 15.0) - Create a New RFQ for the Vendor - Open the Catalog to see the price (7.50/kg) - Add 2 products, it goes to 15.0/kg (in fact 15.0/2kg) opw-4982309
This fixes an issue in Attendance where extra hours could remain stuck after a manager or employee changed check-in or check-out times. The system now recalculates extra hours when appropriate, while still respecting cases where the value was intentionally changed manually.
Original PR description
**Steps to reproduce** - Automatically approved attendances. - Create an attendance and save it. - Note the "Extra hours" displayed. - Manually modify the "Extra hours". - Save the form view. -…
**Steps to reproduce** - Automatically approved attendances. - Create an attendance and save it. - Note the "Extra hours" displayed. - Manually modify the "Extra hours". - Save the form view. - Change the check in or check out and save it. - Issue: "Extra hours" should be recomputed. **Cause** Issue since https://github.com/odoo/odoo/commit/cc81bb59f87540cf4dd8da65510417d8023ef65b The problem is that a value for `overtime_hours` was computed for the `NewId` record used during edition in the interface. This meant `validated_overtime_hours` was also set to this value https://github.com/odoo/odoo/blob/cc81bb59f87540cf4dd8da65510417d8023ef65b/addons/hr_attendance/models/hr_attendance.py#L171 and sent on save, which meant the value was not further recomputed in `_update_overtime`. https://github.com/odoo/odoo/blob/cc81bb59f87540cf4dd8da65510417d8023ef65b/addons/hr_attendance/models/hr_attendance.py#L408 **Change** We avoid a recomputation of `validated_overtime_hours` in the interface to avoid it being interpreted as a manual change by the user. opw-[5003488] Forward-Port-Of: odoo/odoo#222689
This fix ensures employee time-off timesheets are recreated correctly when a public holiday is deleted or its calendar assignment changes. It prevents missing or duplicated timesheet entries, helping keep leave tracking and payroll-related reporting accurate.
Original PR description
…ay change **Steps to reproduce** - Create a public holiday without a calendar during a work day. - Create a leave for an employee overlapping the public holiday for a time off type generating…
…ay change **Steps to reproduce** - Create a public holiday without a calendar during a work day. - Create a leave for an employee overlapping the public holiday for a time off type generating Timesheets. Validate it. - Expected: on the day of the public holiday, no timesheet is generated for the `hr.leave` to avoid duplication. - Either delete the public holiday, or set a calendar on it different than the one defined on the employee. - Issue: the public holiday timesheet has been deleted, but its deletion should've lead to the creation of the `hr.leave` timesheet that we didn't create at the time the public holiday existed. - Second issue: after that, change the calendar of the public holiday to the same as the employee's. Still a missing timesheet. **Solution** We can use `_reevaluate_leaves` to find the leaves affected by changes in public holidays. `_generate_timesheets` then re-generates the timesheets as if the leave was just validated (the call to `list_work_time_per_day` ignores the already present resource.calendar.leave). We also check missing public holidays timesheets to fix the second issue. opw-4819697 Forward-Port-Of: odoo/odoo#222726 Forward-Port-Of: odoo/odoo#216901
Users can now add several new comma-separated tags to a forum post without triggering an error. This prevents failed post submissions and improves the reliability of forum content creation.
Original PR description
Currently, an error occurs when a user tries to add multiple comma-separated new tags to a forum post. **Steps to reproduce:** - Install the `website_forum` module. - Go to: `Website > Configuration…
Currently, an error occurs when a user tries to add multiple comma-separated new tags to a forum post. **Steps to reproduce:** - Install the `website_forum` module. - Go to: `Website > Configuration > Forums`, create a new forum, then click `Go to Website`. - Click on `Start by creating a post`, enter content, and set the `Tags` to `_test, retour affectif rapide`. - Click on `Post Your Question`. **Error:** `ValueError: invalid literal for int() with base 10: 'retour affectif rapide'` **Root Cause:** After PR #169472, at [1], the code prepends an underscore (_) only to the entire input string instead of each tag. When multiple tags are entered, the backend receives a mixed list of values (e.g., ['__test', 'retour affectif rapide']), leading to an error during `int()` conversion at [2]. **Fix:** This commit updates the `onCreateOption` logic to prepend an underscore to each tag in the comma-separated input, similar to [3]. Also updated the test case at [4], to click `Create option` to save the tags. [1]: https://github.com/odoo/odoo/blob/afa26af132566a68ad6bf67565062bd73ddd7429/addons/website_forum/static/src/js/website_forum.js#L54-L61 [2]: https://github.com/odoo/odoo/blob/afa26af132566a68ad6bf67565062bd73ddd7429/addons/website_forum/models/forum_forum.py#L304 [3]: https://github.com/odoo/odoo/blob/ac93a25b216e6194895a64fe12c0d01f6833f743/addons/website_forum/static/src/js/website_forum.js#L69-L80 [4]: https://github.com/odoo/odoo/blob/d155edfd729ab9b53f38939fe24b6d1e7b578083/addons/website_forum/static/tests/tours/website_forum_question.js#L34-L37 sentry-6761920887 Forward-Port-Of: odoo/odoo#220058
Guest shoppers could see a Forbidden error when the website shop tried to determine the correct fiscal position from their location. This fix ensures that fiscal position information can be read safely during checkout calculations, improving reliability for public visitors.
Original PR description
Ensure the fiscal position is always computed using sudo. When computing the fiscal position based on geolocated country, the result may not be return without sudo. Steps to reproduce: - Set a default Fiscal Position on the contact model (property_account_position_id) - Visit the website shop without logging in. - You will get a Forbidden error because Odoo raises an access error when fetching the fiscal position. This fix add a sudo() to the partner used to compute the fiscal position, so that when accessing the partner property, it will be returned with `env.su = True`. opw-5058588
Fixes an issue that could prevent Italian companies from posting tax return closing entries. The tax return search is now evaluated correctly, avoiding an error during the closing entry posting process.
Original PR description
The `osv.expression.AND` operator was incorrectly used, leading to an invalid search domain and raising an error. Steps to reproduce: - Set the company country to Italy - Go to Accounting > Reporting > Tax return - Create a closing entry - Try to post the closing entry - An error is raised: ```python elif token[1] == 'in' and not (isinstance(token[2], Query) or token[2]): ~~~~~^^^ IndexError: string index out of range ``` The fix wraps the subdomain in a list so the domain is properly evaluated. opw-5075640 Forward-Port-Of: odoo/enterprise#94440 Forward-Port-Of: odoo/enterprise#94277
This fixes an error that could block Ecuadorian delivery guide generation when the Barcode Scanner setting was turned off. Businesses can now create delivery guides reliably regardless of whether barcode scanning is enabled in Inventory.
Original PR description
Currently, an error occurs when generating a Delivery Guide if the Barcode Scanner is disabled in the Inventory settings. **Steps to reproduce:** - Install the `l10n_ec_edi_stock` module and switch…
Currently, an error occurs when generating a Delivery Guide if the Barcode Scanner is disabled in the Inventory settings. **Steps to reproduce:** - Install the `l10n_ec_edi_stock` module and switch to the `EC company`. - Uncheck `Barcode Scanner` in the Inventory `settings`. - Create a new warehouse and set the `Entity` and `Emission Point`. - Navigate to Inventory > Operations > Deliveries and create a new delivery. - Add details > mark as Todo > Validate > Generate Delivery Guide. **Error:** `AttributeError: 'stock.move.line' object has no attribute 'qty_done'` **Root Cause:** At [1], the code references `line.qty_done`, but this field is defined in the `stock_barcode` module at [2]. When the Barcode Scanner is `disabled`, the field is not available, leading to the `error`. **Fix:** This commit updates the delivery guide values to use `line.quantity` instead of `line.qty_done` at [1] and at [4]. Since in the `stock_barcode` module at [3], `qty_done` is derived from `quantity`. [1]: https://github.com/odoo/enterprise/blob/ba5b9790f28e2f7eabda22e5992737eab0e82c6e/l10n_ec_edi_stock/models/stock_picking.py#L354 [2]: https://github.com/odoo/enterprise/blob/8c53e50df1cf9dc6d3ca4cae19c39135ac85d4e4/stock_barcode/models/stock_move_line.py#L23 [3]: https://github.com/odoo/enterprise/blob/8c53e50df1cf9dc6d3ca4cae19c39135ac85d4e4/stock_barcode/models/stock_move_line.py#L48-L50 [4]: https://github.com/odoo/enterprise/blob/8b72fdef63f634ccf436b49adbac5c1f9358c127/l10n_ec_edi_stock/views/report_delivery_guide.xml#L165 sentry-6851008674 Forward-Port-Of: odoo/enterprise#93775
This fix ensures subscription recurring totals use the amounts returned by external tax calculators instead of being recalculated internally. Businesses using external tax services will see more accurate recurring totals on subscription orders.
Original PR description
sale_subscription now uses `account.tax` to recalculate the tax amounts [1], thus bypassing amounts set by external calculators. For externally calculated orders, we override the recurring_total calculation to restore the previous behavior of calculating the amount using `price_subtotal` on the lines. This field will contain the amount returned by the external calculator. [1] https://github.com/odoo/enterprise/commit/70376f94e9f26e631890312edc0857d9ff37dc7b opw-4964610 Forward-Port-Of: odoo/enterprise#93054