Daily updates from Odoo
Friday, September 19, 2025
22 changes
4 changes
Resolved issues and error corrections
The calendar year view now responds properly when the browser window is resized. This prevents display issues and helps users keep a clear yearly schedule view across different screen sizes.
Original PR description
FullCalendar already applies a debounce on the `windowResize` handler. Thus, doing it again in our renderer is a duplicated effort. Also, in the Year calendar renderer, the debounced version of the handler is initialized after the FullCalendar instances (one for each month) are created... which prevents it from being run at all. This commit fixes and cleans this up by directly passing our handler to FullCalendar, letting him do the rest. task-4809668 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#227725 Forward-Port-Of: odoo/odoo#227458
This fix gives the test user the required Sales access so Mexican localization tests can create sales orders successfully. It does not change business behavior, but helps keep automated checks reliable for this localization.
Original PR description
The tests `test_global_discount` and `test_down_payment` in `l10n_mx_edi_sale` were failing with:
AccessError: You are not allowed to create 'Sales Order' (sale.order) records.
This happened because `mx_external_setup` runs with a user that does not belong to any Sales group. Both tests explicitly create Sale Orders and advance payment wizards, which require Sales ACLs.
This change ensures the test user has the `sales_team.group_sale_salesman` group in `setUpClass`, so Sales Orders can be created normally. No business logic is modified, only test stabilization for the MX localization.
[RB-232559](https://runbot.odoo.com/odoo/error/232559)
Forward-Port-Of: odoo/enterprise#94911Field service tasks created from templates now correctly keep the template's "Under Warranty" setting. This ensures warranty-related service work is identified accurately from the start, reducing manual correction and billing or service handling mistakes.
Original PR description
**Steps to reproduce:**
- Install industry_fsm_sale
- Create a task template with "Under Warranty" enabled
- Create a task from that template
**Issue:**
The created task does not carry over the "Under Warranty" value from the task template.
**Cause:**
The `under_warranty` field has `copy=False`, so the value is not transferred.
**Fix:**
Updated the copy method to check for `copy_from_template` in the context. If the task template has "Under Warranty" enabled, the field is explicitly set on the new task.
task: 5083386
Forward-Port-Of: odoo/enterprise#94924This fix prevents crashes when the system loads unusual record combinations, such as temporary records mixed with saved records or records with an empty identifier. It improves overall platform stability and keeps behavior consistent across core data operations.
Original PR description
This commit addresses two corner cases that cause `fetch()` to crash: Mixing new and real records: - Issue: If a recordset contains both new and real records, `fetch()` raises an `AccessError`. - Rationale: While we typically assume that new and real records are never mixed, certain recordset operations can inadvertently lead to this state. Handling this case improves the overall robustness of the ORM. Using `False` as a record id: - Issue: Using a record with a `False` id, such as `browse([False])`, causes a SQL error when `fetch()` is called. - Rationale: Other operations, like `browse([False]).name`, work without crashing. To ensure consistency across the ORM, `fetch()` should also handle `False` ids without error. Forward-Port-Of: odoo/odoo#227447
5 changes
Resolved issues and error corrections
Opening Knowledge activities now filters the article list to the articles that actually have matching activities. This prevents users from landing on an unfiltered list of all articles and helps them find the relevant work faster.
Original PR description
Currently, when the user tries to open any activity of the knowledge article, it opens all articles instead of the one which has an activity assigned to them. **Steps to reproduce this issue:** 1) Install the Knowledge module 2) Set up an activity for yourself on a Knowledge article 3) Open the activities from Activities (top left corner) **Issue:** You will end up in the all articles list, with no filters applied. **Cause:** When the user clicks on the activities, a default search filter is added in the context, which is then applied on the view. But in the knowledge article, we don't have any search filters for the activities. Therefore, it renders all knowledge article records. **Solution:** Add search filters for the knowledge articles. opw-4997201 Forward-Port-Of: odoo/enterprise#93609
This fixes an error that appeared when opening the barcode scanner in Attendance kiosk mode while debug mode was enabled. The scanner now uses the standard barcode scanning flow, preventing the crash and improving reliability for users managing attendance check-ins.
Original PR description
**Step to reproduce:** - install Attendances app - turn on debug mode - go to Attendance -> kiosk mode - open the scanner **Observation:** - We get a traceback **Cause:** - we pass a extra prop `token` to BarcodeDialog component, which is not accepted by it https://github.com/odoo/odoo/blob/178dff30131a93680dfd994fd22b29a766ee9354/addons/web/static/src/core/barcode/barcode_dialog.js#L12 - this raises issue from OWL when we have debug-mode on **Fix:** - reuse the actual `scanBarcode` method and remove the faulty one. https://github.com/odoo/odoo/blob/178dff30131a93680dfd994fd22b29a766ee9354/addons/web/static/src/core/barcode/barcode_dialog.js#L47-L60 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#227551 Forward-Port-Of: odoo/odoo#225738
Creating a field service task from a template now correctly keeps the template's Under Warranty setting. This helps teams avoid missed warranty coverage details and reduces manual corrections after task creation.
Original PR description
**Steps to reproduce:**
- Install industry_fsm_sale
- Create a task template with "Under Warranty" enabled
- Create a task from that template
**Issue:**
The created task does not carry over the "Under Warranty" value from the task template.
**Cause:**
The `under_warranty` field has `copy=False`, so the value is not transferred.
**Fix:**
Updated the copy method to check for `copy_from_template` in the context. If the task template has "Under Warranty" enabled, the field is explicitly set on the new task.
task: 5083386This update prevents crashes when Odoo loads records in rare invalid or mixed states. It makes the core data layer more consistent and reliable, reducing unexpected errors for users and administrators.
Original PR description
This commit addresses two corner cases that cause `fetch()` to crash: Mixing new and real records: - Issue: If a recordset contains both new and real records, `fetch()` raises an `AccessError`. - Rationale: While we typically assume that new and real records are never mixed, certain recordset operations can inadvertently lead to this state. Handling this case improves the overall robustness of the ORM. Using `False` as a record id: - Issue: Using a record with a `False` id, such as `browse([False])`, causes a SQL error when `fetch()` is called. - Rationale: Other operations, like `browse([False]).name`, work without crashing. To ensure consistency across the ORM, `fetch()` should also handle `False` ids without error. Forward-Port-Of: odoo/odoo#227447
This fix prevents the messaging editor from crashing when a user presses ArrowUp while editing an attachment-only message. It keeps the composer stable in this edge case, improving reliability without changing normal messaging behavior.
Original PR description
**Description of the issue this PR addresses:** ------------------------------------------------ Pressing the ArrowUp key in the editing composer when it is empty while editing a message with only an attachment caused a JavaScript traceback. This happened because the composer was not associated with a thread, and the code tried to access `composer.thread.lastEditableMessageOfSelf`. **Current behavior before PR:** --------------------------------- - Pressing ArrowUp in the empty editing composer triggers a TypeError - The error occurs when editing a message that only has an attachment - The composer does not have a thread reference **Desired behavior after PR is merged:** ----------------------------------------- - Pressing ArrowUp in this scenario safely checks if a thread exists - No TypeError occurs, and the composer remains stable **Task:** 5068553 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
Opening a Knowledge activity now shows only the articles linked to that activity instead of the full article list. This helps users get directly to the relevant work item and avoids confusion when managing assigned activities.
Original PR description
Currently, when the user tries to open any activity of the knowledge article, it opens all articles instead of the one which has an activity assigned to them. **Steps to reproduce this issue:** 1) Install the Knowledge module 2) Set up an activity for yourself on a Knowledge article 3) Open the activities from Activities (top left corner) **Issue:** You will end up in the all articles list, with no filters applied. **Cause:** When the user clicks on the activities, a default search filter is added in the context, which is then applied on the view. But in the knowledge article, we don't have any search filters for the activities. Therefore, it renders all knowledge article records. **Solution:** Add search filters for the knowledge articles. opw-4997201 Forward-Port-Of: odoo/enterprise#93609
3 changes
Resolved issues and error corrections
This update fixes internal test failures in the Mexico electronic invoicing sales module by giving the test user the needed Sales permissions. It helps keep automated checks reliable without changing any customer-facing business behavior.
Original PR description
The tests `test_global_discount` and `test_down_payment` in `l10n_mx_edi_sale` were failing with:
AccessError: You are not allowed to create 'Sales Order' (sale.order) records.
This happened because `mx_external_setup` runs with a user that does not belong to any Sales group. Both tests explicitly create Sale Orders and advance payment wizards, which require Sales ACLs.
This change ensures the test user has the `sales_team.group_sale_salesman` group in `setUpClass`, so Sales Orders can be created normally. No business logic is modified, only test stabilization for the MX localization.
[RB-232559](https://runbot.odoo.com/odoo/error/232559)
Forward-Port-Of: odoo/enterprise#94911The automatic cleanup process now skips documents linked to signed agreements, preventing background errors when trash is cleared. Users will still be informed if they try to manually delete protected signed documents, preserving important records and avoiding system noise.
Original PR description
Currently an error occurs when auto vacuum tries to clear documents linked to `sign_document`. **Steps to replicate:** * Install `documents_sign` with demo data. * Go to documents > Move Employment…
Currently an error occurs when auto vacuum tries to clear documents linked to `sign_document`. **Steps to replicate:** * Install `documents_sign` with demo data. * Go to documents > Move Employment contracts to trash * Trash > Try to to delete employment contract you will see error in terminal. Similarly error will be produced by the Auto-Vacuum process when it attempts to delete it after the configured deletion delay. **Error:** `ForeignKeyViolation: update or delete on table 'ir_attachment' violates foreign key constraint 'sign_document_attachment_id_fkey' on table 'sign_document' DETAIL: Key (id)=(1164) is still referenced from table 'sign_document'.` **Root cause:** * At [1], the `sign.document` model was introduced, which prevents the deletion of sign documents. As a result, attempting to delete them due to [2] will cause an error. **Solution:** * Update the `_get_gc_clear_bin_domain` to ensure that the Auto-Vacuum process skips sign documents. * This will still throw an Validation and ForeignKey error as expected when the user tries to delete it from the GUI letting them know it cannot be deleted. [1]: https://github.com/odoo/enterprise/commit/4254542e8fb4ce3b2b9b46c624d86f7fcac8df7b#diff-deebbcccf829fd1804d145c5c7140b482801644bd948639f77caa310b18b8120 [2]: https://github.com/odoo/enterprise/blob/828d47f9ad1d5e396b074c404287799574a6d692/sign/models/sign_document.py#L44 sentry-6842360375 Forward-Port-Of: odoo/enterprise#95086 Forward-Port-Of: odoo/enterprise#93818
This update keeps subscription-related website sales pages aligned with recent changes in the main Odoo website sales flow. It helps ensure customers can continue using subscription checkout and related pages without disruption after the platform update.
Original PR description
Forward-Port-Of: odoo/enterprise#95078
8 changes
Resolved issues and error corrections
Fixed an issue that could block users from creating new attendee records from the eLearning reporting views. This prevents an unexpected error and keeps attendee management working reliably.
Original PR description
Currently an error occurs when creating the attendee records. Steps to Reproduce: - Install the `website_slide` module. - Go to `Reporting` > `Attendees`. - Go to either the `Graph or Pivot View` and…
Currently an error occurs when creating the attendee records. Steps to Reproduce: - Install the `website_slide` module. - Go to `Reporting` > `Attendees`. - Go to either the `Graph or Pivot View` and click on any `count` value. - Open any attendee record and click on `New`. `SyntaxError: syntax error at or near ")" LINE 18: WHERE SCP.id IN () ^` This error occurs when creating an Attendee record. The _compute_next_slide_id method runs every time the record is accessed, which causes the error [1]. As clearly mentioned in [this commit](https://github.com/odoo/odoo/commit/fd2fb88bb155b680147313433d22a2b7388c902c#diff-1ee3fce434db0c4e897973eebf5c1be501196cbd413e6c250ecc973238f939b9L292-R326), when a compute method is declared without the @api.depends(...) decorator or with no actual dependencies, the computed field will still be initialized when creating a new record from a form view. This commit ensures that when the compute method runs and the record has not been created yet, the next_slide_id is set to False. [1]:- https://github.com/odoo/odoo/blob/9f18013bc05e6657f5d41c05931fcdafad827d54/addons/website_slides/models/slide_channel.py#L91 sentry-6465821899 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#227733 Forward-Port-Of: odoo/odoo#217104
The calendar year view now handles browser resizing reliably by using FullCalendar's built-in resize handling instead of duplicating it. This helps users keep a properly adjusted yearly calendar layout when changing window size or device orientation.
Original PR description
FullCalendar already applies a debounce on the `windowResize` handler. Thus, doing it again in our renderer is a duplicated effort. Also, in the Year calendar renderer, the debounced version of the handler is initialized after the FullCalendar instances (one for each month) are created... which prevents it from being run at all. This commit fixes and cleans this up by directly passing our handler to FullCalendar, letting him do the rest. task-4809668 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#227725 Forward-Port-Of: odoo/odoo#227458
Archived tasks opened through project sharing now match the standard project view by hiding the Recurrent field. This prevents users from seeing an option that should not apply to inactive tasks, making the shared project experience more consistent.
Original PR description
**Steps to Reproduce:** - Share a project. - From the shared project, archive a task. - Open the archived task in the standard project form view → the Recurrent field becomes invisible (as expected).…
**Steps to Reproduce:**
- Share a project.
- From the shared project, archive a task.
- Open the archived task in the standard project form view → the Recurrent field becomes invisible (as expected).
- Open the same archived task from the Project Sharing view by applying the Inactive/Archived filter → the Recurrent field is
still visible.
**Issue:**
The Recurrent field should not be visible for archived tasks. However, in the Project Sharing view, it still appears for inactive tasks.
**Current behaviour:**
The Recurrent field is hidden in the standard form view for archived tasks, but remains visible in the project sharing view.
**Expected behaviour:**
The Recurrent field should remain invisible in both the standard form view and the project sharing view when the task is archived.
**Fix:**
Adjusted the project sharing form view XML to apply the same invisible logic, ensuring the Recurrent field is hidden when the task is archived.
**Task-5040281**
Forward-Port-Of: odoo/odoo#226220Field Service task forms now show the repeat interval directly under the planned date. This makes recurring task settings easier to find and keeps related scheduling information together.
Original PR description
**Steps to Reproduce:** 1. Open the Field Service app. 2. Create or open an existing task. 3. Check the form view of the task. **Issue:** - The 'Repeat Every' block was displayed at the bottom of the sheet, making it less intuitive. - It should logically appear under the 'Planned Date' block for better visibility. **Current behaviour:** - The 'Repeat Every' block appears in a different section, away from the 'Planned Date' block. **Expected behaviour:** - The 'Repeat Every' block should be displayed directly under the 'Planned Date' block for better usability and logical grouping. **Fix:** - Adjusted the form view XML to move the 'Repeat Every' field below the 'Planned Date' field. **Task-5040281** Forward-Port-Of: odoo/enterprise#93208
This update keeps the online subscription purchase flow aligned with recent changes in the main website sales system. It helps prevent display or checkout issues for customers buying subscriptions online.
Italian split payment taxes now show the correct label in the Taxes column of PDF documents instead of appearing like standard taxes. This helps customers and businesses read tax information accurately on generated documents.
Original PR description
Split payment taxes were not labelled correctly in the PDF's "Taxes" column, they were labelled as standard taxes. <img width="1214" height="598" alt="image" src="https://github.com/user-attachments/assets/f1ea57bd-9a7f-460f-8c81-6a89585ba6d8" /> Forward-Port-Of: odoo/odoo#227284 Forward-Port-Of: odoo/odoo#226366
This update fixes internal automated tests for the Mail app by making sure they select the correct "Add a reaction" button when two similar options are present. It helps keep message reaction functionality stable without changing the user experience.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/227728 PR above improved quick add a reaction to use quick reaction menu too, similarly to "Add a reaction" in the message actions. By doing so, the 2 buttons to add a reaction have been adapted to use same label "Add a reaction", one was just "Add reaction". Some HOOT tests were asserting presence of the "Add a reaction" button, but with the change there are sometimes 2 such buttons, one being the message action and the other is the quick add reaction. Tests were adapted but not all of them: when they expect to click on "Add a reaction" on a message with at least one reaction, it should clarify whether the "Add a reaction" is the one in message action or the one in quick add a reaction, otherwise the HOOT test fails due to attempting to click on the 2 buttons at once. This commit fixes with more specific selector, that the "Add a reaction" to click is the one from message actions.
This update prevents crashes when the system loads records in uncommon but possible situations, such as mixed temporary and saved records or records with an empty identifier. It improves reliability in the core data layer and makes behavior more consistent across Odoo.
Original PR description
This commit addresses two corner cases that cause `fetch()` to crash: Mixing new and real records: - Issue: If a recordset contains both new and real records, `fetch()` raises an `AccessError`. - Rationale: While we typically assume that new and real records are never mixed, certain recordset operations can inadvertently lead to this state. Handling this case improves the overall robustness of the ORM. Using `False` as a record id: - Issue: Using a record with a `False` id, such as `browse([False])`, causes a SQL error when `fetch()` is called. - Rationale: Other operations, like `browse([False]).name`, work without crashing. To ensure consistency across the ORM, `fetch()` should also handle `False` ids without error. Forward-Port-Of: odoo/odoo#227447
1 change
Resolved issues and error corrections
The spreadsheet component was updated to a newer maintenance version with fixes for formula error messages and handling of empty cells in internal operations. This helps users get clearer feedback and reduces the risk of incorrect spreadsheet behavior in Odoo.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/bf7d9c8ac [REL] 17.0.74 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0)…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/bf7d9c8ac [REL] 17.0.74 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) https://github.com/odoo/o-spreadsheet/commit/2612a1243 [FIX] package: add swc binaries to optional dependencies [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) https://github.com/odoo/o-spreadsheet/commit/ced4ea861 [FIX] functions: wrong error message for `SORT` [Task: 5085267](https://www.odoo.com/odoo/2328/tasks/5085267) https://github.com/odoo/o-spreadsheet/commit/1e01797f0 [FIX] helpers: preserve sparse(empty) elements in removeIndexesFromArray [Task: 4977932](https://www.odoo.com/odoo/2328/tasks/4977932) Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Ronak Mukeshbhai Bharadiya <rmbh@odoo.com> Co-authored-by: Florian Damhaut (flda) <flda@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>