Saturday, September 27, 2025
3 changes · master
Enhancements to existing features
Adds broader automated checks for Mexican payroll CFDI signing, covering more payroll scenarios such as bonuses, savings funds, and deductions. This helps reduce the risk of payroll documents being generated incorrectly and improves confidence in compliance-related payroll processing.
Original PR description
This adds a bunch of scenarios for the CFDI signing. Task: 5066078 Forward-Port-Of: odoo/enterprise#94436
Resolved issues and error corrections
A test was added to ensure cash basis journal item lines keep the correct journal entry name after posting instead of showing '/'. This helps accountants trust that journal item lists display accurate references for reconciled payments and cash basis tax entries.
Original PR description
This commit adds a test for the [change made in community](https://github.com/odoo/odoo/pull/225558). ### Issue: In the list view of Journal Items, cash basis lines show a `move_name` of '/' event if…
This commit adds a test for the [change made in community](https://github.com/odoo/odoo/pull/225558). ### Issue: In the list view of Journal Items, cash basis lines show a `move_name` of '/' event if the move is posted and has a name. ### Steps to reproduce: - Activate Cash Basis in the accounting settings - Create a tax with "Tax Exigibility" set "Based on Payment" - Set the "Cash Basis Transition Account" to "Current Assets" - Activate reconciliation on "Current Assets" - Create an invoice with this tax, confirm - In the dashboard, click on Bank and new - Set the name of the invoice as the label, and the amount of the invoice as amount - Save & Close - Go in Accounting > Transactions > Journal Items - The lines created for the cah basis entry display '/' in the column "Journal Entry" ### Cause: This issue is linked to the order in which things are done in `_set_next_sequence`: the fields triggered by the sequence field are added in `self.env.transaction.tocompute` then the sequence is computed and assigned. When `_set_next_sequence()` is called from [`_create_tax_cash_basis_moves()`](https://github.com/odoo/odoo/blob/849e4a87178d8c8588b75e3f7d9073d6a78326f9/addons/account/models/account_partial_reconcile.py#L649-L654) this order is problematic as `account.move.line.move_name` will be computed and removed from `self.env.transaction.tocompute`. So it will not be updated when the sequence is assigned in `account.move.name`. The callstack is something like this: - `_set_next_sequence()` calls `_locked_increment()` to compute the sequence - `_locked_increment()` calls `flush_recordset()` which will call `_recompute_recordset()` to recompute all fields - `_compute_invoice_date_due()` needs the field `needed_terms` triggering `_compute_needed_terms()` - `_compute_needed_terms()` needs `invoice_line_ids` - the fetch on `account.move.line` is ordered by `move_name` - So `_compute_related()` is triggered for `move_name` and `account.move.line.move_name` is removed from `self.env.transaction.tocompute` Then `_locked_increment()` returns the sequence, it gets assigned as the move name and `move_name` is never updated because it's not in `self.env.transaction.tocompute`. This doesn't occur in other flows (like calling `action_post()`) because the value of `needed_terms` is read from the cache. ### Solution: Swap the order in which things are done in `_set_next_sequence()`: first compute and assign the sequence and then add the triggered fields in `self.env.transaction.tocompute` so that they are computed afterwards. It seems more logic that way: we change the `_sequence_field` then mark all fields that will be impacted in `tocompute`. opw-5056938 Forward-Port-Of: odoo/enterprise#94111
This fix updates Planning test behavior so one test no longer causes delays or failures in later tests. It helps keep automated checks stable, reducing false alarms during development and release validation.
Original PR description
Due to the nature of the test cases written returning an empty object to actionService in test cases as they overriden using onRpc and causes a delay error, which causes the next case to fail. Fix: - Replace the empty object with a false, which is handled in the function runbot-231599 Forward-Port-Of: odoo/enterprise#94605